From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 54B0C1B2A8 for ; Tue, 31 Oct 2017 11:17:20 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id n74so12428018wmi.1 for ; Tue, 31 Oct 2017 03:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B9R9V30dKZdVhzNr93jHGJAF3aWPgeF4Dj2G0umUXhk=; b=1T3IMePJkEJEsf8ehPmlNHviYn5ok1SexHshuRtF4BM76NxI/OGMFFBrN8BnhXA3yo aCjylQM2omUmHoQUZu549z4ZIoZcNgfP9SyN7CaGFK7xZOCzEOqdkmO+AOMjMOx65O4/ FsuOA4OJ9xlXEu0ausD6whAQa9oE72mW97o8iJ0gv6/RKAZbCTvebs/Um5hpWDxUdJGG QgqJOUL65z3HEker+DmaZUAxjK11e2lUxChsX0afCHKQyNu1vu7EFAToWD11c5dvL9CK qsp01sQJU1Xj6oPsIRMJ6veHLQPIQJcGHmIjKU6A7x5OxPB6PvHUUg6YKw+BYpW7S+8b lJGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B9R9V30dKZdVhzNr93jHGJAF3aWPgeF4Dj2G0umUXhk=; b=KddDRhX6XP1pzlSXcdMXAYUifNLhV0QcbtAje0qRXtFf8MdNjdedZiRX1ZqmVveUA6 ev4FC9sIHSVkGBq7JSoszTOpI2klhsu0XybYVvjLZIrMqklYpIskQTrr8eJLXyz1fFna IcErFGkO7xVFzX9S/D2evwwNawB8SlRQ8fU8ukaICAVDV3RQPw8+95OQMElT9M49gBp6 NPJNYcSwkf4U+rgV4V8PLkxongjxt0wGmObomEb7ILnK6z5q9AObamySToCZ4jzOhBtj kOwrqfzKpL4RB1wJaHDRmO54FpGVYQWbqZ+fEWr60FltTy1t+I9hGWMBd+oe7Yz6tQbH ahJw== X-Gm-Message-State: AMCzsaW91HGHIQjFRcF/fBygEszlRZYm3fycbQihoQvSyqx1XWQjGapR CUJr15JhTu/TTpXuoxSFNEd1GPWu X-Google-Smtp-Source: ABhQp+TA+z8cGF7tf/6Uj5pxznyOGx1PW3WI0eoQnN/OYHF7s/fkdSDHxsVE0F4qPX14VPAu3WBIJA== X-Received: by 10.80.177.82 with SMTP id l18mr2246710edd.175.1509445040115; Tue, 31 Oct 2017 03:17:20 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z23sm1063194edm.62.2017.10.31.03.17.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2017 03:17:19 -0700 (PDT) Date: Tue, 31 Oct 2017 11:17:08 +0100 From: Adrien Mazarguil To: Matan Azrad Cc: "dev@dpdk.org" , Ophir Munk Message-ID: <20171031101708.GK26782@6wind.com> References: <1508768520-4810-1-git-send-email-ophirmu@mellanox.com> <1509358049-18854-1-git-send-email-matan@mellanox.com> <1509358049-18854-6-git-send-email-matan@mellanox.com> <20171030142344.GB26782@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v3 5/7] net/mlx4: separate Tx segment cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2017 10:17:20 -0000 On Mon, Oct 30, 2017 at 06:23:31PM +0000, Matan Azrad wrote: > Hi Adrien > > > -----Original Message----- > > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > > Sent: Monday, October 30, 2017 4:24 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; Ophir Munk > > Subject: Re: [PATCH v3 5/7] net/mlx4: separate Tx segment cases > > > > On Mon, Oct 30, 2017 at 10:07:27AM +0000, Matan Azrad wrote: > > > Since single segment packets shouldn't use additional memory to save > > > segments byte count we can prevent additional memory unnecessary > > usage > > > in this case; Prevent loop management. > > > > > > > Sorry for asking but I really don't understand the above, can you reformulate > > the problem addressed by this patch? > > > What's about next? > Optimize single segment case by processing it in different code which prevents checks and calculations relevant only to multi segment case. All right, just add "Tx" somewhere and it should be OK. -- Adrien Mazarguil 6WIND