From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 392E81B232 for ; Tue, 31 Oct 2017 15:11:53 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id t139so23542028wmt.1 for ; Tue, 31 Oct 2017 07:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uRoZr5kcAI9b2w/xuOVvDlMA7hzVFcgK0Yk4HuPdTZ8=; b=0fOIGAQz8CbBhJmQcqnPKNA/IOva9dZcTaf8H4TTiplAtkofgw24djhF1c3fvJUooS qLh6R4k5tnCYkri/3jteWSA2yCiyYei2+qoHA25Xwy7R+r5Z3tkP6ZQRDL+afQHhfozq QC1n+eYWdvrb9jV38ALd9paubcE+Bk9nJUkkjtR/lnYgD+N8vJkewCtLfIXRjc89Eawn Zs1Pp3NWoe025GaCWut+TNY+GALtGtbtJxRId3w55aAQKeHbjjThom23tZb+SXlxaYeg 8e6bv3bVXtJ5i3VUlxwRRuzjegjDed+0d0YMFtSSpp6AjZn2UgpeFnCwjRB2fbBF7YGr YtGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uRoZr5kcAI9b2w/xuOVvDlMA7hzVFcgK0Yk4HuPdTZ8=; b=gtfVKcYjCeiR2aIatMkGaXq+fj7N1kPnMfzmZv9Dr+1wboIeQLHwG2YUxfNLh+kpIN SM06U2XQTfH9XRgr6TupnJqhQIt7LWuDM14Z4pym8BbMeMAHdi9x710E5pXWAApY3vWb DjSo/BLMWrNfVhECA6tcP3TWVsg3hnhPECJLXW4218FXV8oVINyDD4LRF4wR/j9dpbVx v++MQ0tgOn6lHJ+hbIsOc+3FXD2XBWbw0J8QmNHK/Hs22nqXrieALTGxqvnjS3uOtbbR 8UFtt2l+WYNddXFhr0n+VJCczuBQ+TkGI7X3PH/Y+Z2En8NbhSzDAvk0+0yHHQtVYSZL w99w== X-Gm-Message-State: AMCzsaWd1D8RAOPIa6SCa+gVsu9OjP9xH773lRN3i3AKPpyf60R4mxES Z0L8pAKS14kcu7NBpkIrBPQxag== X-Google-Smtp-Source: ABhQp+QZywVikyYNMAKTTiLcC0Oz8OHdtyvCf6ebk3Ji975xVlH75UbUvwyKubhz9y/S0bNtnl2jdg== X-Received: by 10.80.201.131 with SMTP id w3mr3112244edh.56.1509459112771; Tue, 31 Oct 2017 07:11:52 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o64sm1345850edb.14.2017.10.31.07.11.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2017 07:11:51 -0700 (PDT) Date: Tue, 31 Oct 2017 15:11:38 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ferruh Yigit Cc: Anatoly Burakov , dev@dpdk.org, Jerin Jacob Message-ID: <20171031141138.GJ10890@bidouze.vm.6wind.com> References: <8492fe4cf1a8d6f15d389c9148e4942f1d060a40.1509381300.git.gaetan.rivet@6wind.com> <20171030223227.8852-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171030223227.8852-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4] bus/pci: fix vfio mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2017 14:11:53 -0000 Hi Ferruh, On Mon, Oct 30, 2017 at 10:32:27PM +0000, Ferruh Yigit wrote: > Revert back to using VFIO_PRESENT as a marker to enable compilation > of VFIO-related segments. > > VFIO_PRESENT is the combination of user configuration RTE_EAL_VFIO and > kernel version support check. > > eal_vfio.h VFIO_PRESENT related check ordered to be compatible with > rte_vfio.h one, no functional modification. > > Fixes: 279b581c897d ("vfio: expose functions") > > Signed-off-by: Jerin Jacob > Signed-off-by: Gaetan Rivet > Signed-off-by: Ferruh Yigit > --- > v4: > > * Alternative to v3, not superseding it, need to decide which one to > get. This one: > * fixes vfio for new kernels > * fixes build for old kernels for vfio enabled in config case > * print warning if vfio enabled in config but not supported by kernel > Thanks for the v4. Well, as I stated before, I am more of the opinion of letting the VFIO_PRESENT define only within eal_vfio.h. But in the end, as long as everything is working, I'm fine with it. Unless someone is explicitly interested in going with my version, let's keep yours. If needed I can always submit a new v4 that would actually work with old kernels. Sorry about the mess concerning VFIO. I found late in the work that I needed to touch it, and did not have the test-bed for it.