From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0079.outbound.protection.outlook.com [104.47.36.79]) by dpdk.org (Postfix) with ESMTP id C648A1B347 for ; Thu, 2 Nov 2017 05:12:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FyP5m6bcD/taS2EflByLmQfd/bBc0uCloTjDMpiqKbQ=; b=mln9hKXvPLAPh/E2bR10t88TYiSbs59v5RF+oQuCKWeKJDNmj/6gt4s/yj8aK1CxdvLqujEMFdObJqPXRb79NYzmVTg56Nm03rPLoPIhdeebvd9/NHgMAVaizs3tRe2G2XQRrFllBHIzrj2azg66skvBLc1eeYHVfDx/aMlL6zg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Thu, 2 Nov 2017 04:12:10 +0000 Date: Thu, 2 Nov 2017 09:41:53 +0530 From: Jerin Jacob To: "Eads, Gage" Cc: "dev@dpdk.org" , "Richardson, Bruce" , "Van Haaren, Harry" , Hemant Agrawal , Nipun Gupta , "Rao, Nikhil" , Pavan Nikhilesh , Thomas Monjalon Message-ID: <20171102041152.GA2107@jerin> References: <20171016103255.16322-1-jerin.jacob@caviumnetworks.com> <9184057F7FC11744A2107296B6B8EB1E1400BE33@FMSMSX108.amr.corp.intel.com> <20171030173803.GA9123@jerin> <9184057F7FC11744A2107296B6B8EB1E1400FA36@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E1400FA36@FMSMSX108.amr.corp.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0117.INDPRD01.PROD.OUTLOOK.COM (10.174.144.33) To BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64a2dfab-dc5e-4f47-415a-08d521a7e536 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603199); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:ONyyZ3W7cW/EBlVYfhu4af9YKb6HZ93tVGAd39r7xluzb1qMFD1F+e56C+Q3QfhS9wOeVf9IXBlupA2HqwO/2qo0DhyWsADOhbxYCE89EZ5+N2w4E2ZT5nGY91UFKJKnWADe/0RPjkXp3e2YuvedHAT6nDXwoHA20HSLBp14L9DprcHhztEMOxMd0NycLKcF+k2xefq4eDbNfzrSTxB1LBcJsgDyNcOmUgstidQVqMIG7B/u+qqCWPEX6EBbg2lT; 25:YZtWG3arvVGA41K81BYXO4nGYEf09TuMCpsUs9r0s2/AlmKuZHllTQZ7WbYe0PoFqtEOb7ZdU9ASHkSG/pxaYSIMAzAPCAoA+EK9nJ6ZxMi0+/v/aBItqY72ajeS5skkWecq8iYkwpt+68vlxcTUTQ6BSs11LyE6vTc2rJFO+Ry+5g41Ce2H03vVbeR00o77BXVd+leakaHn7D9PZGjw8oe0G5UkCHJMQ7VpCXSsKQd9sRjbW7rOh9+kyoCv5S7/QV/cV4KSUNaUjwFo5crQZt1Ub+Tfz4LL11CQs1dANwB4diNeHO5wRheT9myEN4vHDqUq36nhrxsi8Wcn/p4s8Q==; 31:lK1A3Ib8fnQNNi50JURAwmOOd7UDHOqtYg6613rAA2eCCG0fL7bpANTn80P32cHOVGGnvO6T47xk89eKqtkFLaEQYNB1/3ennf9MWRFje8qrsPp5ZGLmyb+CbeoBmvI2/Me7EGQY3G59chj8XYV4fQFg8XabIFathV4uHwDnQlaDLwfwhFhlCFfEcLfj9SSVA6K/1IhpaOpi34JDe59rpc7QO/tBd8e7m7Fte/ogjo8= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:n7xuRycDCpCBpXQZBq8jpRckL6cjsMR4el9y3REpxQFmildMH3Rh7uuhDVckXZ50cQsJOn9o3rap0JSqUAbqrMS6Ar23jw6eWuIQZlMNcwoSnaUb10gfccu9jS/LxAPfKb00NvIQIZJV8FXIEm6OOW7Lap0Fv73F8ebEZwcIkUz2GwWlX6rvfQVyJGOpmX4Ma3opNEWQsRJA0PhX4k2Z0JTEWWzMqxlmD/4s9W+v1PW4T6QI/fVHERF30JL7QHTdQWT9QrTlZczJAZ70mnpKOsG40K4tkdAxDuRgjFHKYHF4svyO3uSkeVgPOzXd3CP64tz9yMrIEDWik3Dguz0lU1Bjs1glSmMksuakI+NpyxbpBdUFWL/nV+/4bstyGPAHj97epkAE924UGXOgFnKoeJiTb5BXLXDilKbkdIv7f2QfM5SxIh6KcTPbh8QxVDRW5W+LgZBqelMmxofIh8NjgtttKEYCIZr3rEXIcOAM+F3rGfN26R9MmsBICAHDieHxMQZ3Omfo5ENpwLR0YE0dHGlLhbmHWHmnxnSGCZfzOUxVqJ/wGC8YsmXwgr+w0s5Sa6hbNl+58K3o0NrnZprKi9EGqy/fVvQiqCg4vS72GVE= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(100000703101)(100105400095)(3231020)(3002001)(6041248)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 4:scXucnZM6kBPo0ZNmMYbyrvYXuivrVevm5DoL7yM80qzFs6VKOYGC9FGo/Wpj4TBmhlCDZxRbhmLfBYbxMEw75YPIItP8MWVT1kJ91RgfzV119mk+vo3RlKw5eRMvFpftt0KopNFxoIS/GTD7gpW0TEDVhGUlDndVTsiSNfe+vKf6nDJ9p8XmvE7EkcS0q73u43ikKynRGHgm7qIRtA+xjRcdK8SrDK36cRv/mruZk8DHXHqbhuvwpzWjsywGUaRjLKTFUI8kDqAuGr6/EexXFbuKnPzHiczWoe6SRHaUjL+e5Fzk8yLw+qJsEFziB0kIgFBshi55NDq95Z6XkU8d7rrt0BC/0pIUhrCjq859II= X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(13464003)(199003)(189002)(106356001)(50466002)(16526018)(189998001)(3846002)(81156014)(72206003)(6116002)(8936002)(81166006)(53546010)(6496005)(23726003)(105586002)(42882006)(97736004)(6916009)(8656006)(5660300001)(2950100002)(478600001)(6666003)(2906002)(83506002)(53936002)(93886005)(316002)(33716001)(16586007)(54906003)(33656002)(9686003)(55016002)(68736007)(6246003)(4326008)(1076002)(305945005)(8676002)(66066001)(7736002)(76176999)(54356999)(50986999)(229853002)(25786009)(101416001)(5009440100003)(58126008)(47776003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:k8YvKWZB2q3NLO79JKCCOV1lCxJ9zPlJy7Bqtn5nD?= =?us-ascii?Q?4QaKBqSByNoLXTBljLwC7H7x1db2S6dXcelOk1NC13UBNKRt2zHT65bcL9Wl?= =?us-ascii?Q?/1PgVyAsPdv4xfgQ3reBtL9mO219VDueJtdOqnDrEMLtNDHUEvNLhKPSPolm?= =?us-ascii?Q?D1RwNtevMmjYj/vtOMF9wgKTjTYfPfLJS+2O/0n1SVQUgrKQ8OKinHC2UDYa?= =?us-ascii?Q?eVmxoDOk8LbZtN5Z7bH4+j7CXszV7FbcDoZddXJF4t85eLkl+YzgFhq75ZTG?= =?us-ascii?Q?HUwr2ynPSQ6ljQBAbiiLWouRIkRJ8OkTML25Px418XMt1tgchUIFW9Wkby4A?= =?us-ascii?Q?4uNH+E1OQRWWTqcefekk6CcGLHKb/pTLYJQJYl35/sbaa4ekRJSyYgrQb3Bh?= =?us-ascii?Q?Dnnyf/sfV3Ac7g+uJx8mY+JWMulhmrsi9DuvN+KX/NEo4bwBYzxFjSmRd7NO?= =?us-ascii?Q?IliLW+NOs0FsD12xc+5gVkXvP/IHBTWfvRgRPz+EJffMFv2o914gHSJI2Slj?= =?us-ascii?Q?bzl84P+NMwFJ7wgUWOpUiCx+9agDYnYAMIoieltxf4I+5OGYYGO7z3m6ILY2?= =?us-ascii?Q?l+ciZS3TH2SNngsfKb2DxuW026+/Lte0LZ6dBR7ATzOpVKSQiivTpjrYR8Jp?= =?us-ascii?Q?VTzzi7DInIGufTtQ9NkwzRdPjWnv9W0NU4Tpwr+nkF/2ElHynPJMXlZkhBac?= =?us-ascii?Q?v2Fw6sXz8MGs5vylEATkbxMr6v/q463poFK9ILwkvgV9rZv+ddzLOx2c8n4A?= =?us-ascii?Q?1nm7oUc9GOcK6aSVyWpf7OJuo12Z+U92RXHDdmrQZ6RSdJUgd2AQqreY2oQ8?= =?us-ascii?Q?YwsJoQ5QclODxYvlFuf8GMmZDZi/dNlESIhNoBS1Z6zLrvuNlljnRIadp06F?= =?us-ascii?Q?EPXtHWDe+oHxeBmV6onRFJWBY2BZPgunqVy+sx5e/vRpeoQ6SYIxPraLWaQV?= =?us-ascii?Q?CaWwvXWYm+lhafZHa1Z3PaaU3m7Zn9sjohwhIq4Rk+L2aecseVXoL9/F3MRy?= =?us-ascii?Q?AFcHHlJUwVj23Z1F8koF1iWFHBX20wwA1+ZK2lLjecLg1fzo2QCaUIFrZNFl?= =?us-ascii?Q?8Y9quVnpiDGN841mBcbiqgggUPgeqX79DVttsWvKho9NMQIh5q1pm592fL/Q?= =?us-ascii?Q?wCXPqmRPlZUJ3X0sf5Yg6Q8byHVfUeEHB9h9TKa0k/WYUL5gaKQA0gEgeJzh?= =?us-ascii?Q?meyLb3na80Ml5amwvZ7AX9dNjFnxoeLBWLgC8poSVwFZjzPLdySDn3tY+1nI?= =?us-ascii?Q?oaWfv5EReXaAbDpfCHVnhN80qj/mcfcotIeM4dUIDWxxQfRgTo9TERHcZViK?= =?us-ascii?Q?KSEEnBN5LqzfNGSpuuV8ZA=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:LX2ONySTDFJZ8hrDpix5wTudhJwAYM2Ripvea3zdqfSd38G0PHSRPZewEvRSZQw9o1fsdFzI+DL1UBujMozbUSfoFUQEgPYt614Uf9rlQi64sMbWSMsiXJN8yW2kOJQM8lYvFhk84F99+lAt+4fBTjyzKf23wCRh0Q7x8CP2ROc0QM5Un8VomI+jKenbW6MF0QXEpaT4O2CV6vj95RCwAx7hNW9V0GNmz9CjCIBMxDkzY1XNVCpNjio5FaXwYOxKG8vkBlZgZfrICD0p8aWIZa3dTGt91nEFq72UqRIJDSukXIglyJ5PdTbvAvuZfVz5+dJ4oARokDE362YaRysIM08As2eraQmilLWotsKa12w=; 5:sBuuBsL5sBEAxRpSs8LhwOqjs0hjppi/IftxsGs6nAfnr2JmQNcEyGQWtQZQ17BBsqF8Ry+5NqDYbY/IltuHsO2mhWU0mO9uY9AJi5GqaQRHgGQWrEsZ+SCPCJjZ6jUMK9niN5VKI3hauyXAap1tmknbpXH1oaPhemr0mybHV0w=; 24:KjoUBKazmUOnZlIs83m+ImTPXBTQN+iE6rIH8ScyNP9ZI7BDRabuL2W9nONOSZE0g1T2F4+H2V0X5MzBLMBZ9HrpZjuncIGxG8qXFlv4bO0=; 7:ilHRwRiRmDy68rFgb2c7kFSYnaFUr16AR1KuYX7YlUlgZ64BEooVfRcRSnNGtoY6NadHLgNzeFTaH2PERZSkPawCBJeiX0DyKKWpYC7v7xxQcVZp9tdPLnZUJfaEWTgvDYzHHgaFRrUJBOzrsJ8lphMRBH0QmUCNXcbN3PXVZC3C7sr3QevDs4HXgs2eXVADeiZ44aCsw3SX/OV8fQA2HjfnCTQcf0AKkIyXDtG3pLDD/8pwwQBHYJJ9iMng5kTG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 04:12:10.5648 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64a2dfab-dc5e-4f47-415a-08d521a7e536 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH] eventdev: remove experimental label X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 04:12:16 -0000 -----Original Message----- > Date: Wed, 1 Nov 2017 14:12:59 +0000 > From: "Eads, Gage" > To: Jerin Jacob > CC: "dev@dpdk.org" , "Richardson, Bruce" > , "Van Haaren, Harry" > , Hemant Agrawal , > Nipun Gupta , "Rao, Nikhil" , > Pavan Nikhilesh , Thomas Monjalon > > Subject: RE: [dpdk-dev] [PATCH] eventdev: remove experimental label > > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Monday, October 30, 2017 12:38 PM > > To: Eads, Gage > > Cc: dev@dpdk.org; Richardson, Bruce ; Van > > Haaren, Harry ; Hemant Agrawal > > ; Nipun Gupta ; Rao, > > Nikhil ; Pavan Nikhilesh > > ; Thomas Monjalon > > > > Subject: Re: [dpdk-dev] [PATCH] eventdev: remove experimental label > > > > -----Original Message----- > > > Date: Mon, 23 Oct 2017 18:27:52 +0000 > > > From: "Eads, Gage" > > > To: Jerin Jacob , "dev@dpdk.org" > > > > > > CC: "Richardson, Bruce" , "Van Haaren, Harry" > > > , Hemant Agrawal > > > , Nipun Gupta , "Rao, > > > Nikhil" , Pavan Nikhilesh > > > , Thomas Monjalon > > > > > > Subject: RE: [dpdk-dev] [PATCH] eventdev: remove experimental label > > > > > > Hi Jerin, > > > > Hi Gage, > > > > > > > > I have one concern with the API that may delay changing the label. > > > > > > The implicit release that in rte_event_dequeue_burst() is a problem when using > > asynchronous/look-aside hardware, like a cryptodev. For instance, let's say in > > pipeline stage N the worker takes the event's mbuf and places it in a per-worker > > crypto request queue. When the worker next calls rte_event_dequeue_burst(), > > that function will release the previous event which could cause the flow to > > migrate to another worker, and this could result in packet reordering. > > > > > > To prevent this, the worker can't call dequeue until the look-aside operation > > completes...in effect treating the asynchronous/look-aside hardware as > > synchronous. Another option is to feed stage N's queue to a single port to avoid > > the flow migration, but that port may become a bottleneck. > > > > > > We could remove the implicit release functionality or add a port configuration > > flag to disable it, so the default behavior is unchanged. Removing it will > > completely will likely require changes in existing code, but it simplifies the usage > > model (all dequeued events must be either forwarded or released) and the > > PMD's dequeue code. This functionality could be removed from the software > > eventdev fairly easily, but I haven't looked into the hardware PMDs. > > > > > > > > The HW implementations, I know, it does the implicit release. Otherwise it > > will result in deadlock because it cannot hold reordering metadata for > > the longtime(SRAM is limited etc) > > > > Coming back to cryptodev use case, if I understand it correctly, before > > application enqueues to crypto queue, the application will change the tag and > > submit to ATOMIC queue. So as long as crypto queue competes for the > > crypto work in order then the order will be maintained. > > > > In typical outbound IPSec use case, > > - Stage 1 will be processed in ORDERED where application does the SA > > lookup > > - Once SA found, application enqueue to ATOMIC stage with SA as flow_id. > > - When the event comes from the ATOMIC queue, it in ingress order and > > then it submits to the crypto queue > > - Crypto queue maintains the FIFO order. > > - On IPSec crypto work competition, packets will come in Stage 3. > > - So at Stage 3, packets are in ingress order for the given SA flow id. > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > Having said that, If SW implementation needs to do differently for performance > > reasons then we will end up in capability as HW implementation works in the > > implicit release. May we can sort out through capability or separate adapter for > > crypto case. But I think, those will be new additions to the API.So removing the > > experimental tags may be OK. > > But if you have strong opinion on keeping the experimental tag till we address > > the crypto use case then I am fine with that. > > > > Thoughts? > > Ok, agreed, no need to keep the tag for this concern. The capability idea is intriguing -- I'll chew on this and we can tackle it at a later point. OK. Please add Acked-by: > > Thanks, > Gage > > > > > Jerin > > > > > > > > > > Thanks, > > > Gage > > >