From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0055.outbound.protection.outlook.com [104.47.40.55]) by dpdk.org (Postfix) with ESMTP id 7832D1B3CF for ; Thu, 2 Nov 2017 11:34:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=r1Xmmv/KpTXkGJscay7CsUsZibD37t0mNYVwvLLXnhE=; b=Urll7DI6nz0eMUmdp32Qh5rB2ZDt3ZoXLJyCVSvA2QvNjgUPhzhdTGhnzXBMejTFKC+kylTOv08GR5//Lvv4MjtGXniN/cdjTIy1BNMokzihtWUazWVu4/UaDDxPdE7FxL5r8ZrqIPk88ZoKKSp4uzf39/P9s//AsuZg7Q1EZlU= Received: from jerin (111.93.218.67) by SN2PR07MB2525.namprd07.prod.outlook.com (10.167.14.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Thu, 2 Nov 2017 10:34:06 +0000 Date: Thu, 2 Nov 2017 16:03:45 +0530 From: Jerin Jacob To: Jianbo Liu Cc: Guduri Prathyusha , tomasz.kantecki@intel.com, guduriprathyusha@gmail.com, dev@dpdk.org, thomas@monjalon.net Message-ID: <20171102103342.GA20462@jerin> References: <20171030073126.1662-1-gprathyusha@caviumnetworks.com> <20171030073614.GA27106@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171030073614.GA27106@arm.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0100.INDPRD01.PROD.OUTLOOK.COM (10.174.208.16) To SN2PR07MB2525.namprd07.prod.outlook.com (10.167.14.153) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dc44b84-ea79-4342-da5c-08d521dd3ff5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603238); SRVR:SN2PR07MB2525; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2525; 3:WRhj1SRGFlWAd5vfvBgqy1/ZNl/czh3q2fjW0B8xlZZFUNTqj2I8NoHNph5PHYpP+G1/V6/vAdcNC7LiIuZsH25VAoulMyQ9L0I4EKx1guqsVi07nkjSdqV0QUtz9xWlHwa2zSkb19nACHDBcKV6n85v24YiNBSOWNQjG2OVUP/zyAwm3acGeNHkkaCj6sjzBykSJzE9a64RI/cfiapCu15Gr51zHUeppN6mc+yzmAC9In7kG7ZbBJjiRZaim2SE; 25:spqDVq4/yNoTP/FuNt6d7F7/L6k3qIyoZ/xC/aHMDLVRQqp6CumcqRPk391vABwaj7G57mImRjZmdRhHQDX3pDTZRd8+1sBaxRLJ2SGYMkbJL46xW0/qn1eip7WOlhGwTOqwyfTFPfvjsYtwx/QAqjLEPfacSyej40BrXZztlGbAPVkIG/z6/EhxGfB6aZ0UIrSBH/VlrdaZt6deAHLB5ylV4Jddmv8vd2jY7FX2rkqzK5EBuGtR9mENFUau4Fej6ZuNBmSJR5IYM/nnkucKkBeYA7FnQEph1iGsr4hORRb/Td8qcvRj80IY03pWbkceWZU+iMFyJo6WyT7WWPd4/w==; 31:2KifS6S/MpFQKwce4kOICS7vQNvZJ4zu+0anPkUMQ8U/T553ZcJnr67f188UijiwCtgYByLHcZMn+xrn638vMwVecS5jYvQAvOaL1JQbby9BIpve5nY2wOrLaW1m/km5ad6Ply7fPZuxtjxUZraVNB8G+N5faqEVG56duN8GiK3KFynQId/j3TQ6xHjKX9LVCxH3LazslOcq0mBjXoV973GaS94zAIYxOCrmKDKExo4= X-MS-TrafficTypeDiagnostic: SN2PR07MB2525: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2525; 20:vqeG9rzHi7yxyNmSybaHE6W1z0aJ9lXLpsUgEwpSU9L9zO5yhlgYOXMsz75+jlujKrVamDlMsS9OCX/zp4h+CUCV3TWJfYGrmDrcYUA2u73PFuxc+jVjncRQz4qvGESM/Xtf5qas2Mz2fkHEWQ+oipyYqAeqnpQrhtUZIEUaCAgytJuZ4QAGCcjcaETEpTK9JPJt7RmCThJJKkXvrPmS7V4lEtpipiOPUZyXTEweCyEpwEEjNo5LGYx4nwYbOu/FNgj30gCc2rZY5U12h4CubjTP3vqK58m92cDI+XH57fpE0faLaOmpz7fn+Ub4RdHbAK3h0huu4f4SANEjzkEOpaygdbkzy/0d4q8nXaxoY+HKxUIS943XQy7XwCokSSBgFwwOm13tHGnSh334mpyHptWOkOgYhojkzfQdLIW7wG79kE4ISwS1tccatYO1f1WpG08U6TtFYVIwtUnTaovRLzRTIpFcJaH8roNmzgSlzGT7uq0DaItx6WHHeprSwgVk2oQXOiaxoSbDGO95KBU0msgkDuJQWqvSXfapNrKM+BDSgL8wa71dIsNwVpTA2ORNg6iEclewwg3UvtPuj+wPZDn12qray/9tmgXRMqe7b7A= X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(100000703101)(100105400095)(10201501046)(3002001)(3231020)(6041248)(20161123560025)(20161123558100)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR07MB2525; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR07MB2525; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2525; 4:0MXBXfms/5Uqa6sxB5dKAqADPMLJ4UJujFJSaxBi4rzql0+IJnJ1bHb2UXLy0/2kpaP+JvcDl0EEtnybSK+k3KtQhYETatZysppCSGpE39TfWFUm6lsqScv76+dGMp09M0r0xIKsq77z2E4HyJsyJjop1uNFKBjO213nSu4/iEtSRB/izi+aoNVStqD4gZyagK5OYHb52qGkuRQPBO1XbVWLC8AyFC+Cl/pEe69PUUeinfSlYURks6zCU1spxsttzKzgVtyFsWbozI2iagM5GA0IlqBCXU8sFEJ5zUyIlt1go1Py6qRndbkZgy8OTVWTnWgdcyqsafpwlfx7LoN7aGXlCGnEaUItl952UDPdMw4= X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(13464003)(189002)(24454002)(377424004)(40434004)(3846002)(6916009)(42882006)(2950100002)(55016002)(6246003)(6496005)(6116002)(9686003)(68736007)(53936002)(8936002)(66066001)(23726003)(4326008)(305945005)(1076002)(189998001)(8676002)(83506002)(6666003)(5660300001)(5009440100003)(81156014)(81166006)(2906002)(39060400002)(16526018)(5890100001)(97736004)(54356999)(101416001)(229853002)(25786009)(50466002)(76176999)(50986999)(33656002)(58126008)(47776003)(16586007)(7736002)(72206003)(106356001)(316002)(105586002)(33716001)(478600001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2525; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2525; 23:kjMlF2POqFpmm+24eEj6ty8DNX1wMM+rgyzPJWwkP?= =?us-ascii?Q?zZpGeLvU7sk/01qpLVjMLHEQA9TbrFVROa8jugtIm00e0IIsCywzsACzc2fB?= =?us-ascii?Q?MVBy8Ib/BcSvkOiCJZ+/0HWPnIQZA/gtoFK3UyZyQmu9gqblqDepybmtN9rD?= =?us-ascii?Q?+q+uU+zA8dDzn+KbEqd0ISuABumNvkmXbO3gR8MVp4x8nxPK9a0p8kcINgAC?= =?us-ascii?Q?JjjOoGnVIjk5T4mOWPXj1h3NEgDlWnj0iEhrTnjfQ+CCgBXHXhNndtKvC0G/?= =?us-ascii?Q?nd/wtGf90EUmdDRMCVEAfL+fnkFcxx03TGU4uyJNJLbuft89UdsExu39DjWu?= =?us-ascii?Q?VnZBHIq/JNFLKjPS3HF2oKjh+pucR5OMXJruLmNO/+ANap3DwGfaaasbTH9E?= =?us-ascii?Q?9i8oLlA66oV/PZJykm83sS3Igvir069JhVQssAGEn6EvyzWDR71mKAAZ98sf?= =?us-ascii?Q?0ZF9J6D3UDVT+kXG89+Db5CWEFHejgyBV1JaXdKE4q1siXHBVUivx+e8DY0f?= =?us-ascii?Q?8niYVSos6eJv1dgLXij3dNkj/ziH7gG3oIH9yNbh7+BlAarBMYxA7h6jgaPS?= =?us-ascii?Q?GmXzcetjqiZITvja51l2gXgT4BtVmsSDM7YS2kxrSwP4lNFsuJ7rx4rTF+Bw?= =?us-ascii?Q?aFplwJX17qoFuza/TL00ORwSYh53iC6TlZwz19KZS3bCHuqRVTJK1buNP4Wx?= =?us-ascii?Q?cgAL8Ta6qn6ZgTjQddfOCawWuOcvavWENEhfegTCjrJvw4VRvaJzgTIlbDK1?= =?us-ascii?Q?LSnxHBhOlWnJ8XRkBe9Tv7Gj2oxVuJFT+1eZhd+6SMcSYDCX0+LfWBnmtgpx?= =?us-ascii?Q?fpciNHuX+cTsEOVpHQuO8b9dg11XE6nSHWrNlCzbFiiNBMdb+CQuxDVxudkz?= =?us-ascii?Q?dyz79Rb3a14HmNY0nkGBv+hCv/8xMs0MtU8ZylFMS6ApDEkfAsY+d19q6mgI?= =?us-ascii?Q?Sl1lRngcCIEChNgmgGxPmV6ngMT1eYx5yoCYA9EL4bOFo+w4X6pjAh5nDEwT?= =?us-ascii?Q?aFBnjdd9EBGBzlEdidO48RRxgW82VMZYoiVijE+XEhtI/9ytR02+1i4hnPBI?= =?us-ascii?Q?guHpdV+EEUA/2b5xhpJQmUjfVjVpx5jutb9eRRsPrtsHIC4wMd/7doktxJib?= =?us-ascii?Q?8OqQW1XjNWtZdagcp45ucM80U8thJRhAkmkbN8GGkI5+6mgLJWgecSyELElY?= =?us-ascii?Q?NbMygdNct/G/cOhu9qOeBJDbxrm4X6aMp12WKjsyaL3HUMrEc2z4S2gQl18M?= =?us-ascii?Q?UXhTDyu+5mpmQCL86u+rOka5Lgzj+8FVRbxDFn6Fh4Kh/yodHN7ELfDZzS87?= =?us-ascii?Q?xUvJki/BLUU4YYy8u6mgB+C3tCW+HrtDhmCioqm0yOya9pX3dHP78uNUEtTB?= =?us-ascii?Q?RWITg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2525; 6:lvLhmdYLHWGe5sG4/hkjzrh0idNEXDWkSK+mT80VVLNUAurJpLOMnUk0M3QEQNElVQIlUFPLB6OgQCle/T6wIZxLFDJBAzFOHjeP5D8BNjFohlNLwqzrgsxoa/cNyInVlpn6t7rZ626pMyPs/rmEXbizJwnUEKVNvBOwfTB+tSu2kLcETJzvOsSxHeV2ymdSc3JkL0IhCe7KsNsxoeLz2kIIWoRYnoImn58sCC82IcGXP2GRdGcj1cvGI3wxq62HNrJl+w0ES+BijfborCb5giilHyIlEZI5+TpNM9t5hm4oTtQmV8Y0/QRXljm8izQAioeG8hBgChfYI/pQIqYwc6AAf+2BGguRCE3p5zKxUkg=; 5:/uA/fHmmBHW7+1t/8L3q8SYGIGLcice8a7IBB8B2216skDjwVN/109GSIwN8sQ7W/B3PdDhHG84lDRHfBhPMAFQ8Fp7CPY5COccQ59LDKg+F9cDBCzRN1vr+XH+IXwQCS3tkuaG23FNjhzp9Tdsu0bfkm4D0xltymwRGB5bCaBA=; 24:7rkGEbz+Iz2/Txkr2yhBi7antWZuQaIGUCLm5DPcGfr9oOUQ5vCcEjEm5jJfLeWkUO6tAWCEHh/UPa0mVuiaiEHmH2K0Uv6tOLifr3Gb4T4=; 7:iM6EQQtMxDh0A/6g64rBgGSgl3wTMlludKTn0YYL52Csc39LaVci/KBDPyX/nlNZrKa3I/3ReKnIN72XtS6WCSZRAt18cqZhyRHckPtBm6a9eO29T1hmwXgPMvfJ3cW8nKfxSyAkjnAn9K9tjjR2c6N+SUaKCQamcgWPmIcHEzuoxgMA8XlbnNptL32gZKcqG66W6SsXmUfD5gJoJrkFIO5LVh91pOCNZPhlmNGmU8kj0eyT6kZNrFkBqhuGBlI3 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 10:34:06.5640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5dc44b84-ea79-4342-da5c-08d521dd3ff5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2525 Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 10:34:12 -0000 -----Original Message----- > Date: Mon, 30 Oct 2017 15:36:15 +0800 > From: Jianbo Liu > To: Guduri Prathyusha > CC: tomasz.kantecki@intel.com, guduriprathyusha@gmail.com, dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions > User-Agent: Mutt/1.5.21 (2010-09-15) > > The 10/30/2017 13:01, Guduri Prathyusha wrote: > > To group consecutive packets with same destination port in bursts of 4 > > neon intrinsic data types dp1 and dp2 are calculated such that if > > dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: and > > dp2 should contain: in the first iteration. dp1 should > > be and dp2 should be in the next iteration. > > > > Whereas the existing code incorrectly calculates dp1 as from > > second iteration. > > > > This patch fixes the incorrect ARM NEON instructions on dp1. > > > > Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation") > > > > Signed-off-by: Guduri Prathyusha > > Acked-by: Jianbo Liu Acked-by: Jerin Jacob Cc: Thomas Monjalon to add this patch in RC3 > > > --- > > > > v2: > > > > * fix as suggested by Jianbo Liu > > --- > > examples/l3fwd/l3fwd_neon.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h > > index 42d50d3c2..4bc161394 100644 > > --- a/examples/l3fwd/l3fwd_neon.h > > +++ b/examples/l3fwd/l3fwd_neon.h > > @@ -192,7 +192,7 @@ send_packets_multi(struct lcore_conf *qconf, struct rte_mbuf **pkts_burst, > > * dp1: > > * > > */ > > - dp1 = vextq_u16(dp1, dp1, FWDSTEP - 1); > > + dp1 = vextq_u16(dp2, dp1, FWDSTEP - 1); > > } > > > > /* > > -- > > 2.14.1 > > > > -- > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.