From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 104A91B5EC for ; Thu, 2 Nov 2017 14:52:30 +0100 (CET) Received: by mail-lf0-f65.google.com with SMTP id a16so6618510lfk.0 for ; Thu, 02 Nov 2017 06:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ZCnltcDvBqHtXcd6pgp5fS3DwLsOzSbJhkUm2gH2yaQ=; b=Q1zhRNmHiJXWbIlzpGmtvFKJpuY4C9J6SISATxhcAY1tL2zHJc2aXjemjE/2lAhyon fZxSB1eVYtpIsnRGV/IcFm6Wffls1t/2gBAZHkYx3TC+J7V84JqHa6EHJP9KwX4MYENE f9X/h6AIKJxkg10I0AqWTV/qzRbkmcHpRsWRTD+Zyb5HOICS1DSy8rB9MDV898UhZTvM 6CyBMmiqmUrY3FBV7INBNlGbyz+vzFQbXoFOxQzrJEQF6C6hehzLGOj8qpzz26q7UfbW TI5yTlG5H3wUpIFPNXU7YUZGcxShcVyYQw8Rm3bD2MAYv5+tMuHeTffGhNRG+GcrXav4 9S+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZCnltcDvBqHtXcd6pgp5fS3DwLsOzSbJhkUm2gH2yaQ=; b=Tm8dhiXQ97ZW2B4p6HmU+d3/V8zVQvbX1aXA2l9oer7xSa7ILuEM4MTRKnNOl6tbOh jMFk7I3fuchwSvulZR4cYETJukLDthHA4MSjoyVYvrFXTK70Ocg5XyWo9gkVGitho5OH 2RVjNcfczOxxU9JdOoPcW887deqFh4MZLIJH8yjxlypBlGNIMf7PXomukgrkGyfZZ1Bl jjU9uk1a+H9YxQDXfytuHpsMgjUJQWjGV3ReUHLtOQmsCqRGjDT8FOMzbjHX1osDARJi fLFmgUXGE7TBaT0Fuqh9o/YRd+4kE2fzLVj/ouUtudtb9Ktwu0kIsGT43m0xyrugkI6w N4Fg== X-Gm-Message-State: AJaThX4s7rjzjXuRwzAEuo4FhoSga345oaFgqFm/h36UyoWpmT1OjpqQ TDz6RNKknYm4Ek16nAl46kiAag== X-Google-Smtp-Source: ABhQp+SMq0OUoTCmRnm3neTimYKNjgRlGRrQ8uohon9mzP1NbbmX2jgqg578ax7fDi5z6ONleke0lA== X-Received: by 10.25.83.78 with SMTP id h75mr1333290lfb.134.1509630750321; Thu, 02 Nov 2017 06:52:30 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w64sm550959lff.32.2017.11.02.06.52.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Nov 2017 06:52:29 -0700 (PDT) Date: Thu, 2 Nov 2017 14:52:16 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ophir Munk Cc: dev@dpdk.org, Thomas Monjalon , Olga Shern , stable@dpdk.org Message-ID: <20171102135216.GK10890@bidouze.vm.6wind.com> References: <1509567158-15670-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1509567158-15670-1-git-send-email-ophirmu@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v1] net/failsafe: fix VLAN stripping configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 13:52:31 -0000 On Wed, Nov 01, 2017 at 08:12:38PM +0000, Ophir Munk wrote: > failsafe device has vlan stripping configured at startup however once > a sub device is found as non-capable of vlan-stripping failsafe > updates it configuration and removes vlan stripping from it. > This update occurs only once at startup. Following a later plugin > attempt and in case of vlan stripping mismatch between failsafe > configuration and device capability - failsafe cannot recover and the > device remains constantly in plug out state. > > The sequence of events leading to this situation is described as > follows: > 1. Start testpmd with failsafe where mlx4 is a sub device (not capable > of vlan stripping). Expected printout: > PMD: net_failsafe: Disabling VLAN stripping offload > 2. Execute: > testpmd> port stop all > testpmd> port config all max-pkt-len 2048 > testpmd> port start all > 3. Do a plug out (e.g. disable sriov) > 4. Do a plug in (e.g. enable sriov) > 5. Expected result: failsafe successfully configures and starts its sub > devices > Actual result: failsafe is continuously failing with these messages: > PMD: net_failsafe: VLAN stripping offload requested but not supported by > sub_device 0 > PMD: net_failsafe: device already configured, cannot fix live > configuration > PMD: net_failsafe: Unable to synchronize sub device state > > Root cause analysis: at startup failsafe removes vlan stripping from its > configuration. After executing "port config all max-pkt-len 2048" > testpmd marks failsafe in need for configuration update. > After executing "port start all" testpmd overrides failsafe > configuration with its own configuration which includes vlan stripping > Have you tried launching testpmd with the option "--disable-hw-vlan" as your mlx4 port does not support it? > During the plugin attempt failsafe refuses to update its configuration > by removing vlan stripping since it has already updated its > configuration at startup. > > The fix is to remove the limitation of one time configuration at > startup and allow it during plugin attempts. > > Cc: stable@dpdk.org > Fixes: bbc6a53dda44 ("net/failsafe: support Rx offload capabilities") > > Signed-off-by: Ophir Munk > --- > The commit message includes bug and fix descriptions > --- > drivers/net/failsafe/failsafe_ops.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c > index f460551..953ee65 100644 > --- a/drivers/net/failsafe/failsafe_ops.c > +++ b/drivers/net/failsafe/failsafe_ops.c > @@ -187,16 +187,6 @@ > continue; > DEBUG("Checking capabilities for sub_device %d", i); > while ((capa_flag = fs_port_offload_validate(dev, sdev))) { > - /* > - * Refuse to change configuration if multiple devices > - * are present and we already have configured at least > - * some of them. > - */ > - if (PRIV(dev)->state >= DEV_ACTIVE && > - PRIV(dev)->subs_tail > 1) { > - ERROR("device already configured, cannot fix live configuration"); > - return -1; > - } > ret = fs_port_disable_offload(&dev->data->dev_conf, > capa_flag); > if (ret) { > -- > 1.8.3.1 > -- Gaëtan Rivet 6WIND