From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id DDC851B63D for ; Thu, 2 Nov 2017 18:07:37 +0100 (CET) Received: by mail-wr0-f175.google.com with SMTP id l8so190773wre.12 for ; Thu, 02 Nov 2017 10:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=842oe8sCZ+CAr5vJLIjZiNEbxpIJFizeGuPZsOpPXNA=; b=GDxHvTHZZdbV0Fy8pMBi/Z1jNLsvcUU30kG2btQtD0sIfpwX7hMlFktC/QNGGMxdmO /Lu3+r2yYn+Pl3OfzlTZ2JgrIL6nos3fuhzGqjWQnDx04ccU75Pczx1mFCyPoeIfMBbK ODq1WLmV7DwEbCH7/cVg7E41ZDqYL+bW9AfqUruta/qouHeEMXEoOUozS+csRSG2A8BX P4Rhtb8dxlP44+9azhVWZ7JwBCPfWHpLu8tZvZKorn22aJaA+uX1VTxDpZjXoLcD4wKV 26TjGbUCFOHa1ZgTNp9LSSTk9zHTxqXBfs02+rWsvYVcLcqTE9z84Bqmqs43qTRP9npl Azng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=842oe8sCZ+CAr5vJLIjZiNEbxpIJFizeGuPZsOpPXNA=; b=mLgR+hfQWsd0kPVRtD+JUyT91aTLOdiYtYHYvsdArabLqYZ2H4KwWwCWKw1/miBc6V xC1oD7DCFchP5F0KIiSlZvPmOCQ5VHXVvwLkMEGGrSw0iqH06nznbUmsy4+U2B7/H/i9 U/TImF/bpwLW452k3ZvMH23hFPA6OcjHuoxjIwu5IGudL8um37DDdJAeJQi8fKbmtHd/ jm0mfO0GOQfWt2Y+XUKgZsyVrq0MdSfSfufOY6XI2wUa9dHlOu6VxlENpvQrjrtn1Qbx k2pNUlobbfWKL55gOkmmRLGpTPLNz7aIMMOGfwG70nbsXgamt6Lms3y3AiB1ndmxUtTs 3xaA== X-Gm-Message-State: AMCzsaVxl5F9Ovx684W3YClizYkFYbsr84h1joHhpc4hgYxslzB6Ihhx NkRz4Xl6nSO08G8MhO8d/UCfOUZN X-Google-Smtp-Source: ABhQp+SI/RxwRcBSp4JnPyiFcuxpqVwAdQL/LFXOfxEwNsonhbVqzmQ/F2TGXYzF0RMHuFMCINyd8w== X-Received: by 10.223.162.199 with SMTP id t7mr3362279wra.163.1509642457594; Thu, 02 Nov 2017 10:07:37 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x13sm2221268wrg.7.2017.11.02.10.07.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Nov 2017 10:07:36 -0700 (PDT) Date: Thu, 2 Nov 2017 18:07:25 +0100 From: Adrien Mazarguil To: Matan Azrad , Ferruh Yigit Cc: dev@dpdk.org, Ophir Munk Message-ID: <20171102170725.GJ24849@6wind.com> References: <1509358049-18854-1-git-send-email-matan@mellanox.com> <1509640971-8637-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509640971-8637-1-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v5 0/8] net/mlx4: Tx path improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 17:07:38 -0000 On Thu, Nov 02, 2017 at 04:42:43PM +0000, Matan Azrad wrote: > v1: > This series is a follow-up of the new datapath implementation introduced in RC1. > It is dedicated to Tx and improves the performance. > > v2: > Change uint32_t be_lkey to rte_be32_t lkey > > v3: > Rebase to 17.11-rc2. > Remove "net/mlx4: save lkey in big-endian format" patch which degrade performance. > Merge separate segment cases patches "net/mlx4: improve performance of one Tx segment" and "net/mlx4: separate Tx for multi-segments". > "net/mlx4: inline more Tx functions" renamed to "net/mlx4: associate MR to MP in a short function". > Leave bytes counter as old version. > Add memory barrier improvement patch. > Remove empty segment support. > > v4: > Remove "net/mlx4: remove empty Tx segment support" patch. > Add "fix ring wraparound compiler hint" patch. > Add "fix HW memory optimizations careless" patch. > Remove unnecessary IO memory barrier in completion function. > Remove inline declaration of completion function. > Fix unnecessary empty lines. > Fix indetations. > Move max=0 check removal to patch "remove duplicate handling in Tx burst" and rename the patch. > Add performace improvement in patch "mitigate Tx path memory barriers" > > v5: > Fix compilation issue in debug mode for patch "net/mlx4: associate MR to MP in a short function". > Add missing includes in "net/mlx4: associate MR to MP in a short function". > Add cq_uar as volatile too in "net/mlx4: fix HW memory optimizations careless". > Fix indentation issues in "net/mlx4: separate Tx segment cases". OK for this version, although looks like you didn't include: "net/mlx4: fix missing include" in front of the series. mlx4_utils.h remains to be fixed, although I don't think a v6 is needed for such a minor commit. Ferruh, can you apply the above patch first for consistency? Thanks. -- Adrien Mazarguil 6WIND