From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples: remove dependency on PCI
Date: Fri, 3 Nov 2017 14:08:15 +0000 [thread overview]
Message-ID: <20171103140814.GA23028@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20171103134627.216117-1-bruce.richardson@intel.com>
On Fri, Nov 03, 2017 at 01:46:27PM +0000, Bruce Richardson wrote:
> All PCI functionality should be hidden from apps via the PCI bus driver,
> the EAL and individual device drivers. Therefore remove the inclusion of
> rte_pci.h from sample apps.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Note, this patch will also fix the build of many sample apps on the
next-build tree. Currently, building samples as part of a full DPDK
build will error out on many examples, as they are not set to depend
upon libpci. An alternative for next-build is to add pci as a
standard dependency for sample apps, but as a fix, it's quick, tidy and
sadly wrong! :-)
Therefore, please consider this patch for 17.11rc3.
Thanks,
/Bruce
next prev parent reply other threads:[~2017-11-03 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 13:46 Bruce Richardson
2017-11-03 14:08 ` Bruce Richardson [this message]
2017-11-07 20:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103140814.GA23028@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).