From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 126A61B6A3 for ; Fri, 3 Nov 2017 15:08:18 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2017 07:08:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,339,1505804400"; d="scan'208";a="171602380" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.32]) by fmsmga006.fm.intel.com with SMTP; 03 Nov 2017 07:08:16 -0700 Received: by (sSMTP sendmail emulation); Fri, 03 Nov 2017 14:08:15 +0000 Date: Fri, 3 Nov 2017 14:08:15 +0000 From: Bruce Richardson To: dev@dpdk.org Message-ID: <20171103140814.GA23028@bricha3-MOBL3.ger.corp.intel.com> References: <20171103134627.216117-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171103134627.216117-1-bruce.richardson@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH] examples: remove dependency on PCI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 14:08:19 -0000 On Fri, Nov 03, 2017 at 01:46:27PM +0000, Bruce Richardson wrote: > All PCI functionality should be hidden from apps via the PCI bus driver, > the EAL and individual device drivers. Therefore remove the inclusion of > rte_pci.h from sample apps. > > Signed-off-by: Bruce Richardson > --- Note, this patch will also fix the build of many sample apps on the next-build tree. Currently, building samples as part of a full DPDK build will error out on many examples, as they are not set to depend upon libpci. An alternative for next-build is to add pci as a standard dependency for sample apps, but as a fix, it's quick, tidy and sadly wrong! :-) Therefore, please consider this patch for 17.11rc3. Thanks, /Bruce