From: Jianbo Liu <Jianbo.Liu@arm.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Guduri Prathyusha <gprathyusha@caviumnetworks.com>,
tomasz.kantecki@intel.com, guduriprathyusha@gmail.com,
konstantin.ananyev@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix aliasing in port grouping
Date: Mon, 6 Nov 2017 16:18:06 +0800 [thread overview]
Message-ID: <20171106081805.GA15773@arm.com> (raw)
In-Reply-To: <20171106042945.GA4073@jerin>
The 11/06/2017 09:59, Jerin Jacob wrote:
> -----Original Message-----
> > Date: Fri, 3 Nov 2017 16:13:51 +0530
> > From: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
> > To: tomasz.kantecki@intel.com
> > CC: Jianbo.Liu@arm.com, guduriprathyusha@gmail.com,
> > konstantin.ananyev@intel.com, dev@dpdk.org, Guduri Prathyusha
> > <gprathyusha@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v2] examples/l3fwd: fix aliasing in port grouping
> > X-Mailer: git-send-email 2.14.1
> >
> > With -f-strict-aliasing enabled by default from -O2, gcc > 5.x gives
> > undefined behavior in port_groupx4 in ARM. 'pn' and 'pnum' are
> > two different pointers pointing to same chunk of memory and
> > with -f-strict-aliasing the pointers are assumed to be pointing to
> > different memory and compiler reorders instructions that depend on
> > pnum and pn. This breaks port grouping algorithm.
> >
> > This patch eliminates the above problem by introducing a compiler
> > barrier between the instructions that depend on pnum, pn and lp.
> >
> > Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation")
> >
> > Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
Acked-by: Jianbo Liu <jianbo.liu@arm.com>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2017-11-06 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 10:43 Guduri Prathyusha
2017-11-06 4:29 ` Jerin Jacob
2017-11-06 8:18 ` Jianbo Liu [this message]
2017-11-07 8:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106081805.GA15773@arm.com \
--to=jianbo.liu@arm.com \
--cc=dev@dpdk.org \
--cc=gprathyusha@caviumnetworks.com \
--cc=guduriprathyusha@gmail.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.ananyev@intel.com \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).