From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 18AB61B2C9
 for <dev@dpdk.org>; Mon,  6 Nov 2017 16:52:56 +0100 (CET)
Received: from lfbn-1-6068-189.w90-110.abo.wanadoo.fr ([90.110.3.189]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1eBjnb-0002Aq-1x; Mon, 06 Nov 2017 16:58:56 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Mon, 06 Nov 2017 16:52:47 +0100
Date: Mon, 6 Nov 2017 16:52:46 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>,
 sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org
Message-ID: <20171106155245.fvc7toh62gxpxros@platinum>
References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com>
 <20171106014141.13266-1-thomas@monjalon.net>
 <20171106014141.13266-12-thomas@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171106014141.13266-12-thomas@monjalon.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v4 11/15] mbuf: rename physical address to
	IOVA
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Nov 2017 15:52:57 -0000

On Mon, Nov 06, 2017 at 02:41:37AM +0100, Thomas Monjalon wrote:
> From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> 
> Rename buf_physaddr to buf_iova.
> Keep the deprecated name in an anonymous union to avoid breaking
> the API.
> 
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Just be aware that I still see some references to ->buf_physaddr.

$ git grep buf_physaddr
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    op->sym->aead.digest.phys_addr = mbuf->buf_physaddr;
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    mbuf->buf_physaddr = (uint64_t)op;
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    op = (struct rte_crypto_op *)mbuf->buf_physaddr;
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    mbuf->buf_physaddr = op->sym->aead.digest.phys_addr;
drivers/crypto/dpaa_sec/dpaa_sec.c:     src_start_addr = sym->m_src->buf_physaddr + sym->m_src->data_off;
drivers/crypto/dpaa_sec/dpaa_sec.c:             dst_start_addr = sym->m_dst->buf_physaddr + sym->m_dst->data_off;
lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:  uint64_t buf_physaddr;
lib/librte_eal/linuxapp/kni/kni_net.c:                  (unsigned long)m->buf_physaddr);
lib/librte_eal/linuxapp/kni/kni_net.c:  return phys_to_virt(m->buf_physaddr + m->data_off);
lib/librte_eal/linuxapp/kni/kni_net.c:                   (unsigned long)m->buf_physaddr));
lib/librte_mbuf/rte_mbuf.h:             rte_iova_t buf_physaddr; /**< deprecated */

Apart from that,
Acked-by: Olivier Matz <olivier.matz@6wind.com>