From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01hn0232.outbound.protection.outlook.com [104.47.32.232]) by dpdk.org (Postfix) with ESMTP id D7BAD1B395 for ; Wed, 8 Nov 2017 08:17:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HU+D9dFh1eZudDASta+25/j4eADP6bgBtBPdzJYtI48=; b=dyalfu/ic6G+a0v8sx9fJRCoDwDFzt49DQFpFrcvEGKIJc0P/0plEGd3ErZrQ5tk4Vbm1+wadQnw399xSzUO/TVIY/KjkeAnIRk7d+ihL1xkeLC3km+3cC642t1XZc6otTan89VXmCEQpysAsa2eebVCjZyV7MGULurOAl0mfB0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.244.197) by BN3PR07MB2514.namprd07.prod.outlook.com (10.167.4.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Wed, 8 Nov 2017 07:17:44 +0000 Date: Wed, 8 Nov 2017 12:47:27 +0530 From: Jerin Jacob To: Jia He Cc: dev@dpdk.org, olivier.matz@6wind.com, konstantin.ananyev@intel.com, bruce.richardson@intel.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, jia.he@hxt-semitech.com Message-ID: <20171108071726.GA21113@jerin> References: <1510121832-16439-1-git-send-email-hejianet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510121832-16439-1-git-send-email-hejianet@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [106.200.244.197] X-ClientProxiedBy: MA1PR0101CA0003.INDPRD01.PROD.OUTLOOK.COM (52.134.136.141) To BN3PR07MB2514.namprd07.prod.outlook.com (10.167.4.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8508d89-099b-4a50-3014-08d52678d030 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603249); SRVR:BN3PR07MB2514; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2514; 3:C/jATcy/yYNVHxLWpLUzy2e19JNU7FNKeXIs4RofAy0DVkSkW5A+eqYl8C0rcwgWS3DjF+7PCzTARKfLgvYsyLBa9yEWYa9QmVbZJ/KPGCZ+OKGvdatZ2zm9pTpgTMrhG0CdjuElOXmsP6RT27qIJd+A5sa5H7Q6Og5FVxVp8LtXJVSUnnc85pp0+PFYs65Sz2vMRR2TLBDHSIuWut3tUakZ/65V39iIEntgV8yGQoAuNlwg+Rk67FuvlZrntYYL; 25:K75krJZbpjJBZ+9XOnGC9RaRlyBLBykdvsHmwlQS/LPwiXu4TO9qt6/AkUyocnwVJ2PwRSuc/8rFm3pdfv3+VHMq2w/BWO2zHzKw46h57xxolkUrCc3LkNf4l1Im9WKAfgcwJdC3HNYPhw+2j/PecECRXsgIrXHWyA/IJ/gsZsuBr8XqUo8Ma7Kg76tS1VsAXiBXCAu0Kt/QyGZpg92LYDrRoP7Hqvcy1kUhMIgjBmgANqZm16XtfltXy27zJicf1b77q72wvDuqFfCLg2ptM/YxQshkpkchKOHpLF+l82aOZeLC2ZcDZbSuy3rt306LeSzWXKpNbFXmPvsV8C1YQA==; 31:Q1b0Je1v13lQ5Y2tmTJtLHcluGnJa0L29XI+f2+3jsAlEnAcZ4jsbTryZfHWRmUL8WukqgXTevLfqC4J0SrPywUxkuBh6l1paFmbQ2Zvp09Z+HUjHhD9nR4HPTC2QdRHTcagsuTyq1WYvj5njTvIriuUR4E/HbeKKE3pDiEX92JpXFYtCKnPSfe/8IpUPHAbHIkZ/it+sXiHKF1eA6VGM/Mwrld7y6norYjPlA4JUVI= X-MS-TrafficTypeDiagnostic: BN3PR07MB2514: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2514; 20:+bFlFlFwx4neWfwodoN2/DYaDjgzoIeWQ6b/BS/2wnbRCgtNVhOL4aLlJrxR9mkd5R7aPkh7sDi4cB067RRl/Ti4pgDjke84OX6qenkolmMBmpGSCCR+5VHCaXD3i7DxISEPQS7bbnqx5yNuHftcKx1lxeDQ/Iy9hg2MAtRevn97SHjKlYVSq/9Y1gZamZDwSJqyHaeaWm75ZJXk7kN/7QL8Mo6nVfQn23P6eLwOXS3uIkNVztKVB+RkBqMs3q2JDv9pf6BeJPhGp19aQPKo+KwXmXCzs6BvFF/ppKY3dU1M18EoByPDFC5aiAae2mbHz0Gjl7HhacAB8B3QsBoZfqsTcbVPlsD4CGnEnCBBHtL/kRqc/5lDZbIRdvxsVxy84mF5Sdvi5LzJRDlOG9KYKcOZrZfRTD+lDmtQswe+v8nB4Jz2MKS6PV3Qc6BEIh26cey7lxKERcOgkXPYFhmKBweb3/w5tc8ybDd4gU27ocLkgpLrPxfmJvCI/jmSXDqxyOOwyITDPM4Fq0RFBbvaqpBG7oRTQQXCqey8+6i+rVyFHQ/GxJzSRZBpNst8HeBug3k2ftwVGX4jPK9mdxoc+I4foiOdoCZTBwGU/2rSloc= X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(3231021)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR07MB2514; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR07MB2514; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2514; 4:pz1Cz646FawdvDB3ZFNOUugCFWpgkRRH1P5Dr+SCCnk8laDTv65moh7UBT9hGoakD6KhBtxd5052oldsJaQ3LYYe5cGVvORnhnhlyPPrFx2zG6NsMjqbnWbWbvPJ1YS44xI/dnvzMCyy9EXQ2Z0RkjkqtkTQrFlRo04vMHGHStRPKMuOJRt2s+S859OiigdYhyfQKcPC/cI7rMl/klumRJrDfRC7lh5T1zcgqIqkb2SeW8yr4fgue0NdCyp5bGPxvXIOpn7e7rl3FjaNk8Fi+Qv+exV5nsQkxLdwzARg5ApqvjvhsIn0w8IIazdKWDK5W10XYWmQ8CcKDj4RQGiD9k/HPagVM/sxCl2Z7uToYytWgx6QO6NDR1A16+1H1L5R X-Forefront-PRVS: 0485417665 X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(13464003)(189002)(4326008)(53376002)(53936002)(478600001)(6246003)(50986999)(76176999)(42882006)(2950100002)(7736002)(189998001)(6496005)(68736007)(23726003)(54356999)(6306002)(50466002)(33716001)(5009440100003)(97736004)(3846002)(9686003)(966005)(83506002)(72206003)(316002)(55016002)(1076002)(39060400002)(5660300001)(81156014)(16526018)(8936002)(81166006)(229853002)(47776003)(66066001)(58126008)(8676002)(2906002)(6666003)(25786009)(6116002)(33656002)(8656006)(106356001)(6916009)(105586002)(101416001)(1411001)(305945005)(16586007)(533714002)(18370500001)(125773002); DIR:OUT; SFP:1501; SCL:5; SRVR:BN3PR07MB2514; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2514; 23:lHpR/iT2ogQg48HM/TY6xVb8W0FuHFlj+KEpWxWJF?= =?us-ascii?Q?xKeiQ5wfdIN4g3Fw6/uS7aFJRvlEagVltxMndoXqAEAuRXDGNgpn4lBmRSnw?= =?us-ascii?Q?vQXJ4gcXNGBX7j6hmZyOds8UjhKNAFXnDIg19RlekQHFIF1YsW+cN4J0NGy8?= =?us-ascii?Q?VfiKnC/IQeOVkugempiPTcUQ6VgMIuvF8GwPiyn8ItwPzkPfBZbAyTAZ0Oas?= =?us-ascii?Q?JGqJxS5r3gGcA+G/4LxogpXljRf4voo0Imhl4UEhe8eaZo9DYg9GuLl1GMM1?= =?us-ascii?Q?94T4dxQSYypdDVBv6S16nko4UvMLsxws/d09OT90Gg/fr5eV8XNTHyMHJsER?= =?us-ascii?Q?ReGu4J15JhDNb4Fat0rbx6jZ2fJveo1FkeYkgm0ev5FjkPMS97MRAxByL3mg?= =?us-ascii?Q?Te029xK+NUFx9fVFD0M3XRMB40mtXYVOUDhzEyJAgLL1ifb9H4LeKKFKcI39?= =?us-ascii?Q?5Gcfo0kaLsEqTYByLtWq1T2jMIBTr8WT0AbKtz52d2q4MSstDv+TBIOKSmvm?= =?us-ascii?Q?Ec7wxAOx5mobZEJtzgIiNfJIjnkgHVBSBKdCZ1F0TdOSuVomD2R5KLbTHX/e?= =?us-ascii?Q?l/JybQv94VRCxoK5NsX4QiUV3R0rgSPT54WGjDroBkoAD7Z8MojxmHRVAjAU?= =?us-ascii?Q?6jGsBZy1ze4oxxcOV9RWU8g6OGzRELud/ef2wdd1bGDpey9cECZg4h58Az1c?= =?us-ascii?Q?BKHJQVCIq9wmTOt3W3V98SgAnVZ3bj9OqFC/j/ttVc61HSsN6GO8Fyew9MbO?= =?us-ascii?Q?uROP/8n1DLkM5K5PEw2h1y4hwIy4Ao+I6ZJNEaWz/UZ6IAnnYttIXp+vXIEu?= =?us-ascii?Q?iUkcPZocUMKCQpYDb4vtP3avlAsPNv6cM7Vyeen69hcRZLLrqR8eyPHsWOhM?= =?us-ascii?Q?Omd/EtGB8x50RGk2k4ooHewP53X+L19CZLz8ey3LSx2rH9wkqI3xXlzCbZRY?= =?us-ascii?Q?1TFm0K6QhLUwJgRySE8NyIZXJRITRAQidJPYX6DLGXDCADfwpkruIZBrVMwL?= =?us-ascii?Q?ymLWT8E/WvGrTo81+eCz/fNwdvaY9Sq/5JzE+m7kLufM0bdSEZ3f4O//2mE2?= =?us-ascii?Q?E37cXzQIUyiqlgp+QBjx9AOoKT6f2xQHWMYlvsZKYGUI7myk/C3h8sxbaugM?= =?us-ascii?Q?aRR0JBUBU2RTvdN0lR4UOrGpc398eNhNcJqd++h59kH+MJAMYz/WlrZAzJfX?= =?us-ascii?Q?UZVXY7r5e75NoM92pDeHqwu8mMafyCk0bCwHiZK6EUSw3ivCTKgy5KElt/wb?= =?us-ascii?Q?Nc1KLecZEgPBpPtcEnuatCWpdxS3RMoplVmHORiK7+HEMvECm07uzjwsoRMT?= =?us-ascii?Q?z+SgEwiFbkiZmCWZSz6LyIIqwawvM6pdZ4xHj/7eIKa+HwtsBci2Rn6/yMI7?= =?us-ascii?Q?50YtLXVVcTgH3xFCd4HIVlHZVG14qs6hW+NjnnzqtxI5SAySd598fJDouBYn?= =?us-ascii?Q?4WWgoeqzVH3Oa3666zzdvCk3DpbDtU=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2514; 6:OpqLmRg53niLCUCcuC9U0z9j7GBWr3q9Z9Piweh1c3NVazkp9ynf5j0oba+1p+mmOBwlCapSpYvl8mZwDZQek+BkEmOYQux7uHdYmpnr7iiAdRS8oNn7hzDDugI+rRBJxhNAJxfyRipGhrIzwrvwgODaZlTQECccNeeIsnA3ngSA30bSIvTvKLC7ZqbO1z/Le3ImHAvhVEUMtiCXP0zbhKQpWrtVTHnUpoBshvBNaHTAadn0kehNnS1Q5TA9uNxU7JETnd+CtJauUPXHSg8ftWtTiiSJ9F4eyAa72epvtC4WdUVMVrdoaVVEnOswvBl8pnJJ16vjOMrULazJouiNPvOE74S22vsWcW80CNavfHg=; 5:rQpL3P0Ws2+jWPXx16xSv2tjg/daI54/mJDUEocto+CIzmn6rBJiIxmvnOTlBtD1zhTYG9WHysC91eS047QtyoDhoflvPiPvN9vqYwaYRCK3s7fvTZNY8V4gpWrSpPISXEkP0TBsZP8nP5SBCeiNfgr63Ec8ov2S6zkJ97FGwTk=; 24:aWjk2UY1OzNp3PjcDx0/GDH/ZkzQJWd5q25Tm6kKTLdupW2Prjg5SnLe2wsrzc1lg7omSGYvSkS+Ro3pBZsswA==; 7:D93Kx9O4lBKvlwSs6V2BCeYvbocAY8ynfj/I/bBDxwWHG4zMDqqVlISPIYGEGdUS9iqI3I+5LNhdqSMNNIWc5h/sRZrtKRmNruECRrwS6SeFKRA78v/F5AJ80YPsG7AzVwSmjwswws6e3tTAuZRjrgV/FxuZZgMggRSuknRFL26ZKLFD5Aw+vBYSHRoAnVLKLPtlOgwpsur86Yv74/+LfAQlgvLoH1GqRaHabVqX9hG4yqyYBWvpUyz47nKHvGsJ SpamDiagnosticOutput: 1:22 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2017 07:17:44.3230 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8508d89-099b-4a50-3014-08d52678d030 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2514 Subject: Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 07:17:50 -0000 -----Original Message----- > Date: Wed, 8 Nov 2017 06:17:10 +0000 > From: Jia He > To: jerin.jacob@caviumnetworks.com, dev@dpdk.org, olivier.matz@6wind.com > Cc: konstantin.ananyev@intel.com, bruce.richardson@intel.com, > jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia He , > jia.he@hxt-semitech.com > Subject: [PATCH 1/3] eal/arm64: remove the braces {} for dmb(),dsb() > X-Mailer: git-send-email 2.7.4 > > for the code as follows: > if (condition) > rte_smp_rmb(); > else > rte_smp_wmb(); > Without this patch, compiler will report this error: > error: 'else' without a previous 'if' > > Signed-off-by: Jia He > Signed-off-by: jia.he@hxt-semitech.com # If both are same person then IMO, one sign-off is enough. # Make sure the patches are ./devtools/checkpatches.sh and ./devtools/check-git-log.sh clean # Add Fixes: tag. Example: http://dpdk.org/ml/archives/dev/2017-November/081510.html