DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()
@ 2017-11-08  6:17 Jia He
  2017-11-08  6:17 ` [dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue Jia He
                   ` (3 more replies)
  0 siblings, 4 replies; 18+ messages in thread
From: Jia He @ 2017-11-08  6:17 UTC (permalink / raw)
  To: jerin.jacob, dev, olivier.matz
  Cc: konstantin.ananyev, bruce.richardson, jianbo.liu, hemant.agrawal,
	Jia He, jia.he

for the code as follows:
if (condition)
	rte_smp_rmb();
else
	rte_smp_wmb();
Without this patch, compiler will report this error:
error: 'else' without a previous 'if'

Signed-off-by: Jia He <hejianet@gmail.com>
Signed-off-by: jia.he@hxt-semitech.com
---
 lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
index 0b70d62..38c3393 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
@@ -43,8 +43,8 @@ extern "C" {
 
 #include "generic/rte_atomic.h"
 
-#define dsb(opt)  { asm volatile("dsb " #opt : : : "memory"); }
-#define dmb(opt)  { asm volatile("dmb " #opt : : : "memory"); }
+#define dsb(opt) asm volatile("dsb " #opt : : : "memory");
+#define dmb(opt) asm volatile("dmb " #opt : : : "memory");
 
 #define rte_mb() dsb(sy)
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2017-11-10 10:06 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08  6:17 [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() Jia He
2017-11-08  6:17 ` [dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue Jia He
2017-11-08  7:27   ` Jerin Jacob
2017-11-08  9:49   ` Ananyev, Konstantin
2017-11-08  6:17 ` [dpdk-dev] [PATCH 3/3] config: support C11 memory model for arm64 Jia He
2017-11-08  7:17 ` [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() Jerin Jacob
2017-11-08 10:28 ` Bruce Richardson
2017-11-09  1:22   ` Jia He
2017-11-09  3:14     ` Jia He
2017-11-09  3:21       ` Jianbo Liu
2017-11-09  4:43         ` Jia He
2017-11-09  4:56           ` Jianbo Liu
2017-11-09  9:38             ` Ananyev, Konstantin
2017-11-09  9:58               ` Jianbo Liu
2017-11-09 10:08                 ` Ananyev, Konstantin
2017-11-10  2:06               ` Jia He
2017-11-10  3:09                 ` Jianbo Liu
2017-11-10 10:06                 ` Ananyev, Konstantin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).