From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id EC4551B622 for ; Thu, 9 Nov 2017 10:18:43 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id b189so15435363wmd.4 for ; Thu, 09 Nov 2017 01:18:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=g1lR1Fe2kmZznSJX5euTUa9kKjDF2LEM9uWzMvR0nS4=; b=mLhGRkyEfw0q/s1hm1UDIUT317oppZ9gneZxTeh525FMickUGwXKSijrOzO5wYqwV1 jNLZtL+UTr2ZqFRPKZb/sPbDoUqOo/g4Dq1oyLwgtCd1AsCJdx7UDGyiJnXJ58T0aKt4 T624ohw1bB11wi8BpVYFvsSsPXlKS81kqFzIqyPMMsCqxiJ3iE3LWPFHLxVdUcB64dGs PD6NsTxheHVPXsFOIEnBUeToSeIaoS2lGeTAL7M73DXvPj++yyg6SztXWLLlD3FZUNXL TwVH99MITWujq2RUy5/NmQTLfYl/OkKTzMvJ+UYmhXx78fNgJGfRxzW1gk5zbPZAOj9p G6Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g1lR1Fe2kmZznSJX5euTUa9kKjDF2LEM9uWzMvR0nS4=; b=fLhlkSRmZNsb3WFr+Zj3OjS+Lo+dBZeeUmUActKdVDcVpeypLVotquumNVE10D9f2E fPqEZv8+eZ0kGBpU5uRuqiL6ZBjyFQq754ZnX0X1M0EN6dwpZwL0LiUQn/Aa/QvLY7ZM vXN/fi6L1XeXdQHDAE2hjpEC31Tkw7FULGVUsO8WtJyw6DM4FbD41wSsD9UYXtDvm/VJ SwJa5E/HBkgyNnE8D6ee9kQSp32d6HJl6zY5s+EggZC07yO7NQTnfBz8sKIWFiC3f9py nGDZEGCEtGmW73vdPpcewvPvsnBlrevaCQO/Eo8TPbrtBMXZMQRWWFeZNIjg7lXcFTg1 DuFg== X-Gm-Message-State: AJaThX7ykfbsx1eOKh3eHh53fx8juBM9v/flP98GFD8LUsNxavej29Cm 5uXg6i+9HPaicWPYSlmUP+VTNzo+ X-Google-Smtp-Source: ABhQp+T7wCFBa38OShBB4MWMFixL+4GchbBmvI7uon1DhOkjKE9nxsiDJwbAVpas5GbuSE0MOoZJJw== X-Received: by 10.80.208.222 with SMTP id g30mr4382433edf.246.1510219123629; Thu, 09 Nov 2017 01:18:43 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 88sm4875911edq.49.2017.11.09.01.18.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Nov 2017 01:18:42 -0800 (PST) Date: Thu, 9 Nov 2017 10:18:31 +0100 From: Adrien Mazarguil To: Moti Haimovsky Cc: dev@dpdk.org Message-ID: <20171109091831.GY24849@6wind.com> References: <1510166831-153992-1-git-send-email-motih@mellanox.com> <1510217973-178845-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510217973-178845-1-git-send-email-motih@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: fix Rx packet type offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 09:18:44 -0000 On Thu, Nov 09, 2017 at 10:59:33AM +0200, Moti Haimovsky wrote: > This patch improves Rx packet type offload report in case the device is > a virtual function device. > In these devices we observed that the L2 tunnel flag is set also for > non-tunneled packets, this leads to a complete misinterpretation of the > packet type being received. > This issue occurs since the tunnel_mode is not set to 0x7 by the driver > for virtual devices and therefore the value in the L2 tunnel flag is > meaningless and should be ignored. > > Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads") > > Signed-off-by: Moti Haimovsky Acked-by: Adrien Mazarguil > --- > V3: > Modified patch headline to reflect that this is a bug fix. > > V2: > Modification according to inputs from Adrien Mazarguil > * Modified the commit message to explain the issue. > * Removed redundant l2 tunnel offload bit. > * Modified mlx4_dev_supported_ptypes_get to report the supported > packet types according to the device in hand. -- Adrien Mazarguil 6WIND