From: Stephen Hemminger <stephen@networkplumber.org>
To: Ilya Matveychikov <matvejchikov@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs/port types change
Date: Fri, 10 Nov 2017 08:26:02 +0900 [thread overview]
Message-ID: <20171110082602.643503bf@shemminger-XPS-13-9360> (raw)
In-Reply-To: <04EF52DF-6CE8-4EF4-96AA-711184F8379F@gmail.com>
On Thu, 9 Nov 2017 17:51:41 +0400
Ilya Matveychikov <matvejchikov@gmail.com> wrote:
> Update types of variables to correspond to nb_segs type change from
> uint8_t to uint16_t. Also, use 0xffff instead of 0xff to specify
> invalid port value.
>
> Fixes: 97cb466d ("mbuf: use 2 bytes for port and nb segments")
> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> ---
> lib/librte_mbuf/rte_mbuf.c | 6 +++---
> lib/librte_mbuf/rte_mbuf.h | 13 ++++++++-----
> lib/librte_pdump/rte_pdump.c | 2 +-
> 3 files changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index 26a62b8..f2213a4 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
> /* init some constant fields */
> m->pool = mp;
> m->nb_segs = 1;
> - m->port = 0xff;
> + m->port = 0xffff;
In current code this now uses MBUF_INVALID_PORT here
next prev parent reply other threads:[~2017-11-09 23:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 13:51 Ilya Matveychikov
2017-11-09 23:26 ` Stephen Hemminger [this message]
2017-11-10 13:56 ` [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs " Ilya V. Matveychikov
2017-11-13 10:10 ` Olivier MATZ
2017-11-13 10:18 ` Ilya Matveychikov
2017-11-13 10:21 ` Ilya Matveychikov
2017-11-13 10:33 ` Olivier MATZ
2017-11-14 5:09 ` Thomas Monjalon
2017-11-14 8:24 ` Olivier MATZ
2017-11-14 22:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110082602.643503bf@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=matvejchikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).