From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com
[209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 9679B1B392
for <dev@dpdk.org>; Fri, 10 Nov 2017 00:26:49 +0100 (CET)
Received: by mail-pf0-f193.google.com with SMTP id b85so5376353pfj.13
for <dev@dpdk.org>; Thu, 09 Nov 2017 15:26:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=vzufMObDE3MkHGEkNZwHocwqE3pkyxxM6+ypH2tA4nY=;
b=J5yv4poQEWiibeabfbq6Drahfi7dwbJcS1XbwI0zb6GQxfDHFl0Rmofn840G7c2Vbx
iiXhMRS+0mCHnRKrAYtpLb03Uj8qUCQjsfn99yqtbsQYIzK8oZlzP3lLGdhnoOxRzI7B
ro5QSYz4Wdg5ChKYkKClDYr+QYmBj+9AZhHV91wEQGMYGk805yh5f4Y1HpJBu7sutFbD
oXX4VUIhNs/vp1LDHN5+HiKvPQxONXRH1cNzRPyKrhWspaHS/k4fvGe+Ti8CmKApS6N+
LK7IZXJtKLnJ2cSi9DwEP4nDNBskYd8QIMkEDVWbUyzfFM2JlRDEzGGm/YVnF/+Y2+W6
ueLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=vzufMObDE3MkHGEkNZwHocwqE3pkyxxM6+ypH2tA4nY=;
b=kPIMT69O+tv4Q6zUETcyoR2PHtt54vSoeN1XemKyOXgSdLeO2nWfH6DeA3IMARvGks
5xsC5kGBIX2TbAv1y21L7bOrQTpV+aZvw6GlyknLZZHu8G9KJrUq/2lJB6sQNrxfE29B
BjG3pCMJd2ysfHsrm/JAq/GbmtfewrRpWhw3BrO6pICVSqq1zaVnk1Nv0Rp6p2r99KuO
g3l1b8q2WwQTx8VBdHEfbzPYhRd5uq+Np/gacQ89w/Y/nPmj1dTVhRoJREOjNuF522MV
qNxdHAvyJcOZBRQ6PRqivY2cq1L1sCiZWKub1jSInOrwD4K3HCnoYRh+gzQOtH27yx7D
no1A==
X-Gm-Message-State: AJaThX4mNPXCW5gpM9aqIUwrkOvkY7ARS8VNHZ8qkyESzPOFU2Q2ih4v
NbOI+Fr2HCcJGWE2AiXoRDZ1Uw==
X-Google-Smtp-Source: ABhQp+TnGKnKStmcry1HgysUgHO2zXRK7S0jSBo4QmUp6yvoam3F1F60dXa6v4aYiXvOnNB1F8AcfQ==
X-Received: by 10.99.3.88 with SMTP id 85mr1527443pgd.111.1510270008765;
Thu, 09 Nov 2017 15:26:48 -0800 (PST)
Received: from shemminger-XPS-13-9360 ([61.40.109.130])
by smtp.gmail.com with ESMTPSA id q73sm16766192pfl.146.2017.11.09.15.26.46
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Thu, 09 Nov 2017 15:26:48 -0800 (PST)
Date: Fri, 10 Nov 2017 08:26:02 +0900
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ilya Matveychikov <matvejchikov@gmail.com>
Cc: dev@dpdk.org
Message-ID: <20171110082602.643503bf@shemminger-XPS-13-9360>
In-Reply-To: <04EF52DF-6CE8-4EF4-96AA-711184F8379F@gmail.com>
References: <04EF52DF-6CE8-4EF4-96AA-711184F8379F@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs/port types
change
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Nov 2017 23:26:49 -0000
On Thu, 9 Nov 2017 17:51:41 +0400
Ilya Matveychikov <matvejchikov@gmail.com> wrote:
> Update types of variables to correspond to nb_segs type change from
> uint8_t to uint16_t. Also, use 0xffff instead of 0xff to specify
> invalid port value.
>
> Fixes: 97cb466d ("mbuf: use 2 bytes for port and nb segments")
> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> ---
> lib/librte_mbuf/rte_mbuf.c | 6 +++---
> lib/librte_mbuf/rte_mbuf.h | 13 ++++++++-----
> lib/librte_pdump/rte_pdump.c | 2 +-
> 3 files changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index 26a62b8..f2213a4 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
> /* init some constant fields */
> m->pool = mp;
> m->nb_segs = 1;
> - m->port = 0xff;
> + m->port = 0xffff;
In current code this now uses MBUF_INVALID_PORT here