From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 266871B6C8 for ; Fri, 10 Nov 2017 11:18:07 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Nov 2017 02:18:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,373,1505804400"; d="scan'208";a="148254572" Received: from silpixa00381635.ir.intel.com (HELO silpixa00381635.ger.corp.intel.com) ([10.237.222.149]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2017 02:18:05 -0800 From: Jasvinder Singh To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, yulong.pei@intel.com, ferruh.yigit@intel.com Date: Fri, 10 Nov 2017 10:30:49 +0000 Message-Id: <20171110103049.82906-1-jasvinder.singh@intel.com> X-Mailer: git-send-email 2.9.3 Subject: [dpdk-dev] [PATCH] app/testpmd: remove port status check from TM node add cli X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 10:18:08 -0000 Currently, testpmd CLI doesn't permit to add leaf and non-leaf node when port is started. It doesn't work in case of i40e device as DCB configuration is deleted when port is stopped. Therefore, removes the port status check before invoking leaf and nonleaf node API in the cli. If needed, device can add port status check at the driver layer. Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_tm.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index 4acef98..803fae4 100644 --- a/app/test-pmd/cmdline_tm.c +++ b/app/test-pmd/cmdline_tm.c @@ -1599,12 +1599,6 @@ static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result, if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - /* Port status */ - if (port_is_started(port_id)) { - printf(" Port %u not stopped (error)\n", port_id); - return; - } - memset(&np, 0, sizeof(struct rte_tm_node_params)); /* Node parameters */ @@ -1759,12 +1753,6 @@ static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result, if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - /* Port status */ - if (port_is_started(port_id)) { - printf(" Port %u not stopped (error)\n", port_id); - return; - } - memset(&np, 0, sizeof(struct rte_tm_node_params)); /* Node parameters */ -- 2.9.3