From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id C92F81B647 for ; Fri, 10 Nov 2017 05:06:42 +0100 (CET) Received: by mail-pf0-f195.google.com with SMTP id z80so5817931pff.4 for ; Thu, 09 Nov 2017 20:06:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rIVy20i+ixqoLrUpsWtp8sS4G3b7g46aZkpQW46/CN4=; b=jYk1Q4pfcWJ6CdFht+7dqPVleuV0/mTwFHWhKDm8wBCsTaJukiEU6y+qBWNPHSD0Kw 297gN54uyj+wK8vrsNuqw5T36peEX5cCdUNP87ayyRfCoq8kBidg5NUvbdfto9vDBRMX Zts3CXSr5A8YjB+M3JsQQYA2lqzWwSfxnQh4mueopnkQTEFkT2qUGJZ6QD6k4C5ay13v iK0ZgxPFBtS4VK+X29igywooMYNhvmHMvWeSdjc7DdmR9nkkBhgkHPCiqg92vOiDfNb7 pBjjKZeFJAzueLjvcBaiXVr+HcWWi7rvereZyF/EPaaRSUq3zdV32R7DcScp1LUlw4Mu hjuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rIVy20i+ixqoLrUpsWtp8sS4G3b7g46aZkpQW46/CN4=; b=WtUZ01/r3ZyEExTipeD6T9zsXKidsn5akLG7y1sJH9xFwPfTk+nx+yZ+2KcRI+mCpg 7E/8RlO1hGBzus2ygIwX4fp5OunoHDjZV+RzDWZ5g1hKwMK4catB8YvxFSWns7SJDlBw JhQW7Hb7QAlTud+HEEoNxUrHcAQzT5BkIWnuCxliccQdSKz7mY6IynnWImKtaLzc7h/J SaMDWpqVRbgidjWku2u+IwQyfkSYbI9A0g1W4FoIGs0in14yboh7y9VvkaHPEusDlSTk 1m3xCVWRfQXMkEBUlMrYRliRpO46MBtOE0NzjoyfX50b66rNld/nBcvtEdjMGDQhzPXR bNqA== X-Gm-Message-State: AJaThX5TqMl/Gk7hgmGOiPtwrfs0iTWlecRKCbR5oMLpKxMAv3tnRGD9 ksWKQEW7qTClZ7BAU5C9o3rqeQFMKO4= X-Google-Smtp-Source: ABhQp+QwsQ9bcvEItAev6TG/oNntdCCR9PXWmtJC/Fg3l1A+TH8lyd4werTVUaaV9hvD1G/lWLKrmA== X-Received: by 10.84.174.1 with SMTP id q1mr2804819plb.220.1510286801783; Thu, 09 Nov 2017 20:06:41 -0800 (PST) Received: from shemminger-XPS-13-9360 ([121.135.231.251]) by smtp.gmail.com with ESMTPSA id 81sm16109595pfh.145.2017.11.09.20.06.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Nov 2017 20:06:41 -0800 (PST) Date: Fri, 10 Nov 2017 13:05:54 +0900 From: Stephen Hemminger To: Ferruh Yigit Cc: Alejandro Lucero , dev@dpdk.org, stable@dpdk.org Message-ID: <20171110130554.3e491e70@shemminger-XPS-13-9360> In-Reply-To: <15bd63fc-1c14-faae-ac09-b94375fb1553@intel.com> References: <1510142385-23710-1-git-send-email-alejandro.lucero@netronome.com> <15bd63fc-1c14-faae-ac09-b94375fb1553@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/nfp: initialize stats struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 04:06:43 -0000 On Thu, 9 Nov 2017 17:10:16 -0800 Ferruh Yigit wrote: > On 11/8/2017 3:59 AM, Alejandro Lucero wrote: > > Not all struct fields will be written and random data could > > confuse readers. > > > > Fixes: 92aa491b881e ("nfp: add statistics") > > Coverity: 140755 > > Hi Alejandro, > > Thank you for coverity fixes, but they will be considered for next release, > since trying to limit rc4 only for critical fixes. > > Thanks, > ferruh > > > > > Signed-off-by: Alejandro Lucero > This looks like a bug fix. because the stats are on the stack and will be garbage.