From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id BC6271B6F3 for ; Fri, 10 Nov 2017 15:49:17 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id b14so3237777wme.2 for ; Fri, 10 Nov 2017 06:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nG8l8jTrudAaRYeWaKpueBMne86YfJHJ84Ykd0YV2PQ=; b=uPFTukWRv+KFg1IQq1o72nbRcKaqpg4TudgGQIQniMR2R9Zc7Bz5k+PoO0kOVJIY8X 7OENcO2QDj3eHbpAVonXZ3x2OG6nRdwVA+WuJxOwUVbH68yR8OyH4yc/60P5ueQUAcI2 zGK8BYwV2qKU6ce0c2nHjTaClb1G49byHmrcrN6qQ2XBLazvMvpCpLDOiXIJsBj2NgcG KdPmRwO+Ud6QZYSN1qxzaKXLn/0z3P/QzdX6ce7BIgIibfK2A8IR3IdLD3j+jb46IkdH +ud947ixQoTWCYp5w/7o/0O0eqjqZCqKl6KpP7IePEKNm7NCkg9YtK8sEh5UuYGEGgY5 /Q/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nG8l8jTrudAaRYeWaKpueBMne86YfJHJ84Ykd0YV2PQ=; b=KVsFVBws1wCWy+0MGh4kzg7JhjMIheUFrQZchP1UUBz55GXTtXgXCC7w91TvZiQZGm LG/BfhXK6t581DPrIJFcm7tKzFMkYxwHNAtPY8eiSMPhXIxXUDWcTz6NwZA23Mp4AxfK 15ttBBv9RwYHjB8tNcSK4pMtrrXvHBxFwJiFLLp3urpXMUT4oTo3qLARuhC1Qb7CFwNq XPvjdXpo09DHlQNkSqsgbQqqBHxf3mcYBjyzEEy33c121UOx+7JyXjCMHw1m1GamiBGF 1VOqOmaGwupEERY/UxUufDjxKJUuU74kfnQv3h9IkVlUp5CHapR8LusMP1zCdsM14gWR Wsjw== X-Gm-Message-State: AJaThX7SO8O8nvew1wYNtNRI0mRk9ml9N15BzsTD3D8KmmUgVpWWMXd3 VXDoAJOozngF0hosc1wkmabB X-Google-Smtp-Source: AGs4zMb+ZXq5WDva2QN8XBVO9BcvcGTkOho9nZyBTZ0/NpIcJoeenWroCfFQxkum/fGvqJcs4BUdKA== X-Received: by 10.28.227.139 with SMTP id a133mr465749wmh.104.1510325357206; Fri, 10 Nov 2017 06:49:17 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m23sm1288654wmc.29.2017.11.10.06.49.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Nov 2017 06:49:16 -0800 (PST) Date: Fri, 10 Nov 2017 15:49:37 +0100 From: Nelio Laranjeiro To: Edward Makarov Cc: Adrien Mazarguil , Roman Khimov , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20171110144937.eswbmusccxmt6mk7@laranjeiro-vm.dev.6wind.com> References: <20171110141746.19251-1-makarov@kraftway.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171110141746.19251-1-makarov@kraftway.ru> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix use of bit numbers instead of masks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 14:49:18 -0000 On Fri, Nov 10, 2017 at 02:18:04PM +0000, Edward Makarov wrote: > The constant ETHTOOL_LINK_MODE_1000baseT_Full_BIT and the others like > that in mlx5_link_update_unlocked_gs must be bit masks but unfortunately > they are bit numbers. This commit fixes the issue. > > Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") > Cc: nelio.laranjeiro@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Edward Makarov Acked-by: Nelio Laranjeiro Indeed, nice catch. Thanks, -- Nélio Laranjeiro 6WIND