From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 344821B2DE
 for <dev@dpdk.org>; Tue, 14 Nov 2017 09:24:53 +0100 (CET)
Received: from lfbn-1-6068-189.w90-110.abo.wanadoo.fr ([90.110.3.189]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1eEWcT-0006tR-Fk; Tue, 14 Nov 2017 09:30:59 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Tue, 14 Nov 2017 09:24:46 +0100
Date: Tue, 14 Nov 2017 09:24:46 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ilya Matveychikov <matvejchikov@gmail.com>, dev@dpdk.org
Message-ID: <20171114082444.7v2dspzxno2vmbln@platinum>
References: <04EF52DF-6CE8-4EF4-96AA-711184F8379F@gmail.com>
 <2FAC1B54-ACCA-439E-BE58-10007DB35E56@gmail.com>
 <20171113103328.bcxyswa3toxemht5@platinum> <3421519.PnyVhdA6Oj@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3421519.PnyVhdA6Oj@xps>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs types change
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2017 08:24:54 -0000

On Tue, Nov 14, 2017 at 06:09:35AM +0100, Thomas Monjalon wrote:
> > > >> Update types of variables to correspond to nb_segs type change from
> > > >> uint8_t to uint16_t.
> > > >> 
> > > >> Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments")
> > > >> Cc: olivier.matz@6wind.com
> > > >> 
> > > >> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Is there a real benefit to get it in 17.11?

Without this patch:

- cloning a mbuf with more than 255 segments will create an mbuf with an
  invalid number of segments.

- chaining mbufs with rte_pktmbuf_chain() will return an error if the
  resulting mbuf has more than 255 segments.

> Is there a risk?

It is not so critical, since manipulating mbufs with a large number of
segments is a very specific use case.

But the risk seems low, I think we can put it in 17.11.

Olivier