* [dpdk-dev] [PATCH] net/mlx5: fix flow mark action on port start
@ 2017-11-15 7:09 Shahaf Shuler
2017-11-15 7:58 ` Nelio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Shahaf Shuler @ 2017-11-15 7:09 UTC (permalink / raw)
To: nelio.laranjeiro, yskoh, adrien.mazarguil; +Cc: dev
Mark action flag was not set on the flow, causing the rx burst function
after port start to ignore the flow mark.
Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
Cc: nelio.laranjeiro@6wind.com
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 466d74b5f..f32dfdd3f 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1930,6 +1930,7 @@ priv_flow_create(struct priv *priv,
flow->queues = (uint16_t (*)[])(flow + 1);
memcpy(flow->queues, parser.queues, parser.queues_n * sizeof(uint16_t));
flow->queues_n = parser.queues_n;
+ flow->mark = parser.mark;
/* Copy RSS configuration. */
flow->rss_conf = parser.rss_conf;
flow->rss_conf.rss_key = flow->rss_key;
--
2.12.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow mark action on port start
2017-11-15 7:09 [dpdk-dev] [PATCH] net/mlx5: fix flow mark action on port start Shahaf Shuler
@ 2017-11-15 7:58 ` Nelio Laranjeiro
2017-11-15 8:08 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2017-11-15 7:58 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: yskoh, adrien.mazarguil, dev
On Wed, Nov 15, 2017 at 09:09:49AM +0200, Shahaf Shuler wrote:
> Mark action flag was not set on the flow, causing the rx burst function
> after port start to ignore the flow mark.
>
> Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
> Cc: nelio.laranjeiro@6wind.com
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 466d74b5f..f32dfdd3f 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1930,6 +1930,7 @@ priv_flow_create(struct priv *priv,
> flow->queues = (uint16_t (*)[])(flow + 1);
> memcpy(flow->queues, parser.queues, parser.queues_n * sizeof(uint16_t));
> flow->queues_n = parser.queues_n;
> + flow->mark = parser.mark;
> /* Copy RSS configuration. */
> flow->rss_conf = parser.rss_conf;
> flow->rss_conf.rss_key = flow->rss_key;
> --
> 2.12.0
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow mark action on port start
2017-11-15 7:58 ` Nelio Laranjeiro
@ 2017-11-15 8:08 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-11-15 8:08 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: dev, Nelio Laranjeiro, yskoh, adrien.mazarguil
15/11/2017 08:58, Nelio Laranjeiro:
> On Wed, Nov 15, 2017 at 09:09:49AM +0200, Shahaf Shuler wrote:
> > Mark action flag was not set on the flow, causing the rx burst function
> > after port start to ignore the flow mark.
> >
> > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
> > Cc: nelio.laranjeiro@6wind.com
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-15 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-15 7:09 [dpdk-dev] [PATCH] net/mlx5: fix flow mark action on port start Shahaf Shuler
2017-11-15 7:58 ` Nelio Laranjeiro
2017-11-15 8:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).