From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 3654F1B2D7
 for <dev@dpdk.org>; Thu, 16 Nov 2017 10:37:59 +0100 (CET)
Received: from lfbn-1-6068-189.w90-110.abo.wanadoo.fr ([90.110.3.189]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1eFGiF-0001k1-6p; Thu, 16 Nov 2017 10:44:00 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Thu, 16 Nov 2017 10:37:46 +0100
Date: Thu, 16 Nov 2017 10:37:46 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
To: Ilya Matveychikov <matvejchikov@gmail.com>
Cc: "Hanoch Haim (hhaim)" <hhaim@cisco.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20171116093745.sbmfa24jtu4r2ms4@platinum>
References: <20171115091413.27119-1-hhaim@cisco.com>
 <1D98684F-B8A9-4037-8534-0D4E3A1FD34C@gmail.com>
 <ad03f3a3142141afb9dc565500429df9@XCH-RTP-017.cisco.com>
 <20171115173058.mrkrv3usbl5sfw3h@platinum>
 <2fa9a7806c9e447995d6017c6def9894@XCH-RTP-017.cisco.com>
 <20171116084112.ockgmxnxews7coie@platinum>
 <d36d343ac5594b0ca85f79902a917dd8@XCH-RTP-017.cisco.com>
 <5C1B1043-3444-4750-A7AB-D96403C61E42@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5C1B1043-3444-4750-A7AB-D96403C61E42@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(),
 fix atomic usage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Nov 2017 09:38:00 -0000

On Thu, Nov 16, 2017 at 01:32:13PM +0400, Ilya Matveychikov wrote:
> 
> > On Nov 16, 2017, at 1:06 PM, Hanoch Haim (hhaim) <hhaim@cisco.com> wrote:
> > 
> > Understood 
> > 
> > rte_mbuf_refcnt_update_blind() 
> > 
> > should be good., it will take care the RTE_MBUF_REFCNT_ATOMIC 
> > 
> 
> 
> Why guys not to add just __rte_mbuf_refcnt_update() as a wrapper over
> rte_atomic16_add_return() and use it in inside rte_mbuf_refcnt_update() and
> rte_pktmbuf_prefree_seg() as well?
> 

Is there any other difference with rte_mbuf_refcnt_update_blind() except
the function name?