From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
olivier.matz@6wind.com, thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print
Date: Fri, 17 Nov 2017 14:17:23 +0530 [thread overview]
Message-ID: <20171117084722.by7sdxdoimkwdqpg@Pavan-LT> (raw)
In-Reply-To: <81bb5aae-527d-5b1a-5609-985256682d39@intel.com>
On Thu, Nov 16, 2017 at 11:48:14AM -0800, Ferruh Yigit wrote:
> On 11/16/2017 2:31 AM, Pavan Nikhilesh wrote:
> > Dynamic logs fail to print if the global log level is less than dynamic
> > loglevel. Example if the global log level is set to INFO and dynamic log
> > level for a specific module is set to DEBUG then the log fails to print.
>
> What is the purpose of the global log level value?
>
As per my understanding, If we want to filter out debug logs from all other
modules except a specific module using --log-level="<regex>,<level>" the logs
would fail to print if the global log level is lower than the specified level.
If during EAL init we want to filter out all the logs except a certain pmd's
log we can specify --log-level="pmd\..*,<level>" without modifying the global
log level. Also, this wouldnt break the previous functionality of global log
level.
> > Check modules log level before checking the global log level.
> >
> > Fixes: c1b5fa94a46f ("eal: support dynamic log types")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> <...>
>
next prev parent reply other threads:[~2017-11-17 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 10:31 [dpdk-dev] [PATCH 1/2] eal: fix legacy dynamic logs defaulting to debug Pavan Nikhilesh
2017-11-16 10:31 ` [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print Pavan Nikhilesh
2017-11-16 19:48 ` Ferruh Yigit
2017-11-17 8:47 ` Pavan Nikhilesh Bhagavatula [this message]
2017-11-20 18:40 ` Ferruh Yigit
2017-11-21 8:30 ` Pavan Nikhilesh Bhagavatula
2017-11-21 10:55 ` Thomas Monjalon
2017-11-21 11:14 ` Pavan Nikhilesh Bhagavatula
2017-11-21 13:30 ` Thomas Monjalon
2017-11-21 14:04 ` Pavan Nikhilesh Bhagavatula
2017-11-21 18:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117084722.by7sdxdoimkwdqpg@Pavan-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).