From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0083.outbound.protection.outlook.com [104.47.34.83]) by dpdk.org (Postfix) with ESMTP id 3ECC423B for ; Tue, 21 Nov 2017 09:30:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ckKOzAjWf1by/5FGFB0mZQOFeYKLLdURM3tzbv90hEA=; b=OPCQp66JatUo3TXu6diDMrDKfOZXE9LvqfNYSGTP4eQKhZ20NXEQDJvWtCrQRtxdc1iEyJcpDCGTPB+HHlsAK6rrJzO60kbQEMMSKe5GIhz5ggb6Y10r1ZmuyLIt9s4Bqvfb62tvI321hTI0UkW39jA5/nGuwlqCPGCGzmePW4M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by CY4PR07MB3464.namprd07.prod.outlook.com (10.171.252.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.239.5; Tue, 21 Nov 2017 08:30:34 +0000 Date: Tue, 21 Nov 2017 14:00:23 +0530 From: Pavan Nikhilesh Bhagavatula To: Ferruh Yigit , olivier.matz@6wind.com, thomas@monjalon.net Cc: dev@dpdk.org Message-ID: <20171121083000.2rhwsm7pefmervke@Pavan-LT> References: <20171116103144.4197-1-pbhagavatula@caviumnetworks.com> <20171116103144.4197-2-pbhagavatula@caviumnetworks.com> <81bb5aae-527d-5b1a-5609-985256682d39@intel.com> <20171117084722.by7sdxdoimkwdqpg@Pavan-LT> <9e17df24-9b52-620f-b299-fdc42a1083c4@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e17df24-9b52-620f-b299-fdc42a1083c4@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SN4PR0801CA0015.namprd08.prod.outlook.com (10.161.215.153) To CY4PR07MB3464.namprd07.prod.outlook.com (10.171.252.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f3bd5fd-716d-4435-ed8e-08d530ba23b2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:CY4PR07MB3464; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 3:LYpactO7v7FoHSLsinfV7DaYn66h0Not5DDIgDwn3LpwygKb0XcHxorRzJhAqoDkLBK+YwZ/T40S5nZrUBWGwJE2Sl5Ig6/5bC1Td4HTLugLtLVZStinCEfP8FIVimFoaWUXlZazDbG4Js6Y+Y1mTxc6Ef9cmVu4CVksIO/fkcFIvxCvhpIbhQfL9JE1bq4vos/AaoDdLa2blmTVeGQFqWICkTtHXOIw6lxBwUCPCjMGCzuCGU7RLCjjoumzkP4o; 25:TucKNcAXTc10AwNVh8k6c81D/k003L2FcoApwJ+gsZM0eiF2c/2Kgz/6N1Z9cn/6qHKdJ9EqSiQD7xqHIB9bLxCPfHSkrLm/56PDjE2lhSZIAuThUertuE/jFQxWGcDJT0nf738IFoJtxqqq8+FcYxn0mCiiXwOOFQdTFnF5Ul3LladXVFIlO3995IDwHqX/h/ylZzlBfuxkpeQThscMgn0Ft7TbFgNJcN7ohZEqBmW3v3BIBvtKWekMusTYOrNtmSj4uZQD4dMjHObf3U8Xm39+tgtXkV//2HEd4MS+d57kb74bX6bmh4wt/Gr8zWuEr7AGzkoLC2ce3MVCMtQvfQ==; 31:vIS+/ZuKpLGf2/USw9hdrw29q1O/LhWxBL1BhEA/CD2bGR1OD0jAUNuJhiJEvdvEypnHhJ3Zs41e53tiGJgM25ewRfLiIA7pwvbfnbdvFhVp5f3x23sI6YrzxcsargbCZQHS8mpdpXAsTInnZ8if2blRXFU2SzBOooQ5VhDu8JF5ELx0wS+zPCgVi/1ywxTVXdeiA3hop6ZPwg25Q38d9iqAIn6U+RbxwavoO9ua6OE= X-MS-TrafficTypeDiagnostic: CY4PR07MB3464: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 20:EsQj15yf+qurrLpGJenRAg3j3d/IUctnG09bGOxCBNxrTIOlZSF8an7IEgYNtETWRPex5lmCWUccqQkc221DNLF2OX/HfcszzHrN6lwVO2qHcpp4ecUCQFs1fGQulOGy/lfGidMIFhrvmNsLKxQYeYLGOmbsBwJ4FcCB63piLN7oJUbpnSV73WlWmnaxxHZBLL6BX0VlDQtiwBIfC45oI1c63hSEW1sAw8VNyrxqjKrceZFhylhVDRDGxDl70qgvX+59uFNDifgLW6m5/Po3SlnSRVOrUMDp8Hrr1rGL8+kiY+QOz5TD+NdjJVaCcmKBxJ0NCB/3R06kyMAjmivh91NdBUObDWx9YCzuPdQXxQhDCeVmamKw3dfv1+Ok9HHhxnRDWjJQg3yV7nhEmN4oOBKJD1RXWz0fdPVmdLrq1vLezmV+lXTtq4HQKZTbmsaVK6zMn22XiMfWDn1UszFk5+IgL+rwHPqKqw9ggbcql4Gee8lyh7G2CL9XlWmZ2OB3ST+1hPuKg06+U8mCE4B38jOZCibdaWg2HwSro1QCt2vfL+pf6rKfN9e+4gLVP0P54ZVAoY886g7JT+pryqqlk0I4jFmVHhVw8Wb1Ami/SWw=; 4:SjdE9W0oAs/JHBALjlG7BCiD14jwGkU9kOMEVseVxNFhrRs1hrcsrjlq3ztubhVaSqH1fQhybep9HIOktl2Yy6vbIUsAV4ToSX62AdzNZ1FIgl7biH9fv8vo43Fl4KFQG/WlJF67SclPNi1RXi373rqmCUBnm2eQyYy4rMZ2BQgB5OKTvvmhGGY94RtmXmkMSazV7nv+28WJDAIOLt6Gsbl/ECf+NARrdnHUbQ4CvC2+xUTc8mpWZ9iwNjdvTt7Qoi2Slm0NE/64Z4/3thKgCg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3231022)(3002001)(93006095)(6041248)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3464; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3464; X-Forefront-PRVS: 049897979A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(24454002)(316002)(33646002)(50466002)(229853002)(58126008)(16586007)(93886005)(68736007)(23726003)(72206003)(3846002)(1076002)(189998001)(966005)(66066001)(106356001)(47776003)(478600001)(105586002)(6116002)(25786009)(53546010)(33716001)(97736004)(83506002)(81166006)(8676002)(81156014)(6246003)(50986999)(54356999)(5009440100003)(2906002)(76176999)(5660300001)(6306002)(9686003)(55016002)(53936002)(42882006)(2950100002)(7736002)(16526018)(305945005)(6496006)(6666003)(101416001)(4326008)(8936002)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3464; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3464; 23:Yqdx/dDTh7Cf6DVEZ5jP/qSoHWh94Czk+vwcuH5aa?= =?us-ascii?Q?Uwk75wOAR4b/L2YT8LOqrCGxSv/8FACutZp2sDZxcPIBUtnNMx6uxIyb46WT?= =?us-ascii?Q?EiNDCwgCI8N+Wjmf2G5edsZ0mtXrzoejQqicC+0m0NjhKB9+y2UhglZIXM8D?= =?us-ascii?Q?Czmt54NXFX7J5TV+/uFZbOLps1tKSSz8AfwTwTLijdDi7NfAkKj7exmnaZ+L?= =?us-ascii?Q?6+V3MNBCz/KoWn0xLaquHiD4A45nvH2aflM7DQxZkzzjYiCFaR+kqecN4Ei5?= =?us-ascii?Q?IL2mj518k+MR5o80zxiKdPK4TVvRDlifNC+Zf25A6IvcFNzHdq++LVYrIoAZ?= =?us-ascii?Q?CzeSPA87Se6U9QBwxkml/XNDvQhgPvGE3sAMoGOMVxHUKmZIJTk1KcdPrtjL?= =?us-ascii?Q?wl5qO0TUAXKNYx4ySGfbMDcEGLb4uLTPhoVIfCc1v2ImlThfKmU9j00tWom8?= =?us-ascii?Q?6DH9Zjvi+yt1r3LzSIQLtj8kLnhqIarjuR/wkOA0OoqNu/CApaaysx86nawk?= =?us-ascii?Q?TLMP9hTlXGcJK3Y//JUU+J2H3GNBV3KxilMQEyDAgQGew/L5elLhMqejU0xI?= =?us-ascii?Q?H8NtfF98Yp8Z2fwT17Ie6Sm3EvbyMHvpHmJBNCGuDraVUorFjet0/1JD/6aj?= =?us-ascii?Q?S1UYEWaoeF/Am2BXDyKr2XLH30CIHK2A+Y9uE6n+v6z1DelJQJr5Tm5lxz0k?= =?us-ascii?Q?af07iJC2y/NOjHwUHCF9PcOqWl/xEOeyoT6vNyxSP+nTv9qP89eJkYtETybL?= =?us-ascii?Q?+gEsUlDNIeFDd/4zu415Rkw2myoDUJhHUuN31DinNk8FP2oBkJKd4f5FECf7?= =?us-ascii?Q?rAzr3Nvhc9VYOhqXTw44FMASkEcH4F7gxX/h6e2ziWKrNKkUUM1o9Z0MMAP6?= =?us-ascii?Q?ni6berYImJgA7ezKltUz5kDqpJEr3iV7Tc+mGimmvBZjGD/+u+hJhCamhtWt?= =?us-ascii?Q?Ct8SNzxKVBR8eXgHaILUEyEyY+Qd1Yde7/4c1d4lXyAkcJr7b1q0uDZzh3C6?= =?us-ascii?Q?BB2hwEtmz+ambuQjEMkXS2nW1GqGr5wAnFgcjRyBZ9SHJkgzRKnb+KPqBd2G?= =?us-ascii?Q?WWZbW1a2EOLWPTmJsQHcnIIMpM+vIQDueyNybmQYzQ9hTX5H2E1ZFYygvgdf?= =?us-ascii?Q?JOkmcyxV9Sp+LJWtPD7P1xCghkr2CP69vP7R59Ev91EKHaXQQSN6JY0HzGgW?= =?us-ascii?Q?2yu8INqm6JClzodj111Ei1AWUhzWdyJfghG2UmNHDeZt4VY+MpRkFI9YUH06?= =?us-ascii?Q?eRQcpFhrdFMky2dxBgL9OnVcUgXtS+Aah3XRApiboycAPRjFl8y6RT7f7SgS?= =?us-ascii?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 6:9JAciAa2t1g3MArGcscj5Z76e4f4aeAc7DPwcKKZF53SzYdi75shpodHfvPa2q+XnotbfunfdIHl3pa4L6IOdbhpTCs874iI0lfQiIZ7UjOqWUXOTQWHmRDK/3F1QW7n9QgApKROxZDhQ4f5MsmjZFnDqP+UuZLNnFAmpQg9r6lrNPWtTxDAtFDC1MhcerczUVVBu2ERXCDDLviZlo8kmMSIO8NCL3LZk/dXqS0QjeX1ug75biomCmIWrZs/1DWnqAXlE1adcsqCycajdOihcryjHA+HG5HnMwvIWJUV+/WTsziaf5nnno7QhleLh8rINYaNHEz+hCVBjkJ2X++7WJJ9E4gODO9XNZbF94N7c9E=; 5:wg2HgM+ApAN+fkIU7/Pg6GCxz5KXEnwnP8w0IgtBijYatdp+7BYtxinefINtSAuFX8HoEaWsCbyH2x/x8C9bqeUStflvPNaIR9Pwmj4cCJ523WZJUz399xW4UFj9qtnGTXuJrLK5LpEegazl1vG3LkiLOBC61DRTC8NCIxIDRXA=; 24:nd4xMlZR0Pe0cG0pLBvXm6UxQzkVTsQswUOC0uf+pdDwy459nl9FC93QynOe3UcY6PBM5bBNLg0798iqqvbOHkFLe00A74582uvVZG61caE=; 7:CylXWE9VEhAwxH2TvX5p3lwxiAc70lCpKCL6rKtPQrtCiji6OHMXG64TvOyi6ysm/aIp7Dc/nPOg+8fQTO0j1Oc1nbef4Xqi3mvdlxh1cDy7GxSDj5B5+Dxd2Y5gMj3yoJPTMnmn9mpDGdPDR6EkZ7JiCTtkQj/v+yvba4CnFlSa178b1N33WftDMD6lTg8Nxv/kdCoNLBhke0v3nBcHlUaCDG5vi4X/e+j7FrN8LtIcvNp4TA4Rbk2BVc0eVn9B SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2017 08:30:34.6115 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f3bd5fd-716d-4435-ed8e-08d530ba23b2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3464 Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 08:30:38 -0000 On Mon, Nov 20, 2017 at 10:40:29AM -0800, Ferruh Yigit wrote: > On 11/17/2017 12:47 AM, Pavan Nikhilesh Bhagavatula wrote: > > On Thu, Nov 16, 2017 at 11:48:14AM -0800, Ferruh Yigit wrote: > >> On 11/16/2017 2:31 AM, Pavan Nikhilesh wrote: > >>> Dynamic logs fail to print if the global log level is less than dynamic > >>> loglevel. Example if the global log level is set to INFO and dynamic log > >>> level for a specific module is set to DEBUG then the log fails to print. > >> > >> What is the purpose of the global log level value? > >> > > > > As per my understanding, If we want to filter out debug logs from all other > > modules except a specific module using --log-level="," the logs > > would fail to print if the global log level is lower than the specified level. > > Yes. > > > > > If during EAL init we want to filter out all the logs except a certain pmd's > > log we can specify --log-level="pmd\..*," without modifying the global > > log level. Also, this wouldnt break the previous functionality of global log > > level. > > But this overwrites the global and makes it useless. > > Lets say global log level is set to "critical" (3), if module set something > bigger like "info" (7) that will set the limit, so module will be controlling > and what is the point of having global level? > > It can be an option remove global level completely and let modules control what > to log, but I believe it can be useful to have a global control. > > > What about having a verbose global and limited module log levels: > global default: debug (8) > modules default: info (7) > > so if you want get verbose log from specific module: > --log-level=",8" > > for globally less verbose log: > --log-level=3 > > But this makes hard to enable verbose log from everything, although not sure how > practical is this. For this one it can be possible to have a new API to set > modules other than given one, like: > --log-level="eal,-4" --> set level of all modules except "eal" to "error" (4) > > > Also I believe it is possible to remove RTE_LOG_LEVEL config option completely > since dynamic debug exist now. Previously it was good to have because it was > used to compile out debug functions in data path, now there is > "RTE_LOG_DP_LEVEL" for that purpose, so it can be possible to remove > RTE_LOG_LEVEL and in rte_log_init() set to DEBUG by default if you agree with > above approach. > I do agree with this approach it gives more fluid control over logging. And for the case where we want to match everything except we could still use regex example: https://regex101.com/r/vqGiUK/1/ > > > And, since you are touching these files :), > for better regex support, it may be good to have log types hierarchical, like > "lib.mbuf", "lib.mempool", "lib.eal.malloc", as done in member library but with > "lib" prefix instead of "librte", if this makes sense and you have time would > you mind sending a patch for this as well? > I will redo the patchset including these :). > > Thanks, > ferruh > > > > >>> Check modules log level before checking the global log level. > >>> > >>> Fixes: c1b5fa94a46f ("eal: support dynamic log types") > >>> > >>> Signed-off-by: Pavan Nikhilesh > >> > >> <...> > >> >