From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0063.outbound.protection.outlook.com [104.47.34.63]) by dpdk.org (Postfix) with ESMTP id E73E9236 for ; Tue, 21 Nov 2017 12:15:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xpiltOHs6u6l740Cj26BBAwq4gLBLI3HMnxJvjWGUXE=; b=aWNGY/1rIgmaBr4v/Mv6jzqIK6yTIzgC9EQo/O35p5LQJ0CaxJFhXqyY12ruliOdkoNSTDzbM0vVv/6rXEoij+IO9KwKjZBzhN4T19rOL0iMd8GDSUCGRDaFZW0e2TYoMmPcMw5Nz7WeJnHkijp4B9fNhA6ZavsKpZcFgbBT/6o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by BN6PR07MB3457.namprd07.prod.outlook.com (10.161.153.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.239.5; Tue, 21 Nov 2017 11:15:02 +0000 Date: Tue, 21 Nov 2017 16:44:17 +0530 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon , ferruh.yigit@intel.com, olivier.matz@6wind.com Cc: dev@dpdk.org Message-ID: <20171121111416.yffsbci3cswwpzx5@Pavan-LT> References: <20171116103144.4197-1-pbhagavatula@caviumnetworks.com> <20171117084722.by7sdxdoimkwdqpg@Pavan-LT> <9e17df24-9b52-620f-b299-fdc42a1083c4@intel.com> <1772478.GecVQuhyhE@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1772478.GecVQuhyhE@xps> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MWHPR13CA0030.namprd13.prod.outlook.com (10.173.117.144) To BN6PR07MB3457.namprd07.prod.outlook.com (10.161.153.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48325e68-1a05-468d-b7aa-08d530d11dcb X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:BN6PR07MB3457; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 3:i7DTAOzf6cV+lfD5kuElh1ZLyECA4TdUzEsBl7b9ndRedq88jcxdh1B6IrMkzty0KX5Lmuczv/KuV8fJwoAAmYMUxPad/DSOn2nvPpfA+VQZ0mEfSVBGxZZ9udbQVjEnztZzTLO7iHeX22+JngqTTkxa8AHHw6++W8onpCsCqynFKlAXGnqmSuQbMbda5T9Q3Aox4Ido98JSWreobqyqLmyTHRCkoS0FPf9koLSm0jtglmGP+M+uaEUk+11kHI9m; 25:UufiMgSpaLtmcro2zyelhyQF5OXFt2jrDC8Z14H7rxmpdmrCO6Y1IO1JYD86zptuYg6Ez0hQ7HkeY0GRtvw58QSEBed/TSaOeRNdRVsY16ZHCynx6OtYZXA50MsY4NebFiwyWkcqaz8fBClZhovfO05otUi4HXyfcxTe0D/5rdG554u1AyrfNA+5U+/5zF/ErFBlxZAEXjtU0dCgY8GXqYhgFrFZ451y5EwtKrdznN1mxQwR6Ufi/hCNWnDi57im0raDja19uQLq5EcDDUu+1vcikUbmEnVJ7yjn7wuGWktZF7aD+CVCy3uyIXeOeDAngB3a6evDL3SSMvZkWMHf7w==; 31:JOBxH/gbtmv3g0xyjFtBY0KKDrdpLU+8nbSSAOhYBsx0nB+9znT4pDLVcQi/j6csVGLkrykXkQ9LN9wy4gTQNqcw6BWU/0hSSs7DFzb7vy7TENqXlbVRsobcmV5nreee3TifkpFujg2z+8Cbd1unFDQUs0wZDjxYzSC1AfWLPvY2EZk1EKSz/zC8XTiujWFANzC9Qgq/IRrKufAnNGAgM5fqLNZ5UoFxrD44mO72t1k= X-MS-TrafficTypeDiagnostic: BN6PR07MB3457: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 20:78T3W6FAiTZt00F08W9Rv3pOtvnr57R0UScVhctI5RVN4GUQA3tS39/U96gLzgmAww+EvqLShBhXLxOnw5F72TBmzqwWs2P2FhZa1M1irn1mdG+iHEprzuD8FAj3MdJ6agbr9VCaKtorKz+3POLuyy3EgjnCGxas/LYsLwkoOe0mlzRxZ6oQTPEQEU3f1nU6JICSkgpcvoYd+aVxGR6DW5AWnD3REgLSsArneI3Wb66dw0nCVqwQ2VRrRWIFNdkciGQT/sKDaUkx1rMy+VUUI1+TwJ+feNF7lM7lc1z9nsDsVC1klqHQgc28oYwtGGjoBiws1SE5ACoKrMHgSIirmw9WnQ+D/XX3nqhhIjk247tFXhGLFPDdzveCaX7idKUy6+5wnzI9uS/+117ytDzCJ1u6WdfqkO6sK+Aa4PQuBY7Hcv6ADuny06aTasgatoVfslS8ZbEqiJT1X5osBecQKPrdT5Xgc+EgPTZJPBYKsBuL1kAiVp7sR3sLk7hQn9qkVCG5eFsWRySkjLFC+l/+MJVNIEM/EVZr1b4D/3/jjGwUkUhszl4pGf1VNfWEkDTJu86dvhsU/G+VgjdSqL6yTGr0zGjgcIG9OPdqkxFPO/Y=; 4:vxNw6V8u0Z3W6wtSuX3D8YphGPEInEbjMG5ydb+sLgDUIwSntgjkecz4kN37MaTPHg/oKtOjUFU2BBELEhIbDAOKeHZt9cMLEmZjEcdxv4mMbcnF05o9b6dMV27epQcDJV+LJzDeiE0JLoW71daMX/JpF0Jn2vcP8+xC35bW/NuHoh3A/ALB8kUfE5vUQD7lKbrQKglk7rmq392LiL4epXA0V9w/J/87E7sHY8Zv5W8KT7cSkJBGrcfpgaxlZk4fOXTF3gMQ83UN4sCTCGje3A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(10201501046)(3231022)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3457; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3457; X-Forefront-PRVS: 049897979A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(24454002)(199003)(189002)(9686003)(55016002)(6246003)(53936002)(33646002)(101416001)(6496006)(54356999)(76176999)(50986999)(106356001)(105586002)(4326008)(229853002)(83506002)(2906002)(8676002)(81166006)(189998001)(81156014)(7736002)(50466002)(97736004)(5660300001)(305945005)(33716001)(6666003)(42882006)(68736007)(25786009)(23726003)(3846002)(6116002)(72206003)(16526018)(2950100002)(47776003)(478600001)(5009440100003)(58126008)(8936002)(316002)(93886005)(16586007)(66066001)(1076002)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3457; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3457; 23:3Z3NU+AHIQYicMc91Thj79dVt9m4wKZvi/4cReyZp?= =?us-ascii?Q?3wfX6j1vJyEcv4HTjKxsNLN2nlYaJZnZqopSMWUXsJOY4m88WdUna2FC1vnx?= =?us-ascii?Q?dnuy5vaEeKkSy/Ywzs61CzUbwXpg2tbTi7IssQbVTu3Bqb1NGlxhQ7gK2NQz?= =?us-ascii?Q?CpguLZLu9Za55ixTVakN7pM9gxDyTNMnIOyFcejnHTqQCOMiKZokwuNGfeIG?= =?us-ascii?Q?rp8BnA02bDi/EZiqOLEzNWC+0wlsWGNFY39utGwfBeauJ5kVFUoUIA63GNju?= =?us-ascii?Q?cfbwO6Rj23E/1hvwVRNJVdKPQHmCBw5GI7VkMuC6kzvZcAs30e6aPqyiM5yY?= =?us-ascii?Q?meOgPB9n/cGlqZkD3+R5usG8lK6iFLWHeJV4FShfCLoD4GA143oq7BBjqkxb?= =?us-ascii?Q?NPLs/zwiqhWrBClUxk+cdk1679xWTtEkI9ZQGp4SQBSlZXRB0oCAEsrqz/rb?= =?us-ascii?Q?Sh/7nL9jCkWGZjDJgJgfQyo2L7wUmAA8f4aJzLzG1/yYnm7OrrY96unO7W8i?= =?us-ascii?Q?FM0/1szqz6TzkTLaq99SJJYbwKj9JW4IB3J6vK+TceFL23vlNZWGRRQYWc5S?= =?us-ascii?Q?jUz+Z7WqfV8Ubt+QSsqV+0lSoV3+vEwfPId8aMKWCsAYX7mLrEVnXyXx8X9F?= =?us-ascii?Q?U/wwMn1otGCR5Wm6u5ylmSotTuv9etNRLcsMEQ6vPEL8vb9RcTnutPltTcEu?= =?us-ascii?Q?hirYXdLAy3M5SeZfq772rhqXu2dcYK2VBRlhf6eCTqphf7jkN6O09EVVlQlt?= =?us-ascii?Q?IEmuImRE1JxbI8tVbjftwybCl0pbCheslQHlbEkIi7Yasaw8oyiXeKSWtq1M?= =?us-ascii?Q?hScw2jQ3m64nYkdPx0T47NtqhKcBT6/A0t0sFWl2gdOOoGFvpZRrbyp597pr?= =?us-ascii?Q?OuR3EEbP5FVIDxBj6caBzKenK6+ZWg/Lvu0RfBZXn9ifHcCW+5N/rz+KyY+h?= =?us-ascii?Q?7hHWNyIHuX9gprqsjR3nP0yYsaum9+mVW/OSYI7pL51yNUuqdrI+fkrB+3Ru?= =?us-ascii?Q?su+k29hw6FKd7qhnRmLfoLwycj6zRMdniMdDepQUXN62/IbHIV6DkwHMyTye?= =?us-ascii?Q?Lvxh52sIwWYSSZhAyKJ6JRnaD2cA1Yn1pNRI+nW9sZmOqtdoBS1xjzlav/uC?= =?us-ascii?Q?BBGgkFE/PeKMm72+ZizEK5MnP6gc2DLUWcf3rjlenUH08y8De2Q8wSoN5Cg7?= =?us-ascii?Q?pP8vCUGQihPRcp8+aTH3aYev4nCzU86hlbbRM8BnFJWCIAEJJZITHfQaA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 6:7ax2IyBxIPCkXcZMqkxoPtGKAfUNfSdjtXY2+DokOifTM59eLgwh0K3Qcbx3fwEeBflMd+NnPl056KcqPXaeGVSYIQjswONB9o3zEe+6kO4Rj5xsB3vPVRp01kUGZh8JwdKfrMEIh9E4UbPR5deJQoteRA+s+6+Gzod50kyt8WN5ZERXo3JLCljIQL0cIu/IGNPqy0sajsp9vgodPfHmI/CPvyxZsKB3Hi5zbtA6ZlPnEh3osIT2XM7dA3uFTG7Ybv9mLa1aPALC+kTTgZMUxpkAOfy0Xpa/9lAaiIqC03T5l6FNHQxY11WLrGrJkdRm2Z8IvuOzfgsEopPdJX63t76unwtuxzOIevcPBU41Xsk=; 5:PeyGM7XkqvzNMquO/zxgASaqJv3MS23GywYb6kwo6DPK7Alev9/xfneieYVrQo3MO0679fktex0obXkiNUYImDwHTMOjgpQb0x4plrusoVynf6pPeserwTeZvD0i2EXy+A+L78b3ApN/MaJsrhYzVOePkiYvJZBLROJa99G0V30=; 24:j6W0O61RqyRaPJGs2OsNXhIfMKoJQAuNZ8RYd9AgV7a0alH/hb0yNjHsmqGnKPVH7V4PTZOC6gpyXs5jKs0fQw62J1AmeGS+01f/iqDRibA=; 7:78UziPS/gSFapCEhXyyJzfqUAXklL5e3DxMbxmtLfZbdTwTyQ+WNz+oZf//PNqWmM9HHP0wTM6nyPrT87ic92X+BsEaBKMTa65wTzRHajxuYlZuEgefrQjUCfgyQUKkUqosm/L39BAclemFopf80QP2yCZpc4sz65lNNKaRwwtyKT2xB9uiNyrH92UQ6wZNZ07bTuQOOISY9TEzE2kJlk7hwEsRdI9q4T/xecsJrLcD/FY2yOHQ9/cM33hixJqrw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2017 11:15:02.8825 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48325e68-1a05-468d-b7aa-08d530d11dcb X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3457 Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 11:15:10 -0000 On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote: > 20/11/2017 19:40, Ferruh Yigit: > > And, since you are touching these files :), > > for better regex support, it may be good to have log types hierarchical, like > > "lib.mbuf", "lib.mempool", "lib.eal.malloc", as done in member library but with > > "lib" prefix instead of "librte", if this makes sense and you have time would > > you mind sending a patch for this as well? > > I am not sure about using eal in the library names. > I think lib.malloc is enough and it would allow to move malloc > (and other libraries) outside of EAL if needed. > We already moved PCI and VDEV outside of EAL. More could be moved. Does this look good? static const struct logtype logtype_strings[] = { {RTE_LOGTYPE_EAL, "lib.eal"}, {RTE_LOGTYPE_MALLOC, "lib.malloc"}, {RTE_LOGTYPE_RING, "lib.ring"}, {RTE_LOGTYPE_MEMPOOL, "lib.mempool"}, {RTE_LOGTYPE_TIMER, "lib.timer"}, {RTE_LOGTYPE_PMD, "pmd"}, {RTE_LOGTYPE_HASH, "lib.hash"}, {RTE_LOGTYPE_LPM, "lib.lpm"}, {RTE_LOGTYPE_KNI, "lib.kni"}, {RTE_LOGTYPE_ACL, "lib.acl"}, {RTE_LOGTYPE_POWER, "lib.power"}, {RTE_LOGTYPE_METER, "lib.meter"}, {RTE_LOGTYPE_SCHED, "lib.sched"}, {RTE_LOGTYPE_PORT, "lib.port"}, {RTE_LOGTYPE_TABLE, "lib.table"}, {RTE_LOGTYPE_PIPELINE, "lib.pipeline"}, {RTE_LOGTYPE_MBUF, "lib.mbuf"}, {RTE_LOGTYPE_CRYPTODEV, "lib.cryptodev"}, {RTE_LOGTYPE_EFD, "lib.efd"}, {RTE_LOGTYPE_EVENTDEV, "lib.eventdev"}, {RTE_LOGTYPE_GSO, "lib.gso"}, {RTE_LOGTYPE_USER1, "user1"}, {RTE_LOGTYPE_USER2, "user2"}, {RTE_LOGTYPE_USER3, "user3"}, {RTE_LOGTYPE_USER4, "user4"}, {RTE_LOGTYPE_USER5, "user5"}, {RTE_LOGTYPE_USER6, "user6"}, {RTE_LOGTYPE_USER7, "user7"}, {RTE_LOGTYPE_USER8, "user8"} }; I will be sending out the patch set soon. Thanks, Pavan.