From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Pavan.Bhagavatula@cavium.com>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0082.outbound.protection.outlook.com [104.47.41.82])
 by dpdk.org (Postfix) with ESMTP id B0F9F235
 for <dev@dpdk.org>; Tue, 21 Nov 2017 15:05:12 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=lGPXpJ1zv5rGuj72vMbUnCW6jpd8wzrOhO+nTLaxgYE=;
 b=cejTNxUdpMCF20NbJguj0x89pIVGEMFPjU4guOwPPn4DOflQwE7mLnD02xj4KKlBdhLitnvqsTGPhg7ILmepadIWOoJ6wrOgabClyNeVU7wZcwCBHIuhMwHDT9YJCkhxt+9JGGe43yEE++iVFEKaDcRZv5fsNwrEusNfVBityr8=
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Pavan.Bhagavatula@cavium.com; 
Received: from Pavan-LT (111.93.218.67) by
 CY4PR07MB3461.namprd07.prod.outlook.com (10.171.252.142) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
 15.20.239.5; Tue, 21 Nov 2017 14:05:09 +0000
Date: Tue, 21 Nov 2017 19:34:53 +0530
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>, ferruh.yigit@intel.com,
 olivier.matz@6wind.com
Cc: dev@dpdk.org
Message-ID: <20171121140451.hq4niywykhqgvzbx@Pavan-LT>
References: <20171116103144.4197-1-pbhagavatula@caviumnetworks.com>
 <1772478.GecVQuhyhE@xps> <20171121111416.yffsbci3cswwpzx5@Pavan-LT>
 <5684106.7xpmVRmQS0@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5684106.7xpmVRmQS0@xps>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Originating-IP: [111.93.218.67]
X-ClientProxiedBy: MWHPR04CA0072.namprd04.prod.outlook.com (10.173.46.34) To
 CY4PR07MB3461.namprd07.prod.outlook.com (10.171.252.142)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 48b15f1c-c45b-4309-402c-08d530e8e113
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);
 SRVR:CY4PR07MB3461; 
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461;
 3:w4gQSDegm5BQcUB2Jup+umHKqjIMC1mvtmFg+zsPLa0w5VlwM5btGZIMfgTOY+XNGF+29YHAkHu8LPKzCXgQqAeXXjH5tl4Cy02Ikm977gZ1/cbKXutsG73d01obN6WBBvvxDv9gFtlzWSLTT7EJOcEVACuSQQrivcafwDToYvktrvKuHvDol3oAwwKbNCm6/fCMPWHuUdUOyd19S8kLrMvlqildVOcoxnk3a0HKFonGn2PTG9QaD/TpOoM3kzK3;
 25:zJ9ktUAu2NifjprgBcknei+7CTeRssULsf9CntcJq/1BIpvRga7Q2q/Nu7GybNShXh46dLSDmjOiQlUIwxmnzmla23gBgnmGp4x9mldM1dDpLYQCPBf7SPHpIUEf/zrSlp8kmfuNBU7sExcDe1TvvM3Hq586AMiYRrew0ETsID1LJNYZUoEv/qvHBSgcpxXx0xxq/mUm/NLr3fr04Ugijh/aMVO0StpwVhYBak7bYLxKZNDvpOD3jpLhB7S1m6W4SLdt8YvpT56IpkYbhVrbhbqKmc2gUIcqDxIie7uqLrCtfHunu2AUuuOBfTUGAi4L04HGMwlopAZzqJ/rVqDq6A==;
 31:sTaTpI9P909sJdfc/b68lJGJcOC4gP/7zUZwV3WMOdQB9WA78xa8199IKP0+Y039afgXFvP/uuSuZZxOXQcubSrRGdfHDqxNMwaJ5EWf26CbkACFgE6xy+qod2DVf4YO5y8h9tVYDPuHyJrxLlSYAT63JWsu7thlLH9ukz3lirtNBawVPbBrr3T+VbU8P85pcjbcXwnkSE9F58NCcsH4Ygp8ulwKmSheIleJ+NShXfg=
X-MS-TrafficTypeDiagnostic: CY4PR07MB3461:
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461;
 20:oqDfLnAtrHlOfWT0RDv4E6N6D7nqxrOB9C1ndC3RAmHgIJItP7g9vBQiRU4BLaX+wVCNWRQbiJIz8Js3KeiqQLD9jRHd8aU78a+jb+EGxBG8JMMNXPh8Mn5j5ncEuFhjy0WaxI9fPFpFDdeKLhPUN5/YfxJLOj4akq3giv+TX6QeuctnDKkp34kbLOpIc8k1Nj465cSS3PCPzQnIccF3FF5VqK7So02X9hzE3UfFoYAf5dKVBnuLVL0jVYthaHsV655zwOv0zpeDdSD2M7Fz2okdYWqG6SI6LFtUdHmwvRNQBT6+YNhO16J1hnE9pmSgXtKbRqwNSOWHRuN2iEI6DOWvpNJ2je7nHc0EqO5hKU9E5RsR+jmhCo8uk+PTshN+rbNCON8RCFQ+qXBrevZo7POKvWel/3zRYaERb8w8LfSpQm/Gi67jGy/iYnV7tnkNJmcVi8Jp6vdowfDHHCMntyMRNPW9dxqimTIqJgS7/58Lio6eKxYDD30BGe5elQe/pUGLTpOBGFZQ/wsYC8SSewLRShnjjrxGpDIz+DP3cbxXCIMhTwI6hovCS4LAXJ+/iW+DLBpUaa/h3/ESCRAWY96GMupkeUyVw7f6yzcOTso=;
 4:5vWwAT3zzLI0bntnGVLFHP+gDGEkwycMn17l/zZOcYXNkRciUJ8Q/sE6U/0w07FVdlq3q+SAh9z+qhvpiEF5zkbcQ0U+9yoa3KYo2FZ5uyP3dW1zNFKBTywwBDAJruWRqRuYn1RFq/5A07f+nUbww1pB+e0Lw1OkHUcSFAWw0D7satqazX0FL6fauBsWi7wb3XEQFjMtmWI3Qxf8sBaHnqwa+Yo+W8ZT3ChhGDGZ56Yfvwckjc0Bj1ZM+kxV45mIrMFN6/b54zCqOgNJoNi/rQ==
X-Microsoft-Antispam-PRVS: <CY4PR07MB3461B6AC6861C04148BD590E80230@CY4PR07MB3461.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(10201501046)(3231022)(6041248)(20161123560025)(20161123562025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);
 SRVR:CY4PR07MB3461; BCL:0; PCL:0;
 RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);
 SRVR:CY4PR07MB3461; 
X-Forefront-PRVS: 049897979A
X-Forefront-Antispam-Report: SFV:NSPM;
 SFS:(10009020)(6009001)(376002)(346002)(24454002)(199003)(189002)(5660300001)(6496006)(305945005)(229853002)(58126008)(33716001)(6666003)(55016002)(42882006)(2950100002)(7736002)(106356001)(83506002)(93886005)(105586002)(9686003)(189998001)(16586007)(478600001)(316002)(8936002)(81156014)(81166006)(6116002)(3846002)(1076002)(8676002)(47776003)(72206003)(2906002)(5009440100003)(25786009)(33646002)(97736004)(6246003)(23726003)(101416001)(66066001)(54356999)(53936002)(4326008)(50986999)(16526018)(50466002)(68736007)(76176999)(107986001);
 DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3461; H:Pavan-LT; FPR:; SPF:None;
 PTR:InfoNoRecords; A:1; MX:1; LANG:en; 
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3461;
 23:iQAHH5dAf2dx5pimLq2ds2bRs5AFpdpQIjQMrtNLv?=
 =?us-ascii?Q?iSrFxvXnG6ATnDeXYhwM6IiZ2EmDqZwWXoJddjkaPEl67SheRVNF4Usz55FU?=
 =?us-ascii?Q?qGtJ83yDAxzhoczmhoGYoQAaFkySHlM9E4jhTRG5BgwppNsdD92i/6KEBA7n?=
 =?us-ascii?Q?5X6jedA8i2P2EBFdsj3/5PVgfRolPidGlwWTFKMrOnTsnM9f78xnJCJg2byr?=
 =?us-ascii?Q?SDgUZaMRP4OprlQmVhXSQPD+2E73UNg0wnRZiMeJwoTSrEj6hMLhJBE3VrBq?=
 =?us-ascii?Q?kPXc1DhbKrCfvIq4HWCPibPRcxSwxkiMek+lwYxXBX3/a5AUGD/HrTiRRpVs?=
 =?us-ascii?Q?jBHglN2aYMGnzlTard7EYEV2PBkrtaG9hF5WvyVpD/4NxlWk8mLVATHx+zMv?=
 =?us-ascii?Q?101qnqvXvAUT2RmY3bE7C/1+ngT7KtOO/ZzR5A+8/RaqpjSp9ihQG+gxER6P?=
 =?us-ascii?Q?NqWHT0pAx+AAuTclWZ9ZSbmSlLBxxZ1RR/fBvZ9domGYCvmpn8KzJTIrqNwW?=
 =?us-ascii?Q?1ysYciCf5CuIFXGHbZ21AQowKLngh7I1r/watf1KYjrGM/wBpwcgPCoZSd4D?=
 =?us-ascii?Q?DZvIAweQoAJn9oS2V04aPvag1pf7HQgIr15wq0hviLhCwGEksNIzswjuj1R9?=
 =?us-ascii?Q?YS/a44imlPYApuDqgv1i8YvDd606czGpeLrqS3TYTAOxGgIiNsODncra/Cmk?=
 =?us-ascii?Q?mQAkmrhL/jGqoBaSWt41HuxPXy+SZ/SB7z1afeNEdCGQH9TpCipzsYPCpwMJ?=
 =?us-ascii?Q?F+ZgRqYZ7RcR+HWWDiNETin7vVbrSyNj9e57nE47lgMvspAT12Ogi0+ZlfnD?=
 =?us-ascii?Q?hd8735gTE9NIPzu9BXt9IllIYG7hwRpphbRTW0wzA3BkKdjxEtuRsFy8EAR1?=
 =?us-ascii?Q?xWb/iuGxqeq/G9rBl13POoazTrJ998jTfz3l9mfwcqcSNEYj8wfWafeV+YQF?=
 =?us-ascii?Q?a1WERyLoJ4Ke6uSTOxsEOlPYvXFE1pVc8iRiqqKwGOY6k/GG66MHnMeRQRmK?=
 =?us-ascii?Q?X0bZiPF+1rwfvSVidwui0grzDKKfl0eDW1ng34rbAhzxKHioQtZPeqlJyYvu?=
 =?us-ascii?Q?wzXe6W4C3merfBQjqvU6zi+E7K+eaRZjrTB0T4MwcM1MdGK43Ezo7GvstpRb?=
 =?us-ascii?Q?ZNwr5e8TvV5ChJPdcctCTFBK/no2ZyvbWN9qf6Rgw+HhzYsfdz+q8vlGl7A8?=
 =?us-ascii?Q?I4EJF4NXnSImQA+UcXBNO14yf2R2r5wvCLc9jm2WQTh1JNr9o1C0qRLfg=3D?=
 =?us-ascii?Q?=3D?=
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3461;
 6:0IjhbBSggL1XJe4ySQoBO63tVElOgZE6KerRcFgAN56DdMo2mnJ6VYnuy4sVwK7w5l0bs1BFBSSbWFP0F3fWYPRnJrW+NkXsi2ODNFCj9sPiNklV5hZEPeshcZV6eeeK20X1XqrE2/uBVSUc/hwUK2ZcnfKOLqcnVLuu8f1sj2XygAVOD7pICbIdlmZDRFwo3SRIWtO6mXDtUcnejYrfIWSFqejt3rRsivuW0DdDllyfePy8MXvJJVqBHFIRrrpgtVOLssZhHRLoyF2UWxvkQKFVdHt312dL77BhAecHElwA4f5Oeu67Ra7Snw8CVFenoeFSlroF0G3OS0lZ6AepzCzp1TIm21s+/kmWRrtX0Bk=;
 5:gz8uJjrXYNgXpv+9l/FyFCdNDJQxw1fXqM9IbktoBrI8fBV+p1HlPABZOAaNhcwRq97LvLYdqkMi+X56F+UUNtXD697j+0Zyv492k2qnk4GOMCD3q1mdnAXtVuQxxjfu/A/ULTsthwov9PKu23FARDvy6jm6AfSl6gJCqkhbYdE=;
 24:KmI8v5xcmT+qlZVjeSdO3CcJ4slTybohPo+XM3aPup1E3nw7AvsIzflNUq63Nz4fk7T5ZRTL26ncD2eBVSjpDlJX1m2u1/9KlkpL2nu6EPk=;
 7:BULhBMWihl2273WD9QsbQl0PqtO4SnHQv35T0PFVRviJzpQNhaYnHcVr0RjC6cpjnszHRXR+93EyWmN7Y4auq0E0q/bv4iuH4po5+dg/D/SGHqACBGU3Rgo9PHP3G5RIEZkhvcIuZ7wh2NLZ6EqHKCXCSlorxNe4rPQF34TY6FuQ0mCnAnWdtREkUIEOGwqJDLVqhZG+ZGUOmytraA11Fdqq4lAoXOQMPxBzm9A91BGaqf3juMvjcqfcy0abv9QZ
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2017 14:05:09.2755 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 48b15f1c-c45b-4309-402c-08d530e8e113
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3461
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Nov 2017 14:05:13 -0000

On Tue, Nov 21, 2017 at 02:30:48PM +0100, Thomas Monjalon wrote:
> 21/11/2017 12:14, Pavan Nikhilesh Bhagavatula:
> > On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote:
> > > 20/11/2017 19:40, Ferruh Yigit:
<snip>
> >
> > I will be sending out the patch set soon.
>
> These are only the legacy static log types.
> Are you sure you want to change them?
> They should be removed when using dynamic logging.

Actually this same struct is used for registering dynamic logs for legacy
modules currently,

/* register legacy log types */
for (i = 0; i < RTE_DIM(logtype_strings); i++)
	__rte_log_register(logtype_strings[i].logtype,
		logtype_strings[i].log_id);

I have just prefixed them with "lib.". If we remove this form here then each
module has to use constructor style initialisation for logs which would be a
lot of rework.