From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 971F5223 for ; Thu, 23 Nov 2017 10:39:57 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id x63so15154960wmf.4 for ; Thu, 23 Nov 2017 01:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=STpMAR3lF2XVnd4fAX4mpvA75vROCRW1YjJKPAEj1Cg=; b=KbjglqXb3PNJcpMj5OKigFU3J3A2H27nl+4yKRVc67SoZJzEmxPc45SuzBxiAS9E05 BkFuGtdFckCX0x4/8Wjcw8Uxwd1TqBt4PR1CW/vwMcLbL/PlzlqaWFhGcEDuAPBg3SB5 G1zeNdWe+hxEHVuVrjvPFb0CiR5lmkIkPTKbLKBiEsnFKTnOO68hpiHjxpIspnGKVd7X bckbTZhmiv4oghSqVWN2dFxzEHsaQTcY66C2QqtNahUFh5cgdNCpjV01pTdi7drby9AT zkgxJKef5fmhSAPBEVQ0T2WjykxwnWuzJffvU1+jR28KBpFVfe3CS1hh+20MtVOGitVl F3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=STpMAR3lF2XVnd4fAX4mpvA75vROCRW1YjJKPAEj1Cg=; b=aOSeEimOTTG4jP2aqmhent6Dw9ruMKp4f6wfSb+tCgeLVJK/56GzCGE9NR7p0jm+9c wqTviUcVfluHIRA93GaaZzWmv9FdTuw6JlDRzOok1gC7szX3jRU6EymDNV9eQu34RGF3 b/Vpq0zMmDm9xKklg0fBb2qMWcoTGVrKFzBf2F6CDoh5KVCuOWYzrtH/okFwPvcsUgpo GjwxH/vJIyyyaF/S3MctGX1L1C111ZIJTHJmf7tytu+CKiMsXvp5Bual4QmsavRa72+L Vf5zO0aQrfRoUaEc787R4ADVXnSnBOoje1Byg/j6HoPKS/8ykv1pHwn9Dm+ogeY5spRt tx7A== X-Gm-Message-State: AJaThX7+eOs7AkQYsco5IHLSOL3f6V0xPPp5A+bjtnvfCWJTXgQjzvja ZK357LHpgj0VcWQg16uitKXv7Q== X-Google-Smtp-Source: AGs4zMbi1PSbWnwfuuMYizh+ryX/Xzq33H8V9h8gulOBYLX/7ZSCMe0pBLjJCqmeD+84j9HAlP+bEA== X-Received: by 10.28.234.80 with SMTP id i77mr5896093wmh.76.1511429997353; Thu, 23 Nov 2017 01:39:57 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x142sm5246312wme.34.2017.11.23.01.39.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2017 01:39:56 -0800 (PST) Date: Thu, 23 Nov 2017 10:39:44 +0100 From: Adrien Mazarguil To: Andrew Rybchenko Cc: dev@dpdk.org, Jingjing Wu Message-ID: <20171123093944.GG4062@6wind.com> References: <1511166121-743-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511166121-743-1-git-send-email-arybchenko@solarflare.com> Subject: Re: [dpdk-dev] [PATCH 0/2] ethdev: add GENEVE to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 09:39:57 -0000 Hi Andrew, On Mon, Nov 20, 2017 at 08:21:59AM +0000, Andrew Rybchenko wrote: > enum rte_flow_item_type states that items matching protocol headers > must be stacked in the same order as the protocol layers to match. > As the result the patch changes ABI since Geneve is added just after > VXLAN (the closest protocol). > > In fact as far as I can see many items do not follow the requirement > already. May be the comment/requirement should be removed and GENEVE > should be added at the end of the list. If so, should be keep it just > after VXLAN in all other places or move after ESP as well? Perhaps documentation is unclear, this requirement only applies to applications when constructing patterns out of those items (e.g. to make sense, TCP is supposed to come after IPv4, not before). New item/action definitions must obviously be added at the end of both lists to avoid ABI breakage, there is no specific order to follow other than that. What may have confused you is most of them are apparently ordered by protocol layer, that's because those are here from day one; it's not the case anymore starting with E_TAG, which was added much later. Besides addressing the ABI breakage, I don't see any issue with adding GENEVE to rte_flow, I only have a few more comments on subsequent patches in the series. Otherwise good job, looks like you didn't miss anything. -- Adrien Mazarguil 6WIND