From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0061.outbound.protection.outlook.com [104.47.2.61]) by dpdk.org (Postfix) with ESMTP id 592902B83 for ; Thu, 23 Nov 2017 13:08:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SSFkXJ1lP59b7MoOYOGdqBXG5IRiUbJVOfD80HgzPzM=; b=N8rKxXRESjZY/0y7LCmkMStGwJ31PhIv8Gb0Wf7/6CDDRsf2tt0OuEtBbnbrQyXjT2ohuSnWvu/j0YsPNm0RRDAJo0ZgiQ4if53b5eVsKmMzYgGNH3iQmQNe8Tjc5fqPcU1fgh6o7HgvH8nKapYMMF9myu/+sIbj8x+10yyoSL8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by DB6PR05MB3144.eurprd05.prod.outlook.com (2603:10a6:6:1a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Thu, 23 Nov 2017 12:08:25 +0000 From: Shahaf Shuler To: jingjing.wu@intel.com Cc: dev@dpdk.org Date: Thu, 23 Nov 2017 14:08:01 +0200 Message-Id: <20171123120804.143897-3-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171123120804.143897-1-shahafs@mellanox.com> References: <20171123120804.143897-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: AM5PR0601CA0033.eurprd06.prod.outlook.com (2603:10a6:203:68::19) To DB6PR05MB3144.eurprd05.prod.outlook.com (2603:10a6:6:1a::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: bf9b8a05-7e84-482c-f0f1-08d5326ae6cf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600025)(4604075)(2017052603258); SRVR:DB6PR05MB3144; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 3:rlqNL4leXiPa04Ovrvs9KKD0dT+wHUeTx+bEe9Hil05xTtNt8bgQgNVG/e2J7kBrOkUFLNiowcIw+PdmC2HAmjNY1oKNexpkXttegz21eZI7V4hw+5alywrsN0zACT4ytQ2J90ySMwdlpXiLQyZidgdngiwKzQFvQFnDVR8BFXz3bGput5S1h32WHN8c0kMJBmO1rbpf6XbmtDZ+r2dUS6YEKwpu0R5V8JY7b22dzkOWxSnUda0HSeGW9nnga1CG; 25:nZw4zgMGnIICXYlOPLDMZK1oHjSC8Y3hPMbSSOcwA7qcaWbU5cLvDNP39RO+gPmxAI2auUn40qosQu2KnzJMgnXysXYehZkOzC+DNDy4QWkIi0eUcKDWpmBZdZB3yvfA+ghwJRTRgGwHf40mMYskDI0RA1PIZfF9ExkbUJLdswzKYrpK3+fm4EJIyS8TgxexrgQlGYJpQufK6y9eIxxdX9doHjz+QJE76ocMVrVsMnjeubemBeXUD7c0OKF3AEOHEqoHyYiPYJotLsJWDst7bHpdnr/Hp15r5tesi9uPPVb0qCJH3Zm4LjsmAqCfGXaXBLHlHU/Hjh4Y86uCnUY0gVv1Hmd5XbU57QQBMRSseek=; 31:1oq1wpFIdm8kPtlYsA8ElAp1ywC2cFm+CbKnONG/R2L7JCmC5gJQNvo34r+50ANDAuFM3GhSpjTaVqobngTeYWLawj5jZNnH2X2sy2+8d0X62cU2Kw+y5NBIWBQxG+seKSygae4vZf1KD2KD1ClZ9Cz4v4ew1jqdnPvqHJBh4DgKNFMIFWcihBK6oDDnjABKJ5daRNFy6zu89689cYo7txe/bLVOZGEEYOGdLmA4UoA= X-MS-TrafficTypeDiagnostic: DB6PR05MB3144: X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 20:39t30+82jbkPOmtYeZp50jFtLNtRts0ZF+g853tIdX8gn8Qrzt83k5J8zBHGDQlwlGjyQi43jDUdTeMhS2McnaYX9ummolLwnQHPBOJwK1/Qe7GXtVuyG+oKzfroi9DBEVg/+dNG3vMOxkLoOYag8EKWZUTmTKceRzdzihd8UY5C1IKLfQfyBq4vPCwmjdIyWU/hf+zZzui7t1SBofSZNa81/f6JzUWqxU3y+gdO1PKZeaKEaN9ZTS0yx3X3I8BsZI80K/KqXMwk2HnBMrsqutTdSlHGMNuzM1TYxtW+BquNFv5/yRIqQT+x2K/wLvduJtAJGVw15MXNzIcMnN57UpaFO524bYwYOM0BQO0mi8SZtKHZ2BzVGgXrSMIEs8XNTRmipPpjrNu/DMYs1vOlOIJSbBTuYgG24q8SWIS3VsaeffPmlus04Zy0YmrcSGxAXP4hEG9P7vdl6NAzWhhxnkZpaifzQuOiX2sX8LQXdNqzwX5grBHOORbHCiSxEmbf; 4:I3CGXki1WkNdYKwAJ6D9dGJu5Kjsv/ucovkdNPRHI6aav/o06isiaUbgC1p5srQwr/rKRXUF78fmZI52ixnwUeFu1aKlPMs2IdBbCoDdlzszTUsISOHYRm+Ji+4lU/Ce9cweOcxCSZ/BjTywoFExJ6MW6AzqeKXwecuViOtqvI8nQh5K3sceTK4fiJGWq7SYM4bpEcBaBhU7B26hTzvBX/RsTCSSmtZZfdO6rfU90DBOE9AJHo7i0BN/mjPyMXijjzdB47wffvMIyWjvmylACw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3231022)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR05MB3144; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR05MB3144; X-Forefront-PRVS: 05009853EF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(6009001)(39860400002)(346002)(366004)(376002)(199003)(189002)(6666003)(478600001)(8936002)(2361001)(50226002)(4326008)(106356001)(50986999)(76176999)(2351001)(33646002)(68736007)(5660300001)(189998001)(101416001)(36756003)(48376002)(6916009)(2950100002)(21086003)(50466002)(105586002)(16586007)(33026002)(25786009)(86362001)(575784001)(66066001)(97736004)(2906002)(316002)(53936002)(47776003)(5003940100001)(16526018)(69596002)(55016002)(1076002)(6116002)(7736002)(3846002)(52116002)(305945005)(81156014)(81166006)(8676002)(129583001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3144; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3144; 23:QzzcN2ne968qxzWI/JA5U6QWFaU2PbqdJN8TpJcyP?= =?us-ascii?Q?xaRink75JhWUb2VA7z5zQ/GVb0Vq1wfUZLviCXJMPONlkG+RGD76SVOGThcN?= =?us-ascii?Q?SMorsoe13DrS6vcM9wTthIvggBym93fOAVCQ4k706vTUe6PIronhPWVlq2yP?= =?us-ascii?Q?71wffmIJvEdmw7UGvr1tzgosoChDl4dgTMwJLWJhEe5bkSWFVwuuIUt41pmw?= =?us-ascii?Q?wtnDRjR7bFWEWsO8NAFCbuT5tzMcWwqmtDsqfvuyrL694SJU5rrZoyDKZfK4?= =?us-ascii?Q?SfaRmuyxtWDovjRn2L+nc+jRRe2EW1UfHofsrI3lQO4UWGUn2TNeaT5wM5Wx?= =?us-ascii?Q?RpbPNYxfPMowctSSONYmAdEXvcK913ZgHfdOr5kU8duOUwOL9aHwJcq61SB5?= =?us-ascii?Q?j3fNp6X1EX/rtgC3EQFdn/HKpoSKOJM3GVJXJF+UgsbjsdgjGtmxKxm3tNEH?= =?us-ascii?Q?Mg9GuCnJIHcdZAoHS9dVJK83dz7hY1d6fT+Nq/7uA90Rd1myHnTQRFexVHQz?= =?us-ascii?Q?sG2Jovf/6UiDGGgBUGBKG11zKrAhbA9hBRaQ1inyXnP64mC9G8n3ATfOFcgK?= =?us-ascii?Q?YrXwXzUElvRAVycqAeqnm78Qsd6hGq9ed1AHRljxfdqrnfQhC2AI+Ha80g5l?= =?us-ascii?Q?oDmG2LOOfWtKjV52EsjljTpqaSEr8BeKehwoLl0NkgvxmpFqhRH2k0HDkAVL?= =?us-ascii?Q?h075K3FTC+YEIrJpqmW6NcnuvgiS1HBt12M7h5rbN/UzBJGqsWd3kJIHPER9?= =?us-ascii?Q?6thZBaQD9NOaY01zv0c9tENvdPVaJZaokcqYWu9urTgYBGUsLZDTskHxbgim?= =?us-ascii?Q?BfI6vTiTr4GnsO/Pw0l20QtJha/FQtAlNZDL2q6+qWR6G3zTxRvXhrRh0LRk?= =?us-ascii?Q?8RZQw/P6BTqoAu2vqxQcWf27F9GRU+pdN1uMZM+iABCTszv6XXIhxYpVHvx9?= =?us-ascii?Q?REjR9YtAQ82EK9V5olDOxIB9XE/re6tSL4slzB6zoGB35N+EMStfOsFw3qnj?= =?us-ascii?Q?pYMVVya7pi/wE6gDCzrbaDpLI4J6fwg++5Z9flier+o9/6GTrWijo6bK9idz?= =?us-ascii?Q?/p8NL0wUorwPJokcH8OSDSAC3carLHAXalnaXPeZpQ1JvcoPnMWnB9zktF45?= =?us-ascii?Q?HmWZUcsC5V8QnIHKKZINmXIA1/wQlWVpz+cwq3RM7aApd7mT9Kb5zexvoZ/3?= =?us-ascii?Q?wdSG/zuynyLocuHadAIwVjt1+lI1PhieOU3vKvFHd99HFdoHTDBwPXTefmPY?= =?us-ascii?Q?1hZRFDTx2DE8UfDvn8WsH9mVbo36AmT5XMlv75JaPJABm8zK2XuhsN5nu2O+?= =?us-ascii?Q?FeyUsv5AuX3IfuZkGXUhE23mA8U0BGIBdDnT7DqAmedhdDDbNFL5Kv3BP/fn?= =?us-ascii?Q?GNZQA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3144; 6:HB7xpe1QhPHjZAtI9UQu/Qmq+yijg05aQpgjQ4sCVwV9jC/vqjq2V4AjM08wbCf5NGhcNpaYa/wNR2vn3UYkW2Ic1p88T3ceCL6EOh07145ekAIQhxi3vqxCU1DvEqpBZ11jNWbmnrGVm+9ahHZxfiUN35fVdhO4d89w+Phrcmjln+x2+J1jK0EuszfNEqaKH+CEypi86zJJmmilbXPpmwosRyRS9vQlfqkvutcw6gha7vIZk5PLvJqJ/e6Rbk/bsMME28SAmgXxyC2lYzAD88YKHe+mjnzYkF8rtgln8MPwdc00Q/a2nTWacVlT93Obu3Lg/0YxWdnUhSuF+Pc/DCg4TSNkE+8BPM+e48ORZZs=; 5:Q5k59NweNBRpowEJBwjg9lqLMRVeFl1rGprszJ4FFYcPB3W16nLxXHpq63JAIfVYGxAuCOQi+Ba3y5sRZlqZKIzgBMKdM/qpxF0+BcZpbdwkSeqzaOYt9pxYYSU9RZAz4eQhvV2AXIGxyUk6Azk1f/WBhTySEFuBSrVbtO4UYzo=; 24:hWAfocfFDiPAyq5VwcX91UuxwCZFgmj97/XzfZH8llWAiDtZ2CCsnse2pQM+++r/FV2d3lNkzgDHlH4UWLi1E7dsLPXVd7A2AnsvjY0U0Z8=; 7:T21KLScjk7mZUjACl6oFtxf651G25W/Pk38vrR7snuqi59aHNr7dDuh9zVxZTiGo40lZtNEk0tvLjMfG9MIbGkdxtrRf3QJpvYanRHzj/0WHda5H6JbGTZk17P5nh7MmQXOk/0jTMWRt4k38EAfG5oHZi63pC8vm4tSjLJk30nuLhE1IWLPik7lVV+p0ZdwMR5OlAkTrynbPk68DKWmh8aWs5/mjc8vanlliZhwfjY4pZk8ldAQL/FEf6Jwvc40i SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2017 12:08:25.8571 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf9b8a05-7e84-482c-f0f1-08d5326ae6cf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3144 Subject: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 12:08:27 -0000 Since testpmd is now using the new Ethdev offloads API there is no need for the txqflags configuration. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- app/test-pmd/cmdline.c | 69 ------------------------ app/test-pmd/config.c | 4 +- app/test-pmd/parameters.c | 14 +---- app/test-pmd/testpmd.c | 8 --- app/test-pmd/testpmd.h | 1 - doc/guides/testpmd_app_ug/run_app.rst | 12 ----- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 ---- 7 files changed, 2 insertions(+), 117 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b0f2325c8..9e3f02ec5 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3092,74 +3092,6 @@ cmdline_parse_inst_t cmd_set_txsplit = { }, }; -/* *** CONFIG TX QUEUE FLAGS *** */ - -struct cmd_config_txqflags_result { - cmdline_fixed_string_t port; - cmdline_fixed_string_t config; - cmdline_fixed_string_t all; - cmdline_fixed_string_t what; - int32_t hexvalue; -}; - -static void cmd_config_txqflags_parsed(void *parsed_result, - __attribute__((unused)) struct cmdline *cl, - __attribute__((unused)) void *data) -{ - struct cmd_config_txqflags_result *res = parsed_result; - - if (!all_ports_stopped()) { - printf("Please stop all ports first\n"); - return; - } - - if (strcmp(res->what, "txqflags")) { - printf("Unknown parameter\n"); - return; - } - - if (res->hexvalue >= 0) { - txq_flags = res->hexvalue; - } else { - printf("txqflags must be >= 0\n"); - return; - } - - init_port_config(); - - cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1); -} - -cmdline_parse_token_string_t cmd_config_txqflags_port = - TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, port, - "port"); -cmdline_parse_token_string_t cmd_config_txqflags_config = - TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, config, - "config"); -cmdline_parse_token_string_t cmd_config_txqflags_all = - TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, all, - "all"); -cmdline_parse_token_string_t cmd_config_txqflags_what = - TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, what, - "txqflags"); -cmdline_parse_token_num_t cmd_config_txqflags_value = - TOKEN_NUM_INITIALIZER(struct cmd_config_txqflags_result, - hexvalue, INT32); - -cmdline_parse_inst_t cmd_config_txqflags = { - .f = cmd_config_txqflags_parsed, - .data = NULL, - .help_str = "port config all txqflags ", - .tokens = { - (void *)&cmd_config_txqflags_port, - (void *)&cmd_config_txqflags_config, - (void *)&cmd_config_txqflags_all, - (void *)&cmd_config_txqflags_what, - (void *)&cmd_config_txqflags_value, - NULL, - }, -}; - /* *** ADD/REMOVE ALL VLAN IDENTIFIERS TO/FROM A PORT VLAN RX FILTER *** */ struct cmd_rx_vlan_filter_all_result { cmdline_fixed_string_t rx_vlan; @@ -15729,7 +15661,6 @@ cmdline_parse_ctx_t main_ctx[] = { (cmdline_parse_inst_t *)&cmd_config_rx_mode_flag, (cmdline_parse_inst_t *)&cmd_config_rss, (cmdline_parse_inst_t *)&cmd_config_rxtx_queue, - (cmdline_parse_inst_t *)&cmd_config_txqflags, (cmdline_parse_inst_t *)&cmd_config_rss_reta, (cmdline_parse_inst_t *)&cmd_showport_reta, (cmdline_parse_inst_t *)&cmd_config_burst, diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 9b6ffeca9..089e9f4cf 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -417,7 +417,6 @@ tx_queue_infos_display(portid_t port_id, uint16_t queue_id) printf("\nTX writeback threshold: %hhu", qinfo.conf.tx_thresh.wthresh); printf("\nTX RS threshold: %hu", qinfo.conf.tx_rs_thresh); printf("\nTX free threshold: %hu", qinfo.conf.tx_free_thresh); - printf("\nTX flags: %#x", qinfo.conf.txq_flags); printf("\nTX deferred start: %s", (qinfo.conf.tx_deferred_start != 0) ? "on" : "off"); printf("\nNumber of TXDs: %hu", qinfo.nb_desc); @@ -1702,8 +1701,7 @@ rxtx_config_display(void) printf(" TX threshold registers: pthresh=%d hthresh=%d wthresh=%d\n", tx_conf->tx_thresh.pthresh, tx_conf->tx_thresh.hthresh, tx_conf->tx_thresh.wthresh); - printf(" TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n", - tx_conf->tx_rs_thresh, tx_conf->txq_flags); + printf(" TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh); } void diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 0ba73cad5..1a145c387 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -99,7 +99,7 @@ usage(char* progname) "--rss-ip | --rss-udp | " "--rxpt= | --rxht= | --rxwt= | --rxfreet= | " "--txpt= | --txht= | --txwt= | --txfreet= | " - "--txrst= | --txqflags= ]\n", + "--txrst= ]\n", progname); #ifdef RTE_LIBRTE_CMDLINE printf(" --interactive: run in interactive mode.\n"); @@ -192,8 +192,6 @@ usage(char* progname) "(0 <= N <= value of txd).\n"); printf(" --txrst=N: set the transmit RS bit threshold of TX rings to N " "(0 <= N <= value of txd).\n"); - printf(" --txqflags=0xXXXXXXXX: hexadecimal bitmask of TX queue flags " - "(0 <= N <= 0x7FFFFFFF).\n"); printf(" --tx-queue-stats-mapping=(port,queue,mapping)[,(port,queue,mapping]: " "tx queues statistics counters mapping " "(0 <= mapping <= %d).\n", RTE_ETHDEV_QUEUE_STAT_CNTRS - 1); @@ -630,7 +628,6 @@ launch_args_parse(int argc, char** argv) { "txwt", 1, 0, 0 }, { "txfreet", 1, 0, 0 }, { "txrst", 1, 0, 0 }, - { "txqflags", 1, 0, 0 }, { "rxpt", 1, 0, 0 }, { "rxht", 1, 0, 0 }, { "rxwt", 1, 0, 0 }, @@ -1004,15 +1001,6 @@ launch_args_parse(int argc, char** argv) else rte_exit(EXIT_FAILURE, "txrst must be >= 0\n"); } - if (!strcmp(lgopts[opt_idx].name, "txqflags")) { - char *end = NULL; - n = strtoul(optarg, &end, 16); - if (n >= 0) - txq_flags = (int32_t)n; - else - rte_exit(EXIT_FAILURE, - "txqflags must be >= 0\n"); - } if (!strcmp(lgopts[opt_idx].name, "rxd")) { n = atoi(optarg); if (n > 0) { diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index e3a7c26b8..a97edcadd 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -259,11 +259,6 @@ int16_t tx_free_thresh = RTE_PMD_PARAM_UNSET; int16_t tx_rs_thresh = RTE_PMD_PARAM_UNSET; /* - * Configurable value of TX queue flags. - */ -int32_t txq_flags = RTE_PMD_PARAM_UNSET; - -/* * Receive Side Scaling (RSS) configuration. */ uint64_t rss_hf = ETH_RSS_IP; /* RSS IP by default. */ @@ -2072,9 +2067,6 @@ rxtx_port_config(struct rte_port *port) if (tx_free_thresh != RTE_PMD_PARAM_UNSET) port->tx_conf.tx_free_thresh = tx_free_thresh; - - if (txq_flags != RTE_PMD_PARAM_UNSET) - port->tx_conf.txq_flags = txq_flags; } void diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 1639d27e7..6af70e02a 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -427,7 +427,6 @@ extern int16_t rx_free_thresh; extern int8_t rx_drop_en; extern int16_t tx_free_thresh; extern int16_t tx_rs_thresh; -extern int32_t txq_flags; extern uint8_t dcb_config; extern uint8_t dcb_test; diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index 4c0d2cede..cb94582b9 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guides/testpmd_app_ug/run_app.rst @@ -447,18 +447,6 @@ The commandline options are: Set the transmit RS bit threshold of TX rings to N, where 0 <= N <= value of ``--txd``. The default value is 0. -* ``--txqflags=0xXXXXXXXX`` - - Set the hexadecimal bitmask of TX queue flags, where 0 <= N <= 0x7FFFFFFF. - The default value is 0. - - .. note:: - - When using hardware offload functions such as vlan or checksum - add ``txqflags=0`` to force the full-featured TX code path. - In some PMDs this may already be the default. - - * ``--rx-queue-stats-mapping=(port,queue,mapping)[,(port,queue,mapping)]`` Set the RX queues statistics counters mapping 0 <= mapping <= 15. diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 9789139af..8e73519a4 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -354,8 +354,6 @@ The available information categories are: also modify the default hierarchy or specify the new hierarchy through CLI for implementing QoS scheduler. Requires ``CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y`` ``CONFIG_RTE_LIBRTE_SCHED=y``. -Note: TX timestamping is only available in the "Full Featured" TX path. To force ``testpmd`` into this mode set ``--txqflags=0``. - Example:: testpmd> set fwd rxonly @@ -1681,15 +1679,6 @@ RX scatter mode is off by default. The ``on`` option is equivalent to the ``--enable-scatter`` command-line option. -port config - TX queue flags -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - -Set a hexadecimal bitmap of TX queue flags for all ports:: - - testpmd> port config all txqflags value - -This command is equivalent to the ``--txqflags`` command-line option. - port config - RX Checksum ~~~~~~~~~~~~~~~~~~~~~~~~~ -- 2.12.0