From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 3EE74235 for ; Fri, 24 Nov 2017 13:07:41 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id r68so22181925wmr.3 for ; Fri, 24 Nov 2017 04:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8HCMPFvsareKDP7DVyBoITc0jM3CcG6E4vaEgZQWNdc=; b=jcpBDgb+yEaVFrKqVwE6eRqrv0IRTnvp5mZqbWaWDBwWuMEDwQCFPx8vQ/G25iqY5+ BVcQ2GqMWek5LQ49qFSGjZXbOnTA39DriWFUIFKUrVSmZoaUbPr/nIp5nQF7q+OnIORd j0B32ciTUZvLdwcX7EYZKdH3ToKxMX8Tp1qsKZNi2WGehi6xvJ/YLvSX4U+H18hYHgqU ST++pzEVce4ej7Tfl7Smf9PXD4Rrqn0R7HCEkMdmxMZWN3oxdjVCWq9peC9m+pwXxGzi wMDOc4bwLn8CU3MDv4Wl3AsU3TwJ7uMNynRp4VhmbY2pCVwNtndH9BTaWoYxcNh93fnS 464A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8HCMPFvsareKDP7DVyBoITc0jM3CcG6E4vaEgZQWNdc=; b=oZ9lGb0h+Xuo4m2YnG0ydzfJsbuYPSUlv/GPnZ8kFtJbK2YZyU8/nHpKafoDUo3rvt objNNjal1kBJ+d9SLajUo0Kr81T/IAoTQXc9JuCu4po22y21RlYdVry/+9FOZ/183jec p5fw16Onm6h/lN1Y9m7nj/u5A8Af9TqeShrpsz4IYE6oczbdutHnecpzc7+bEBriPmBO No1Znt7pG81Ou4yDkVo1Pz6uEo7gEbh+9fS5P9qwY+tiCzBy2f1LQcQ/Oqe1J9SR6wce 6fRn2wg3iUDg0irgOYQ56TvUUva15kwkTYPKLCz19lhSRMsmrsAxYXoaI4SuyS1LBIdr Qatg== X-Gm-Message-State: AJaThX6laBU09wRibj2DwgTKqJF0ZBxn5qCNOH6xDd/+LiQjM2FbQQEo C2qguEdkZYlpJDqBVtk41CzO X-Google-Smtp-Source: AGs4zMbCauiG6kipeWpzul4sm23POXhOwYsI4KEs9wOcM0O0/S1BU/0comy1zUhfAnkeBVuYnIC6mQ== X-Received: by 10.80.139.180 with SMTP id m49mr40806589edm.36.1511525260884; Fri, 24 Nov 2017 04:07:40 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g3sm12242323edi.66.2017.11.24.04.07.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Nov 2017 04:07:40 -0800 (PST) Date: Fri, 24 Nov 2017 13:07:29 +0100 From: Nelio Laranjeiro To: Akhil Goyal Cc: Declan Doherty , dev@dpdk.org, Gaetan Rivet , stable@dpdk.org Message-ID: <20171124120729.ily7e4c6exvkla3v@laranjeiro-vm.dev.6wind.com> References: <1c3b73f0912ad4b3da8423590dc76fc83df16b80.1511338151.git.nelio.laranjeiro@6wind.com> <5ed1354d41a6370faa8887a6f3acd1e20ef09668.1511431327.git.nelio.laranjeiro@6wind.com> <538dcacd-8d64-66b8-56dc-21339d1e8188@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <538dcacd-8d64-66b8-56dc-21339d1e8188@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 1/3] security: fix device operation type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 12:07:41 -0000 On Fri, Nov 24, 2017 at 03:03:52PM +0530, Akhil Goyal wrote: > Hi Nelio, > On 11/23/2017 3:32 PM, Nelio Laranjeiro wrote: > > Device operation pointers should be constant to avoid any modification > > while it is in use. > > > > Fixes: c261d1431bd8 ("security: introduce security API and framework") > > Cc: akhil.goyal@nxp.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Nelio Laranjeiro > > --- > > lib/librte_security/rte_security.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h > > index aa3a471a3..679c0a696 100644 > > --- a/lib/librte_security/rte_security.h > > +++ b/lib/librte_security/rte_security.h > > @@ -94,7 +94,7 @@ enum rte_security_ipsec_tunnel_type { > > struct rte_security_ctx { > > void *device; > > /**< Crypto/ethernet device attached */ > > - struct rte_security_ops *ops; > > + const struct rte_security_ops *ops; > Do we require this change for crypto ops as well. Yes, only drivers should be able to change modify this pointer. > > /**< Pointer to security ops for the device */ > > uint16_t sess_cnt; > > /**< Number of sessions attached to this context */ > > Thanks, -- Nélio Laranjeiro 6WIND