From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 542ED107A for ; Thu, 30 Nov 2017 09:16:23 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id n138so290039wmg.2 for ; Thu, 30 Nov 2017 00:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kqHA/FFV8X/h9RLPb77vH5GWJHznRvoOZDZC3hjDUDE=; b=AffyLlU8QnAe+RVmS9yOV2fm8CunGrW9A3IHyDuTIvYFAeS6mMS2wHRcVpi/wfTbxp UjuaOgGgio0SVUBGlS/I2dOjZD8JhnMS+74R/NozFmXQBqVFjMJy01sQOcBfx94BKEUA E3M987pEc5ld35I4ZR/UxBskE59PsTaSXw+QgHpVNf2faVViABXWQYYg45spXp5rmbvs lwmIbNfU+Nf66V3sZRqPMoNPOYXptMNPSYKxCuItldOY7rSsj7RFgedcAjKi2rPNH1O5 iVrxqWvPypgjE+VNgrKfcTF2RS5BOLfMO+V2kFDikzPmf3u6usQ46EpqxoCfRrz5AacM 1Wjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=kqHA/FFV8X/h9RLPb77vH5GWJHznRvoOZDZC3hjDUDE=; b=VO0wUi2ejdJs9IqyDzJ4DqLJgxM4odC+bJ5iYTNh64OFvcpzsSWeDPWEivrnLRq3Rd ckad40VUPHViQ/IbmG1gFOOSYK/L9YTvPvOTMIrfYsBpvLpf9QdemF8W8ZUHNhN9+yA0 x/s23nN4QFgg/3MTFcIdwpNiZufl1WNlVvvlAmeYDUqt8je9qIAKfp+3t4/+Ijvp0oIy 7wNUGYztlcbHyuOXzOq3xTiaGf/Pa0oRxhk+H1N8g7gIW+6GPByaqrFaoleVuDMbkFoe UTodjhQDs9FlQRlZxUflawOT2aWg58xLja6YsH9CUoBJGBR/EEaFqk1tPn2RdIhuyNDh 1+VQ== X-Gm-Message-State: AJaThX40BRwCfaLePDlYKmxa7z4oSGdkqPT3Fs9RFQLZCR5uztTgtfXd 9vyI53pfWy+ydLgOukMjHor2 X-Google-Smtp-Source: AGs4zMZ7APUZ9QCE0Hq3LBgz+JvwVqACBEZ/oj5RddPeN5VqAFCX2128mjcYN/JYo/LML8Ok9wpsSw== X-Received: by 10.80.145.195 with SMTP id h3mr12013080eda.240.1512029782805; Thu, 30 Nov 2017 00:16:22 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id j39sm3172829ede.38.2017.11.30.00.16.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 00:16:22 -0800 (PST) Date: Thu, 30 Nov 2017 09:16:24 +0100 From: Nelio Laranjeiro To: Xueming Li Cc: Adrien Mazarguil , Thomas Monjalon , dev@dpdk.org Message-ID: <20171130081624.64wc37biw5s4dgfo@laranjeiro-vm.dev.6wind.com> References: <20171129173106.120828-1-xuemingl@mellanox.com> <20171129173106.120828-2-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171129173106.120828-2-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC 1/4] ethdev: support rss level on tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 08:16:23 -0000 Hi Xueming, please see the comments below, On Thu, Nov 30, 2017 at 01:31:03AM +0800, Xueming Li wrote: > There was no RSS hash fields level definition on tunnel, implementations > default RSS on tunnel to outer or inner. Adding rss level enable users > to specifiy the tunnel level of RSS hash fields. > > 0: outer most, > 1: inner, > -1: inner most(PMD auto detection if nested tunnel specified in fields) This *inner most* is confusing, what does it mean for the following pattern vxlan / end? This pattern is valid for any level of the VXLAN according to the NIC capability. With an inner most, if the PMD support 4 levels of tunnels it will need to create the 4 rules to match the user request. Is this what you expect by this definition? There is also another question, according to the possible values (0, 1, -1), it cannot handle more than 1 level explicitly, why such limitation? > Signed-off-by: Xueming Li > --- > lib/librte_ether/rte_flow.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h > index 47c88ea..c35558c 100644 > --- a/lib/librte_ether/rte_flow.h > +++ b/lib/librte_ether/rte_flow.h > @@ -1078,6 +1078,7 @@ struct rte_flow_action_dup { > */ > struct rte_flow_action_rss { > const struct rte_eth_rss_conf *rss_conf; /**< RSS parameters. */ > + uint8_t level; /**< RSS on tunnel level, 0:outer most, -1:inner most */ > uint16_t num; /**< Number of entries in queue[]. */ > uint16_t queue[]; /**< Queues indices to use. */ > }; > -- > 1.8.3.1 > Thanks, -- Nélio Laranjeiro 6WIND