From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 7D74A2A62 for ; Thu, 30 Nov 2017 11:14:54 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id i11so11315507wmf.4 for ; Thu, 30 Nov 2017 02:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DT/7qUYdFJWVzL1nyE8RNtEiV9LWtcv9rWEHGY70FxE=; b=naAn4/m8NgoLqjcR5OqWpsbUzIvc6AwNXlSayzc6bVqlTOc6OIiy89eLtYyCR39Ph+ DxbTtERm1Vv0a5QFP1YsLSPX53vie8Ckas8u1qqrCJvKfrWQ47/THH54USzDLvZ3sF8B S4ucrVGlGs9Se9NcAA2ZbV5qpQlBmzTRB3HlViZx4UvlRp6A+DIYhjk1S4vv2sbAUzbp ccKCuYmXjmb4UjhRrfvRGFix/0AWJg8lZ9axWJEI2Pp6Fu8VdFdceUzreY9cSz/P3p+S WQ1AxK+1cAb2WO9rg4uGi1w26n1Owoi0Lfe8YTILQLdstqp8wbmrA1RV+tEdW4d+LGfA Fcxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=DT/7qUYdFJWVzL1nyE8RNtEiV9LWtcv9rWEHGY70FxE=; b=dU+w6oqSmIyCmxQ59+VPFCVsSTJPQ3VZwZQfizZiBP47DSwE0OmsJE/2uhJZeCev9P QXS45OHVZeUHEjsgEZ+qzJnxo+SKuZmzALz/jqf0LhzjPl096asDhIqg9dbYeadZqo/b Sh/Y/2wD/wWGZkjbQoMMEeTjh/x1eCar6qWkKdN2Usy9zWufPfq9cpINY4Q4tpCNaHJl 9bqKpkhTdMYzUCpyD+49q8Mt4Z8UeXaZ8/s/qZEO2o4vESDBprDKtHtNgy0mzdqRc/OB nfSb3L5nsMtqVHSJtsUDQRzeZmahmbAp67cIKEKUFGldkmjzdrIPPJz577rK6G75tO/J XqHw== X-Gm-Message-State: AJaThX703AbRx4IFAWK1EMB0eYk8dc4kSBbSvIcdpT924SOWy6jkzK4v dq1so5y9P3U39/j6/aMP1T3B X-Google-Smtp-Source: AGs4zMYnlwDEwEFTgCMveCU3/W1SuJUpX9+vOqpB9TQvUPU9REMPLwLv9q25PxHTsh86BETHBx2I8w== X-Received: by 10.80.149.75 with SMTP id v11mr12155849eda.284.1512036894282; Thu, 30 Nov 2017 02:14:54 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s6sm3061985edc.2.2017.11.30.02.14.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 02:14:53 -0800 (PST) Date: Thu, 30 Nov 2017 11:14:55 +0100 From: Nelio Laranjeiro To: "Xueming(Steven) Li" Cc: Adrien Mazarguil , Thomas Monjalon , "dev@dpdk.org" Message-ID: <20171130101455.4hkafnw5nm6k2cfp@laranjeiro-vm.dev.6wind.com> References: <20171129173106.120828-1-xuemingl@mellanox.com> <20171129173106.120828-2-xuemingl@mellanox.com> <20171130081624.64wc37biw5s4dgfo@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC 1/4] ethdev: support rss level on tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 10:14:54 -0000 On Thu, Nov 30, 2017 at 08:46:51AM +0000, Xueming(Steven) Li wrote: > Thanks for feedback, comments inline: > > > -----Original Message----- > > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Thursday, November 30, 2017 4:16 PM > > To: Xueming(Steven) Li > > Cc: Adrien Mazarguil ; Thomas Monjalon > > ; dev@dpdk.org > > Subject: Re: [RFC 1/4] ethdev: support rss level on tunnel > > > > Hi Xueming, please see the comments below, > > > > On Thu, Nov 30, 2017 at 01:31:03AM +0800, Xueming Li wrote: > > > There was no RSS hash fields level definition on tunnel, > > > implementations default RSS on tunnel to outer or inner. Adding rss > > > level enable users to specifiy the tunnel level of RSS hash fields. > > > > > > 0: outer most, > > > 1: inner, > > > -1: inner most(PMD auto detection if nested tunnel specified in > > > fields) > > > > This *inner most* is confusing, what does it mean for the following > > pattern vxlan / end? > > This pattern is valid for any level of the VXLAN according to the NIC > > capability. With an inner most, if the PMD support 4 levels of tunnels it > > will need to create the 4 rules to match the user request. > > Is this what you expect by this definition? > Yes, auto detection according to tunnel spec. Users could always specify a > concrete value, 4 for this example. Such value must be used with care to avoid colliding rules, you should document it. > > > > There is also another question, according to the possible values (0, 1, - > > 1), it cannot handle more than 1 level explicitly, why such limitation? > They are just typical values, any value between 0-255 is acceptable. Not really, according to your answer 255 is reserved for a special definition i.e. ìnner most. It does not mean make RSS on the 254th tunnel. Please update the documentation of such value with the correct possible values and create a define for the *special* case, people implementing such API needs to have a clear explanation on what it does. > > > Signed-off-by: Xueming Li > > > --- > > > lib/librte_ether/rte_flow.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h > > > index 47c88ea..c35558c 100644 > > > --- a/lib/librte_ether/rte_flow.h > > > +++ b/lib/librte_ether/rte_flow.h > > > @@ -1078,6 +1078,7 @@ struct rte_flow_action_dup { > > > */ > > > struct rte_flow_action_rss { > > > const struct rte_eth_rss_conf *rss_conf; /**< RSS parameters. */ > > > + uint8_t level; /**< RSS on tunnel level, 0:outer most, -1:inner most > > > +*/ > > > uint16_t num; /**< Number of entries in queue[]. */ > > > uint16_t queue[]; /**< Queues indices to use. */ }; > > > -- > > > 1.8.3.1 > > > > > > > Thanks, > > > > -- > > Nélio Laranjeiro > > 6WIND -- Nélio Laranjeiro 6WIND