From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f44.google.com (mail-pg0-f44.google.com [74.125.83.44])
 by dpdk.org (Postfix) with ESMTP id 2D5E11B199
 for <dev@dpdk.org>; Thu, 30 Nov 2017 23:11:42 +0100 (CET)
Received: by mail-pg0-f44.google.com with SMTP id w7so3583228pgv.6
 for <dev@dpdk.org>; Thu, 30 Nov 2017 14:11:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=xQ8rwDB46RuMhpiN/Xfjn3BACAHmujQMFtFTE188Tb8=;
 b=ojPQ3jSMUcgidiAHgOFofJ3jRrDL7x2yoKziNy5dCAxAQpMehnQZMzBEWMPTYOl9Dk
 P3SJWsnqVkZtwNCqmM4ZYm34MimCMepp8ph/F2LoEFZpuO2kKrJcH1g7YCygVBQnMd5A
 xTLRX/uyfOaNpfo5KOkW9sZ2qJqKXAGxW55SBF1VX5+QIwOdAvF08mmFLsj7rvKCCBPO
 DJauuCSODG8rQ8jdUEh1fIo8fPeW1rzJTMhNJJeHCu2xU3wvqjSlTx8r/1qLhmZFF3AM
 OYlhBbOiADTSVnSLhVSG1UDuE/70x6H5L//cX0FHU2wOuHIq3ax/iWzfeDSgZdIyLiyb
 ENCg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=xQ8rwDB46RuMhpiN/Xfjn3BACAHmujQMFtFTE188Tb8=;
 b=cMcUEY6XgcnTRyiq3dPR+RuRXvNJtfkhq8PLzB4vc0t6n3dcJ2SYLFgJi0OFfJ1g8n
 Tpvyb3LNT9I51bHLC5sC6eYA8v3bVvFu4ca5xTaI+J4eauwTcPFksbt1h44MmldbfRht
 hGsyigZLFyxJ8s7fi4UnMtQdkCLvNTTwda6e49i30me+8BlNHbIVhJDFkjitZtJb4gL1
 ldscNT34SGX8wwNZLO1f7RZTd54i6vBTSh3Mh5ZWDlLtwJXMNcs9pRxqisS/ijq+1cOz
 LbwmCHDmM3cMypNJQ3tagWvMOTqZxwLIB/p8KEs3uqltMWsR90zAmWz76AMhyMUcwZRm
 doow==
X-Gm-Message-State: AJaThX44GgUKi62glg5z+Iblay7/Hbb61ui4h+rk4+SgB7YrX4Ru0Ghh
 GOldfOtUjuT7yvhhrCKL98DjHWybSLU=
X-Google-Smtp-Source: AGs4zMase1cl+klF8Vc2cyG42opZSfjUFdXUda0xLdqxtRdtlXdCOY0PNSJ3ZD8Br5SmbhLyd1HRZA==
X-Received: by 10.99.3.195 with SMTP id 186mr3812538pgd.103.1512079902130;
 Thu, 30 Nov 2017 14:11:42 -0800 (PST)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id s73sm9244890pfi.167.2017.11.30.14.11.41
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 30 Nov 2017 14:11:42 -0800 (PST)
Date: Thu, 30 Nov 2017 14:11:34 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Message-ID: <20171130141134.52068e4f@xeon-e3>
In-Reply-To: <2407814.uAEd4ZzsLf@xps>
References: <20171130214720.30098-1-thomas@monjalon.net>
 <20171130135551.458330e2@xeon-e3> <2407814.uAEd4ZzsLf@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Nov 2017 22:11:43 -0000

On Thu, 30 Nov 2017 23:03:57 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 30/11/2017 22:55, Stephen Hemminger:
> > On Thu, 30 Nov 2017 22:47:20 +0100
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >   
> > > +	for (int reg = 1; reg < 4; reg++)
> > > +		memcpy(name + (reg - 1) * 4, &regs[reg], 4);
> > > +	name[12] = '\0';  
> > 
> > C99 style declarations are not generally used in DPDK.  
> 
> True :)
> It will be fixed in v2.
> 
> I think I should add a log somewhere at initialization in order
> to test this function.
> Do you think it deserves a table of name strings in the .h?

Same table is short-listed in util-linux (lscpu).
You might also want to handle Xen, Xen PV, VirtualBox, 
Windows and WSL at some point.