From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30077.outbound.protection.outlook.com [40.107.3.77]) by dpdk.org (Postfix) with ESMTP id 899A12A62 for ; Fri, 1 Dec 2017 04:33:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TUrLFkudN8WDsbwg39wTSjpiXFOHCoKdhiK9/zyVb/4=; b=JMPKdOVBzxCcns1rhMxNw91SCJVCafIS5P5/1MhrsSK/eEiqazhxS4LuW5PQ/6pluix/cZFrbrkNNq9fPDR2FeKUpCcLZdp0hs+ngkit6zTGA6Hx0DFVh0TcZnYcJieUtyI+l7CEzJfeWvomSk2aVw570hf3GqeBkN0WBSHSS28= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jianbo.Liu@arm.com; Received: from arm.com (113.29.88.7) by HE1PR0801MB1355.eurprd08.prod.outlook.com (2603:10a6:3:3a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Fri, 1 Dec 2017 03:33:30 +0000 Date: Fri, 1 Dec 2017 11:32:15 +0800 From: Jianbo Liu To: Tomasz Duszynski Cc: dev@dpdk.org, mw@semihalf.com, jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com Message-ID: <20171201033214.GB21389@arm.com> References: <1512048743-23749-1-git-send-email-tdu@semihalf.com> <1512048743-23749-6-git-send-email-tdu@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1512048743-23749-6-git-send-email-tdu@semihalf.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [113.29.88.7] X-ClientProxiedBy: HK2PR02CA0190.apcprd02.prod.outlook.com (2603:1096:201:21::26) To HE1PR0801MB1355.eurprd08.prod.outlook.com (2603:10a6:3:3a::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4864a858-9c7e-4a26-e9ed-08d5386c4bed X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286); SRVR:HE1PR0801MB1355; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1355; 3:pMIQ4yfBXxTu3O/cGfubCe1iURLx2/NPG04atjps6lbZRnkJa8dxSJYlRkiYbJ7P+7kd9cg4VR3brlrMN3ROeqNeVp7JDxlWhXzxMOPyvFdaHl7/syH5E3djOvIH7edgcOwyS+Hii8nIqPmH0PRgfi2gOiKU6wgr761A8wHnXeXeJAdjORvm1NOo3YUsBR5tuy8a3blc/Dnga1y6LsQrvchnxzZWFiQOzujV0ZosaKTfm2eKYvxXOW/r2fHynd6N; 25:UbPeCbT8ijIx/SBVG8gmGtuu/exWM/wcLEJQJWT7DjV6pGnwpzBHWr+fXt08dMl4H+tBILbsTl+brPPQ0jesbi/wBn/RE4wXOplzdSBcsl+wXOnyKrbigPXKZKMp6mW2/NDsdTsgUKSvWXgDIFj7JfvUmHf7RvnIJzif1T8rIy/7GkYVsroVCp+QbM+3jJdvS3m3JM24lP+ncyhkWYsKFLp53e9EeVLzkuueQ+TLpVoxNwb1TZ6+h3IuQjSKZlyfSN6s5v8S6NP3ItJFHhxfnbQyEvTl1RHAh6vJrq4zwYOtKOu7W2NdjI6ECglkw0FhsC/pdGInqjeToK0J9FtWPA==; 31:yjiZJ9A/iXnVN24UEG9h2RCIL9A+plaQvPTMnuJZavMHDyBjrqTyZpem+8aVZApb/5NR6kOZroqQM/pFlsgL7QrS+RJmmO76bCh6MfRK3knDvl2vv01Pud7gGDBNmBKu/8Po1dUBUs0qa+7IJSBmekIdre5GwcHIOM5+7TmhK9zpo0IwQtd5Fla78LSw5uPOzARzOPl82eKKv7kWczl83cQSi+nf+tJVwn69hTSf8vY= X-MS-TrafficTypeDiagnostic: HE1PR0801MB1355: Content-Transfer-Encoding: quoted-printable X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1355; 20:LN67sdaYq1btIFhXb6EyIoHB4saR2RCRF0D+T0U1wLG8np/CeyCrAtEEIRNEKqDO70AGOMEQVQ6aM6XHk5xrvar2OcSJ5HiYmi/WsqVGLOKuFq1xB3jLht6Fu3/lQfeTKuTYTnf0iAzhcdB/RvkMkQ9TGNqa259o82dnVit+mQe9ENoi5X9JqbKuoFV/nae7kK/45GytYaCAl0s0AEjvB9vGwYK0icUVIGgovxA0MROpAPEe//a/GUdcpbYl5e3cmvWXDz0YF5m2QUSkCpU9cpcF0N2eMw0lUIHqK45Wk9USUjX5nxsrIF3c9oHp0akYHySt3xsSzkeeEKBjJttrNZPvknv+KIBztc6iN71ab+04tof12Lnpr1W/GHWppWusqo5Nzmv9FzaOnUacfMRMKIMf/Lvf0C07cZOWsA2oHFhAezGNPcBgdqKPfIfaZvZkEDR+mQIlEpokl+/yx89d+74XZ6tCLEVkCeD3KNKiYNrh1TxHFLKhunkQbiMT+Nz0; 4:AFjwMsE+wBnphvQh7eL7qYGBgG/nHgE+Ipqgv2nO6XVgj/T3fl4R3X0HJBxch7BZhCuwzL/B/iEDCeQg0JVasuOTs3ZjoStKzriuk1ZIC0j6T2WSFyHpNUrsJWfXN/MZZN6683DZICBeFD0lQNCi9Bhr5CjaSDLsndBl071brqEI6vZc30NY6Yozgam6bnZM9dO7sbF3U5qd9+v9clQzybnNmu9g9ywsxrLfPEoL3i8MFwpyFFY7Bud2EnqPAvIQDj0/QrPdHSewnMAxRSCjQg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231022)(6055026)(6041248)(20161123558100)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR0801MB1355; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR0801MB1355; X-Forefront-PRVS: 05087F0C24 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(366004)(346002)(376002)(199003)(40434004)(189002)(24454002)(1076002)(3846002)(72206003)(5660300001)(86362001)(6116002)(105586002)(53936002)(106356001)(16526018)(8676002)(8936002)(81156014)(81166006)(5890100001)(8746002)(50466002)(58126008)(316002)(478600001)(68736007)(33656002)(6666003)(25786009)(101416001)(2950100002)(6916009)(83506002)(52116002)(7696005)(2906002)(305945005)(97736004)(2486003)(55236003)(7736002)(21086003)(36756003)(6246003)(4326008)(52146003)(189998001)(55016002)(23676004)(66066001)(229853002)(54356011)(47776003)(76176011)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1355; H:arm.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4MDFNQjEzNTU7MjM6SGRJVUEvR3JkK2JIZlRyc0ZxbXFQczlG?= =?utf-8?B?UTh4eDVwYjZqd2E4U0dxM3JQTHBndWpwbkFlb05BTURpMHo4d2tSTkJKUDk4?= =?utf-8?B?K2RjSlhpNy9MMUR6K1JLSFFVd1pTZFIrVE1GalhEOWNlL3VZSUczTUxxWUht?= =?utf-8?B?TzZYY29vYlJ5cWVRZlNUQWVVZys5d2ZZSHg5cVZ1czFxL1FWcVRVOTM2dzFK?= =?utf-8?B?bE5HOW4yMW1HRkcyK0ZOd3BSdmxBTC9PZmc4bkdkdkxPejN6NFhFanFyNnQy?= =?utf-8?B?L0g2bXBFR1BRdGtJMm8zSkV5OW1FdFlrL3ZWNVlieTdlN2hIejUzK3EvRTFi?= =?utf-8?B?MlEzQXpLNFRiYjFkSTBiZ253cERjNmpQSXNCcjYwdHNyeUFQa2xONDZnV1Y2?= =?utf-8?B?NzhwSVA4KzFqKzg4eXFheklFYmZ0QnMzVVR6OXgzWllUNWhSN0diV2Qyd0xW?= =?utf-8?B?WTVYSjlSOUhPOGlyUWR3QUJwVDNTL2QrNUh2a0RjTmdNWUwzMEJrNVluTk0w?= =?utf-8?B?bTNlSFc4azROK2ZGMWZsanRpanBoblh4SU9pakdqdU9TNFBWOU1EYkxVb2Rl?= =?utf-8?B?MmwzTS9hZVFWVThPbFh6ZDdkeTFVVFBaVXdOa1VZZmVMekZNNTJnZWtTZ0Yw?= =?utf-8?B?ZjVEU1k2aWNrT3N0S3VEc2NEL2tZRXp5OUVEMURTMFdRU1FYZlBtQ1p2NGhv?= =?utf-8?B?aGdtdW5HTEJ2U3ZURENjZWt3L045bEJtVStWM05aSUhjZXZYSjJTOFc0b1Ji?= =?utf-8?B?eEwrMXNtQmZCTGNpaGx5YVpQMVgyT0dyWk5MWkR4WDFIb2ZNVnAyK3NEMm9B?= =?utf-8?B?MUtwRlFUUVY3UGhxYmJRWnlZMzc5SUYxVW5WSEpEY3lQNXVGeGNwQWxaZTg2?= =?utf-8?B?OUhWQ2EzcHJYOFl6WGxSeHA4Vkxybkp0eGtUbWlqS3RRTmFYTzdFR1BBUkxs?= =?utf-8?B?RXBsYU1YV255MUlnTm81ZTFqNkxwV1RReWNCc3grZHdqa2ZOb2ZoYlZsSFNJ?= =?utf-8?B?cWdXOWNZWUtibWlBdWp1aXpDM2lXbC9BYWVCTnJRYXU5VXg4OU9rL0hOckpM?= =?utf-8?B?Vlo0WjZwSW9iN0JPQURBZS9CbWwzNlk5M2ZzSnNKN2ZDWnN5dS9pZFVFVWF1?= =?utf-8?B?STMzT0lVd3BVVWl1Sm5wOEduUU5FRVV1amtETHlyL201QjFsNkw5azFZSEcw?= =?utf-8?B?THA1VmxhTEFnK0VHSm9GdWp2MUVpRS80cDF1eklVZ3VxelA3WmpJNm9VMjFM?= =?utf-8?B?aXVCMCswN05zbWZzSXBlczRJUnpvd0FDdHZIeXFzc2xFdkRQem9rbTNEaVpR?= =?utf-8?B?UlhLdTRFU0FuR3BJazlhZEZVblVHSHJQakZLb2NyNjY2S0RvQ2ZmYXRGYUhH?= =?utf-8?B?VHNmUjhuclJndWtXRzdkOEVNeXhkdWt5OGlyT3plbmxFMDhnK0FJOGhyMCsx?= =?utf-8?B?QnNVajU3Q0hXZkpWcVpZcS9LaEJGSUFEcFEyTnZIemdNd28wRzdlSjJJR3Jn?= =?utf-8?B?N29iL0JqZWNKWTREUE9XWWhQU3ZYOFNoUmRYVDQyOGYwbHhXcE9id0pjelhD?= =?utf-8?B?bXplTWVDMXVqRU5MbGI5NFFBVVAwM3d1TkhtcVc0MEZyNmhRdkZxV2VqL3ZX?= =?utf-8?B?S2VUL092ZVNsdy9VeEpSYVVmVk1mM2hOM1htaUY4RmNrblRhVmorYktGejNL?= =?utf-8?B?Yjd2ekk0RzVxMXQ1ekVMOWR4OXBINFpFL0JqU0lHcmRXZHJFeWxSaHB0bXBi?= =?utf-8?B?Vjg4aWxNODd2OEhxcFA4dzl5OVpkdmlSOHYxaklWYlRmd0QxV2FxMzNqNXVk?= =?utf-8?Q?d2PPJR+7drzy0fV?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1355; 6:deQXmNKwe3ZDO69+SKL/YPAsYwXOqQPLN5AQAco/DxbGjk39v+X+rkM5O8PW8d6DlLKkYQweVKUEGBV1qzA1CaVAGQ1pjK1FPQ0uHQLCFdY75KhSlirVgyYsYA5Q6C6VgGShkNafhQp5MRCZ8Z2M1ARUH50oXU2YQ8G/SWoN+AOmJ+BEoscxugF3DwnVs91oVsLhbxAgOv8YyjkV0Lq413PHgNeATrqRL3rfbw5p0aBVtWr/hNaPQPUqi4QjuXeZzd4l5lcRWC0q0RiO68luNDm/tRBRWVQ5Yb74eyU5zp81qhp4Sp7Gydy87pIuIVtRb0/3P3gvzb+kIuxhbZe2RJdyfdgESu7xJozvbbLI9vE=; 5:jP2UAAtfKBzYABM9xP/QhP73TXXgdhYvUwd1y/pKK1A27XakGJfU8gDpux6xH+ZvaYa0TrLHm2Px9JWZH7GOyK/OwMoCZyX7gU9WRPXFNOilWuEcvnnIgCQYh9jrdWO9q40Hc2OKKkvCtOsp8MiplRcPHjm+E49NneVRUdfFbqg=; 24:AAnIgYrF3O7E3m9wxw7fXhNg7MR3g2t+h2P6CzT43tHInXZQTIMF3pUaNP31DMU9/ztcfBaBWyCCbTmHMSPHzIDSTdikzLthu6ddj5zWdUM=; 7:TRgbJPgy+v0sv+86w8WC97PjmPhJCv+rm/0uFsa2UK23aGcMcJvADqKX9dbLC3VP5cYX/5nL3JgQf17Wqmg/TxXf5jr6XVlLHtqaREKJrgwc3PiCoMHhqfXdmnLAgFgE+nA1lzNDZLpM/bQIu8cKjv5RS+OXN1pVTl17eVWTMaRk9vm911lOY0SNNRvLLhpvrJbR31iuvgm61xT8gYvxxmbLkj9Vp6WlkwfyttY0DkcDynj4TgMyHDzE/gsaPaxH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2017 03:33:30.2892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4864a858-9c7e-4a26-e9ed-08d5386c4bed X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1355 Subject: Re: [dpdk-dev] [PATCH 5/7] net/mrvl: add extra error logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 03:33:34 -0000 The 11/30/2017 14:32, Tomasz Duszynski wrote: > Add extra error logs in a few places. > > Signed-off-by: Tomasz Duszynski > --- > drivers/net/mrvl/mrvl_ethdev.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethde= v.c > index 92cc283..ed97831 100644 > --- a/drivers/net/mrvl/mrvl_ethdev.c > +++ b/drivers/net/mrvl/mrvl_ethdev.c > @@ -431,8 +431,10 @@ mrvl_dev_start(struct rte_eth_dev *dev) > priv->bpool_min_size =3D priv->nb_rx_queues * MRVL_BURST_SIZE * 2; > > ret =3D pp2_ppio_init(&priv->ppio_params, &priv->ppio); > - if (ret) > + if (ret) { > + RTE_LOG(ERR, PMD, "Failed to init ppio\n"); > return ret; > + } > > /* > * In case there are some some stale uc/mc mac addresses flush them > @@ -467,8 +469,8 @@ mrvl_dev_start(struct rte_eth_dev *dev) > if (mrvl_qos_cfg) { > ret =3D mrvl_start_qos_mapping(priv); > if (ret) { > - pp2_ppio_deinit(priv->ppio); > - return ret; > + RTE_LOG(ERR, PMD, "Failed to setup QoS mapping\n"); > + goto out; > } > } > Do you need to print error log as well if mrvl_dev_set_link_up fails? > @@ -478,6 +480,7 @@ mrvl_dev_start(struct rte_eth_dev *dev) > > return 0; > out: > + RTE_LOG(ERR, PMD, "Failed to start device\n"); > pp2_ppio_deinit(priv->ppio); > return ret; > } > -- > 2.7.4 > -- IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.