From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 9BD3129D9 for ; Fri, 1 Dec 2017 09:26:02 +0100 (CET) Received: by mail-lf0-f43.google.com with SMTP id f18so10800615lfg.8 for ; Fri, 01 Dec 2017 00:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8YaZ+5+quZX11AxeYdQwKv6Th/V6oxxtmHLJ7joueUc=; b=mSykwpTeSejlvPr6TJUt+sw42VltlWX1vL/FgpjomfX5j1jTH0ef2FIu5Ww+tBwwcI U0NhlLycq4qCXuSOlVpbHvkD0UFKgshBhsxpvcjwrnhEqieSOygoz/mIQ6OTs0D+wlEV YfofeTXyb8T3jd5xSf+Deji8NCeh6BG11aL65EoPs66QNKSa4dh7LCcC9XNqNqjMjRBy WKiN6B018Tz5GDyHmBXicSxWyVw6jtp5QseRfzPrAeCMN3o2oZMkwNQYUqRXInMZilXo dDSnougGF19us+JN6exKIjlvi3SQn3PI2CX7/64+AvCtkj0vlN8rbm5jL6AyzVjx4GOF QXiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8YaZ+5+quZX11AxeYdQwKv6Th/V6oxxtmHLJ7joueUc=; b=CZAYI4rGXMw6Mx1p8vX0XT3VALLg9QUkt2r5F0BFt5bOHuqDdqbtAvVbtuBiQC5H/O fMRzVhm7GKAm19//Jz9AuAL9TbYek+Zec7RNGBYQXUnQdy6zWRsxp5hoS+pqHpFUg4q3 sZqYBoDSkFSxwUDeSIMsPNeiS+NHPtXKNYJJEPhQ56FfRvqCS4yQXLH08UrjL6yTCbjt wpz/X7I6pR/QY3XhY01vwnoyBMJne5uihsL8lGWfaw9Qg5M0847lQLohPcm65q708i6N 68neFNSFCU8o8qmdoyisPdieYc8AACZKxzkrrjmrfwVCl29awZT38+hjVyHCWGwsN4/A 03QA== X-Gm-Message-State: AJaThX5iwgdZQr0U6E5XgN7a+bsg6+7L+vcAalgHAuSK5ODUeYDMldzX R1G5Rw3EIxseHqb9OYQfhanGjA== X-Google-Smtp-Source: AGs4zMZkr026m+lLgiMtbObxju2nacLTVyHyAgfpQeXlNHtrJ3Etikng3Moua4o5F6/AZa4NlN/TRQ== X-Received: by 10.25.23.165 with SMTP id 37mr3279419lfx.127.1512116762147; Fri, 01 Dec 2017 00:26:02 -0800 (PST) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d80sm1196249ljd.51.2017.12.01.00.26.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Dec 2017 00:26:01 -0800 (PST) Date: Fri, 1 Dec 2017 09:26:00 +0100 From: Tomasz Duszynski To: Jianbo Liu Cc: Tomasz Duszynski , dev@dpdk.org, mw@semihalf.com, jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com Message-ID: <20171201082600.GA4421@tdu> References: <1512048743-23749-1-git-send-email-tdu@semihalf.com> <1512048743-23749-6-git-send-email-tdu@semihalf.com> <20171201033214.GB21389@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20171201033214.GB21389@arm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 5/7] net/mrvl: add extra error logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 08:26:02 -0000 On Fri, Dec 01, 2017 at 11:32:15AM +0800, Jianbo Liu wrote: > The 11/30/2017 14:32, Tomasz Duszynski wrote: > > Add extra error logs in a few places. > > > > Signed-off-by: Tomasz Duszynski > > --- > > drivers/net/mrvl/mrvl_ethdev.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_eth= dev.c > > index 92cc283..ed97831 100644 > > --- a/drivers/net/mrvl/mrvl_ethdev.c > > +++ b/drivers/net/mrvl/mrvl_ethdev.c > > @@ -431,8 +431,10 @@ mrvl_dev_start(struct rte_eth_dev *dev) > > priv->bpool_min_size =3D priv->nb_rx_queues * MRVL_BURST_SIZE * 2; > > > > ret =3D pp2_ppio_init(&priv->ppio_params, &priv->ppio); > > - if (ret) > > + if (ret) { > > + RTE_LOG(ERR, PMD, "Failed to init ppio\n"); > > return ret; > > + } > > > > /* > > * In case there are some some stale uc/mc mac addresses flush th= em > > @@ -467,8 +469,8 @@ mrvl_dev_start(struct rte_eth_dev *dev) > > if (mrvl_qos_cfg) { > > ret =3D mrvl_start_qos_mapping(priv); > > if (ret) { > > - pp2_ppio_deinit(priv->ppio); > > - return ret; > > + RTE_LOG(ERR, PMD, "Failed to setup QoS mapping\n"= ); > > + goto out; > > } > > } > > > > Do you need to print error log as well if mrvl_dev_set_link_up fails? Right, extra log can be added for consistency. > > > @@ -478,6 +480,7 @@ mrvl_dev_start(struct rte_eth_dev *dev) > > > > return 0; > > out: > > + RTE_LOG(ERR, PMD, "Failed to start device\n"); > > pp2_ppio_deinit(priv->ppio); > > return ret; > > } > > -- > > 2.7.4 > > > > -- > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. -- - Tomasz Duszy=C5=84ski