From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8B7A7107A for ; Fri, 1 Dec 2017 11:33:13 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Dec 2017 02:33:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,344,1508828400"; d="scan'208";a="8351798" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.35]) by orsmga003.jf.intel.com with SMTP; 01 Dec 2017 02:33:10 -0800 Received: by (sSMTP sendmail emulation); Fri, 01 Dec 2017 10:33:09 +0000 Date: Fri, 1 Dec 2017 10:33:09 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, vladz@cloudius-systems.com Message-ID: <20171201103308.GB10384@bricha3-MOBL3.ger.corp.intel.com> References: <20171201022957.64329-1-ferruh.yigit@intel.com> <20171201022957.64329-7-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171201022957.64329-7-ferruh.yigit@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 10:33:14 -0000 On Fri, Dec 01, 2017 at 02:29:57AM +0000, Ferruh Yigit wrote: > "struct rte_eth_rxtx_callback" is defined as internal data structure but > used in public APIs. > > Checking the API documentation shows that intention was using this > object as opaque object. Data structure only used in delete APIs which > doesn't require to know the internals of the data structure. > > Converting callback parameter in API to void pointer should not require > any modification in user application because this data structure was > already marked as internal and only should be used as pointer in > application. > > Signed-off-by: Ferruh Yigit > --- I disagree on this patch. The structure itself is not exposed, only the name, since it is only passed around as a pointer, so there is no need to change the parameters to void pointer. It's a named opaque type.