Re: [dpdk-dev] [PATCH 1/2] mbuf: check sanity of data_len and pkt_len as well

[Olivier MATZ <olivier.matz@6wind.com>]

Hi Ilya,

On Thu, Nov 16, 2017 at 06:04:43PM +0400, Ilya Matveychikov wrote:
> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>

Please, add a commit log.

> ---
>  lib/librte_mbuf/rte_mbuf.c | 23 +++++++++++++++--------
>  1 file changed, 15 insertions(+), 8 deletions(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index 7543662f7..491685c36 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -202,8 +202,7 @@ rte_pktmbuf_pool_create(const char *name, unsigned n,
>  void
>  rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header)
>  {
> -	const struct rte_mbuf *m_seg;
> -	unsigned int nb_segs;
> +	unsigned int nb_segs, pkt_len;
> 
>  	if (m == NULL)
>  		rte_panic("mbuf is NULL\n");
> @@ -220,18 +219,26 @@ rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header)
>  	if ((cnt == 0) || (cnt == UINT16_MAX))
>  		rte_panic("bad ref cnt\n");
> 
> +	/* data_len supposed to be not more than pkt_len */
> +	if (m->data_len > m->pkt_len)
> +		rte_panic("bad data_len\n");
> +

This check should only be done if is_header == 1.