DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Kevin Wilson <wkevils@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] rte_ctrlmbuf_init() and CTRL_MBUF_FLAG are not used - shouldn't they be removed and deprecated ?
Date: Fri, 1 Dec 2017 17:38:16 +0100	[thread overview]
Message-ID: <20171201163816.btvl4t34afrbqkij@platinum> (raw)
In-Reply-To: <CAGXs5wUrLAjGmy4MsjPKR1apOw-kBK0cvrC7fVAHKbd7SZvquQ@mail.gmail.com>

Hi Kevin,

On Sat, Nov 25, 2017 at 01:43:17PM +0200, Kevin Wilson wrote:
> Hi all,
> 
> >Let's see if someone complains, and if no, we can plan to remove it
> >for 17.11.
> 
> Well, unless I missed it, I did not encounter any complaints, and
> 17.11 was already released.
> And the status is of course the same (meaning that in the DPDK tree it
> is not used).
> Maybe now that 17.11 was just released several days ago, it is a good
> time to start deprecation
> process for these control MBUF stuff ? I know for sure that for DPDK
> newbies who read the programmer's guide
> and encounter it, this is a bit confusing (like in
> 
> "2.3.3. Network Packet Buffer Management (librte_mbuf)"
> in
>  http://dpdk.org/doc/guides/prog_guide/overview.html#network-packet-buffer-management-librte-mbuf)
> ...
> ...
> "This library provides an API to allocate/free mbufs, manipulate
> control message buffers (ctrlmbuf) which
> are generic message buffers, and packet buffers (pktmbuf) which are
> used to carry network packets."
> ...
> ...
> and of course also confusing those who delve into the code.
> 

I agree.
I'll send a RFC soon, and a deprecation notice for 18.02, planning
a removal for 18.05.

Thanks for spotting it again.

Olivier

  reply	other threads:[~2017-12-01 16:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03  3:51 Kevin Wilson
2017-07-03  7:42 ` Olivier Matz
2017-11-25 11:43   ` Kevin Wilson
2017-12-01 16:38     ` Olivier MATZ [this message]
2017-12-08 15:49       ` [dpdk-dev] [RFC] mbuf: remove control mbuf Olivier Matz
2018-04-03 13:39         ` [dpdk-dev] [PATCH] " Olivier Matz
2018-04-03 14:42           ` Jerin Jacob
2018-04-11 21:54             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201163816.btvl4t34afrbqkij@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=wkevils@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).