From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 74BDC239 for ; Mon, 4 Dec 2017 15:03:33 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id z34so17413123wrz.10 for ; Mon, 04 Dec 2017 06:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E6t54pARVVh3I995OMbPnt6jtzB5iwU2LsDXMBQrYvU=; b=OMpuzHnEXD0GXMNIQXgzi4awIvlDhckmeHIM3Y9L1b8Pmntz+QSyugajbfTx6SRKqU WKFpl3lEjzr71gyy3283k6q2Cls4CsFv3p/dJEZMsEjG6WKa3R0NIhS+Nw2JKsJ628ii Zw2PjXDtzch4HlMHHtLk/oDd7676RycluJxm0/XViN9NfwjkQOwLLI6d4J8Iu/TglzSi 3sXU9OYmTuSO+na8dRkxmxAMyu9wa5YvbgJ+xhg0pxHnRDG4Vt1C7p2ngfCZhDSDigeP Fjc6CKPn+N2hdEnDk59fyJiMMF7D8HLK0oHewsEicRNthxFYZEbqrCFzYonhHlPC4qDe 0ocQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E6t54pARVVh3I995OMbPnt6jtzB5iwU2LsDXMBQrYvU=; b=jq2yls3Z26U9vAppYpq0kVCkkDYtdeBfcUKepnpR5DHxhqBOAQP1ZcvBtkdsR5k4+l jA6V4XiVSir4WqvROX0vsB2erQQq4q+N4J3Qt3SI5BnLkbrGkEPamwojyNIijGXlVsql 4ZWpCFxYXIbksWBzTdsW/l3vOmCtQ7ut3QpJkEegenH2paMqbcAYejHnvLlGcwxoMAs/ VlrzRrpYtoyvX7sR7tHVYNGqVwmXOUNrFCbDfKbeOW8gHZgNUxpepj7FHSBtJSCmpaZp Xe6o88H3dLdamuuh5i/1clUgquXoi4jEznCOWpL73sVmBfDoo8rBIjJla9GEH63O5YFK 1/cw== X-Gm-Message-State: AJaThX5hfz5Bk4fvSzyLaQ2y945wjb2eWAJeygcQnQqkHdw3BpeTlzWA yyQyPsfoS9pCEDAIKcTvPWW/mrSC X-Google-Smtp-Source: AGs4zMZ5c2FMyiuuDMd6Au4hX7MQoXFXgDC45SC2a0lw/Frwl1wBKKhP2YPYNFHEhgNRkNYCzuS7ow== X-Received: by 10.223.199.212 with SMTP id y20mr14618569wrg.60.1512396213125; Mon, 04 Dec 2017 06:03:33 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y99sm8499723wmh.0.2017.12.04.06.03.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Dec 2017 06:03:32 -0800 (PST) Date: Mon, 4 Dec 2017 15:03:21 +0100 From: Adrien Mazarguil To: Andrew Rybchenko Cc: dev@dpdk.org, Jingjing Wu , Roman Zhukov Message-ID: <20171204140320.GE4062@6wind.com> References: <1511166121-743-1-git-send-email-arybchenko@solarflare.com> <1512124996-13388-1-git-send-email-arybchenko@solarflare.com> <1512124996-13388-2-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512124996-13388-2-git-send-email-arybchenko@solarflare.com> Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 14:03:33 -0000 On Fri, Dec 01, 2017 at 10:43:15AM +0000, Andrew Rybchenko wrote: > From: Roman Zhukov > > Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API. > Add default mask for the item. > > Signed-off-by: Roman Zhukov > Signed-off-by: Andrew Rybchenko Just one remaining nit, please see below. While you could address it through a subsequent patch, you might as well send v3 directly to make things easier for Ferruh. Otherwise it's all good, thanks. > --- > doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++ > lib/librte_ether/rte_flow.c | 1 + > lib/librte_ether/rte_flow.h | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 43 insertions(+) > > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index d158be5..5b8f9c5 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -980,6 +980,18 @@ Matches an ESP header. > - ``hdr``: ESP header definition (``rte_esp.h``). > - Default ``mask`` matches SPI only. > > +Item: ``GENEVE`` > +^^^^^^^^^^^^^^^ Missing "^" under title, this may trigger a warning during documentation generation. -- Adrien Mazarguil 6WIND