From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 4032D14E8 for ; Mon, 4 Dec 2017 18:43:17 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id v22so18235034wrb.0 for ; Mon, 04 Dec 2017 09:43:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OJ5mzIG29OrlVCF/IvZVExY9Bk+Bqjq6tfN29CDtKy0=; b=rk7g90Q29SlGOqm/MF8CI3hxSYClpCZWswY+O3r2FPiF30v13IZxTwnppiQVjpJ7cz 1QdHfFv7xPyk9e1XLtVOSWOIk31V1OLxyZ10mJgp2AAWGJXktDGEYlWXm0NnHAzZW2a1 bgC86loRpuPKYTUNZKgqXziEyTI9gG140Uq69+GZPmlL3BJPbUi+goAHdX2xXZBv1a/P dm69e10zDlS7TU3VIGksfI5MnUXdW2mq1gQSedOK/8CinyWesWoCaDvWaVeDGr/EmALz y7WegVPXJB5VTFdkCj57XgIGNnfGc5DiVz5szeS4p/TWOJjxHIWkoVUe140e36SfO4ut 4Vyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OJ5mzIG29OrlVCF/IvZVExY9Bk+Bqjq6tfN29CDtKy0=; b=KW2MS9ZdG6EELZ9ai+/rJtOMNQy1SHx/tvkPZANuXG5wS6/oPxIWS4JUx+L5liR1Gt qnn4++r01OpK+uyZiSO3/EiAXr/SA6F+x/zp/dqN/gkaqK+Q+xg9kkpD9gagkBj6aaDX RfxpSzk/8XdrXOCdRQPSjK4+4gzC9XIA3vo/DdCgTbmywxDDmG+5H07rPCDsjgfl6IDr h/rJ5PyXs4tRWRWXp1p7mbZ+OlJV8x6iV3Za8lQBk2CJjjfJxqosp+eAShzxby3eCSuJ aTWGhwPgDkkfuzhf0jKsB7syP3Mq5rTtHvhLC6MBBpiZok1cJ2a4rWcdGo3jsSzbLfPs TGOA== X-Gm-Message-State: AJaThX4/FcZy2fR8850w9D8HWwER4B0+rqpUbb553Zi+DOyaYwvc+JyP TCs/sZGJ4LyT80rwKQRRRTx4dQ== X-Google-Smtp-Source: AGs4zMa7Vb4v4vHhbpKiV5FIdg6oOh0TOQNh+CRMhEZYWdua9UrjToxv84tmRaj+WYHlK8Xz0mJtAQ== X-Received: by 10.223.179.215 with SMTP id x23mr13585701wrd.198.1512409397714; Mon, 04 Dec 2017 09:43:17 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d71sm4322807wma.7.2017.12.04.09.43.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Dec 2017 09:43:16 -0800 (PST) Date: Mon, 4 Dec 2017 18:43:04 +0100 From: Adrien Mazarguil To: Kirill Rybalchenko Cc: dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com, johndale@cisco.com, neescoba@cisco.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, andrey.chilikin@intel.com Message-ID: <20171204174304.GK4062@6wind.com> References: <1511785787-127452-1-git-send-email-kirill.rybalchenko@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511785787-127452-1-git-send-email-kirill.rybalchenko@intel.com> Subject: Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 17:43:18 -0000 Hi Kirill, On Mon, Nov 27, 2017 at 12:29:47PM +0000, Kirill Rybalchenko wrote: > Increase the internal limit for flow types from 32 to 64 > to support future flow type extensions. > Change type of variables from uint32_t[] to uint64_t[]: > rte_eth_fdir_info.flow_types_mask > rte_eth_hash_global_conf.sym_hash_enable_mask > rte_eth_hash_global_conf.valid_bit_mask > > This modification affects the following components: > net/i40e > net/enic > net/mlx5 > net/ixgbe > app/testpmd > > Signed-off-by: Kirill Rybalchenko Can you elaborate a bit on the need for these changes? Have you considered implementing those future extensions through rte_flow instead? -- Adrien Mazarguil 6WIND