From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Jerin.JacobKollanukkaran@cavium.com>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
(mail-bl2nam02on0043.outbound.protection.outlook.com [104.47.38.43])
by dpdk.org (Postfix) with ESMTP id 6E43E2A5D
for <dev@dpdk.org>; Wed, 6 Dec 2017 16:42:14 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=1+DmYLNT6/p2uf7r4zr4E70GK/U1peChSVatPOz2ynk=;
b=QlpXDX95SMhwkBUpBVVEHHaId/aBCQoWEDLPx+3ZfCdP0pP7KMOFWYz8QgC/EdCUEQd6RjJMQAv7YpwgXyXVmJ3njS7IvIh5UuoGJ1ZdZJGPyofczxjzVkZTw5+Wxb/tch/+ATAUWBDfmxPP5B4ELyhmRSDA0mXofybez3GbGts=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com;
Received: from jerin (111.93.218.67) by
CO2PR07MB2517.namprd07.prod.outlook.com (10.166.200.151) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
15.20.282.5; Wed, 6 Dec 2017 15:42:09 +0000
Date: Wed, 6 Dec 2017 21:11:40 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: pbhagavatula@caviumnetworks.com, dev@dpdk.org, nipun.gupta@nxp.com,
hemant.agrawal@nxp.com
Message-ID: <20171206154139.GC1591@jerin>
References: <1511890148-22295-1-git-send-email-erik.g.carrillo@intel.com>
<1512158458-22661-1-git-send-email-erik.g.carrillo@intel.com>
<1512158458-22661-4-git-send-email-erik.g.carrillo@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1512158458-22661-4-git-send-email-erik.g.carrillo@intel.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Originating-IP: [111.93.218.67]
X-ClientProxiedBy: BMXPR01CA0025.INDPRD01.PROD.OUTLOOK.COM (10.174.214.11) To
CO2PR07MB2517.namprd07.prod.outlook.com (10.166.200.151)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 30f4e928-897a-42d2-9861-08d53cbfeb49
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286);
SRVR:CO2PR07MB2517;
X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2517;
3:yAhpyb206b5naVTLjFJ/bN7kHew6iO64TzBTYjRfa/oPn3sTR4em9JHsb57JYsc2zhl2jC7Jp0+TS6o+gqXJUqfewWObX9dSzXzCc5PCeQhBgewRfEzXkiIkFM/h0fL6FC/zQV0uDuxDndu6/AErtqb6xPhZ287aC86O86JSB/Z2aJGE4JsaW4zdM/NYW14k5wWkU3wSWXz4TeAmuaTsLPJZVtL2KYc765zCJKpwRdAiPJsyROpQMLKVPIcAaXD4;
25:xJTk48iniQccQNvSzX3Ewxqg8QO0wX7thNyUmknATVF9XcghViSHTv0x4b3wCC0T1MjTYNJJrPXsMDlS+mBbCBkjb1a0JCov6qdEsxBjJ9sS3zoDZZU3MSp7ppu8K2BG61l2ByfNcmTbJkaQQWxJ6ArFWoPDtpK3AoqokVhOA9PCQDtHAuX6rmFuak9R4/Eig42DU6dM2oW021NSn1Ev0fmn+sS0YlsH9jBCXRmB5RPHO2bmOk7tMf++k1xG7gpnd823fRWNSvDgokT5HXuato0suQJ2XPBgEIrzB4EV+s6lH9DKsfBnX8PpdfRIqRNkGKhOcHUdna8olTNgf8Yb7w==;
31:VXpvC0Q5bIYeFDNIr3KnxAoSpIUXCQivBt3cs7o6XztQ5Zbl3gj3NyiQNVBj5tvxFN+xisSNb6kddGD2EUiVK4wM23qTPVQFVAqxBTONNVOsEQ1FmUx4RKN5xkXwUPj52sUvW2PJYqQrtjZAo7xUtye1qs3cEIsfUDwdpzEt3atP6JBEpFxu20xq9M6qbjWHo/x4kYEGxabI0iTuR1pC5IQDTkef/iDY1xGi6ZWMG9I=
X-MS-TrafficTypeDiagnostic: CO2PR07MB2517:
X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2517;
20:G59TEHX541AdxjNapFqgGxOYTjkeU3VtmtRIiDNx8VEqPiRTXvGzYpiqJ+KSg9eiBlwxPYQJq5FfVH+LFa1IQ20hAeggCOwCaFUr/ioOT3+xyk8T+nSD6H5wMqxP0mDeMjKHO8CFKTILfrtHfdh6K0pHI7NqD3NLqO9aoeNJ0+Afdiix64/EovIq/d+Y3E/Y5f7xhTtlutN0nKNDdLxXasQOn2urAnvmRkeTCirXlS3V0HuS7qQOAyI5F08OyPLemvxlynQ/cKZ8nGq7DdvfBdZ3PWCSY/zZ4EWELryinxXxxc4jwms7611slO5Da1CKo2dlFv+VjxZMd0tO/9sygcvQP1xPHMC1pVjPN5ZOzoP8swevBB/49DVZgi24x4aXw5vm9+ZRWFBeUZuoRtQXhPSlKN8yTdtxIWugcdFEI8/bEkJ74G3kjpC8t03Wo4s+HWpX/B/3zPWDU/IVEM20jYuxzkEpeuvkErlpG27N9QsP2NadI5i22ymExTmth1SucoQ3J23jzhBMKR3kSaV1eERaPZ1TCYOfCpaEmrCRVYLAO6Pvk/X9xBd/VIXhGA8Jeifw0E8QtNmQUCf5wSjARayhJlX4H/IHUKtEKqivIvM=
X-Microsoft-Antispam-PRVS: <CO2PR07MB2517A8BE9EC911F26EBAED39E3320@CO2PR07MB2517.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3231022)(93006095)(3002001)(6041248)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(6072148)(201708071742011);
SRVR:CO2PR07MB2517; BCL:0; PCL:0; RULEID:(100000803101)(100110400095);
SRVR:CO2PR07MB2517;
X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2517;
4:Qk0g6ISvw4MqaaR9K79IOLzTSFOqJDOhcnWca1NOyvT8mCs5I2yynTwJQHiej1DiUxFXHjPlTojbeFufeOuvRT2gzFM5qkaFlYEXco566w0QRzh7Bv0+hamC6gNI06IB80cGEWLj4MYkHAtN+bBo4M0Mz3n8GB14axhYWNW8hlLZOECUjVNar5Ue2gf7TioOWtb13LarI33cWaEbHNP+EdKyVK2jh7YIxWwzHQs5mkQXoYxny9O2afa8XoOzcrDAUWG6r/myCcZkjv7PToA2zZSqOwStGzntl7mHP6xBgWQ64tNj0KVpIn4cp9fUBooF58AJc8IYwvu958+nnl/rpXfunefuh6E7Qqy7k1vGaHg=
X-Forefront-PRVS: 05134F8B4F
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(346002)(366004)(376002)(13464003)(199004)(189003)(5660300001)(83506002)(8936002)(8676002)(72206003)(1076002)(55016002)(8656006)(6496006)(52116002)(6916009)(81156014)(6666003)(42882006)(2950100002)(316002)(23726003)(76176011)(575784001)(6116002)(25786009)(33896004)(33716001)(81166006)(66066001)(47776003)(5009440100003)(68736007)(305945005)(3846002)(53936002)(101416001)(16586007)(58126008)(4326008)(97736004)(229853002)(2906002)(6246003)(16526018)(7736002)(478600001)(9686003)(105586002)(50466002)(106356001)(33656002)(18370500001)(217873001);
DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2517; H:jerin; FPR:; SPF:None;
PTR:InfoNoRecords; A:1; MX:1; LANG:en;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2517;
23:qh0dbDPZmsKU/PjO6Sa3O+OyvS2yhm/oj3wBiczKn?=
=?us-ascii?Q?LTR46ipxNyPJ89BJ9x7s8YEPXBm3y+8Xxe3llYH7Dij69IABUdMmOT1oUU0G?=
=?us-ascii?Q?EZBUL41Ttiam0tIpcxHnC3kYfdQJtQIO9Ss19NWDa0LEvTLxLy94vFxqhJmt?=
=?us-ascii?Q?kdBNDQpn8rw7K56qF2V6i9fHWB9yI68GGTAbFx0tJf+UaT7nhcNt9Q5nLHq2?=
=?us-ascii?Q?wTLisO/71Y8JX/CkjaPgQvBoKQ5o/lh4wO3OG1qcBVAr5Sh3D1wlHmYRq0lM?=
=?us-ascii?Q?gbZYjK9sPmbMFFtpZrR4u4KYea0yByEQJ688M5RsjrPINQgEpNMxyIbbcXBo?=
=?us-ascii?Q?kf3W8c2Tf6R5Tt8AIiybM0wJLwHab3UqycpkuRhsOYmJ6/KvuDmlDLVANKHm?=
=?us-ascii?Q?+QjYZCywDxKMFMAUmRIX71pQdWhpadgd2dpDAKokD1ZCIxIpWDnw/n28POuK?=
=?us-ascii?Q?K0eFDufpnqUpCQIh40bs2NJ7eRgp//lGUrxyPaDJz2/p06yKLYooq+kuDXlx?=
=?us-ascii?Q?0UF3zU87oKxj/GgUYI/+ppEuI2H1jg2RpFj77O7c8Bv+iiGfEChh2y6dxWY7?=
=?us-ascii?Q?FqQZWjuF3wD/KJQAh5me4jDVTBM6tUcgTNncL08LWSlWncNhQH93mAfsYe9x?=
=?us-ascii?Q?aKComyZLEBehg+ZvijsS0sColWpASNncyB9gsl6lwGKlMnLE/QL/MnLAsovj?=
=?us-ascii?Q?qrcaqN2XfVC+L7ztChw1FyjWQkUIidICwxhQosdCPgYUl/0VvF629M6itlJf?=
=?us-ascii?Q?AdpQ2SCnkBxM2RJpXVVfnLOQZUaknEo0U9WRSHLUGGeI8GZICMpHCydSE+Pt?=
=?us-ascii?Q?W2ePmGnXa/oqjmOabU40Q5WWmYryQnjEnmDPd7TOnrUfvFGQv5Kon8LLxjy0?=
=?us-ascii?Q?CXVE4/1ezWdUnBuQ2LaGaGpQZqJjU3jrR0GCAieLuytsTy2RRQzLXZj3kKKT?=
=?us-ascii?Q?BA64eImpAFiM71FZvCnKJ3sVIlgk7utAYPQVI5xFC8riu/VEpmGUw/BvEMEW?=
=?us-ascii?Q?z6sUq+lHZ4LApJXyKPLmDVqh82RK/c51zB/dFl4o+BLUTEUDmgpWmb5HCaIY?=
=?us-ascii?Q?7Wnx/MLJJiSsLqvtg4FGXT3sQzgKcOuTmJWK6DsbYSUBOpE0D+DH9n2FdtwV?=
=?us-ascii?Q?uSjUhVzqUVKav2uH8k2e/R78EFqw8fZ5HTktnnCTn/lkS/iEyePbAzBwEFpG?=
=?us-ascii?Q?ssfBS9NIeSov7RBvpGTC6oSCZ0UAfw/+VOGrV0ujtKQLpYrx9WnZzZOcguwv?=
=?us-ascii?Q?XGDJ9gcObfB2kncqRO1OA6Ffg1Jp3oXoTFwFHIF?=
X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2517;
6:wF4TslMLV9+5AKfkLiL8qss1wvrkhh8wXbZt4XO3mZbYzNxAD975mfu9DZoHIzpvM3RGQpQOsbdfTtbcaBXeE16974zTEqotEZZOKa06Qn8k2ergfyciVgyiAEmb01QbjwnJt+lvMdPIharRmjIkw0mS0pVcEj90iwjEKZIWaYwkoxVcyuLei29MPLkga0If5WGEYU7QlJmNh2lL7vq09dFx/l6hzyAVQ54r1VucF+2eKcjz5uIf2lOdK/Ew72WHHJLdfwi8Yy85Nxumxh/BMtGqUunLrZqqhOf9Z45Iccvrecfvgc82wn2ldYM0cRG5SeihxsZo3JX+3l2sBCsEDspcrayA9d6/59E/xHdUCVY=;
5:74RivOgxI9KHey1pVrDiA3QDLZGKbi2XeOjE+1n2RSWZWxeDKkko7HxxzP9b3L1FN/hG/mlfcR7umySNCGs525lZt8V8PxY2GxJ0/Ds/juGNOD+NhKZfS2I5AKYtdp6QGeJRV7OhFCr1opsPuiyxQePjTd5h7E7zdnMu83Ine2g=;
24:WhaI+GXb8vcxIEmZFbwDHDmzrTBpI8yW++rkCJ3dkPywGJE3ESfiX3X9iKbTUU4QW0wOmyPfLwyTQGiOosfzi/v0RMhiNVW9r5a1ZqxlfjU=;
7:blSthKAZGa++SkUEDnc6MEOvxJdfB7D/0hfP8m5UbjckwDe+bhNc1qudb07sW3MJBk21DNI7ImWqT30Rle1cs3x3wLINL2ydAKlyx7VaOZhrge6FQYjCEy7JHXGCsfHz9vhM5k4Zz6ctYx/bfXa2PtMWpTp4KTVqi2+Bah6BdrAa5C712aYDeJW4lWVpqdjw18mx3lsnV9ypEuoHLyXp0osnftz2WXey5O1Ij8hVSKuYKOF1i+vqIhL6bHhBXw+L
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2017 15:42:09.6057 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 30f4e928-897a-42d2-9861-08d53cbfeb49
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2517
Subject: Re: [dpdk-dev] [RFC PATCH v5 3/5] eventtimer: add config variable
for adapter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2017 15:42:14 -0000
-----Original Message-----
> Date: Fri, 1 Dec 2017 14:00:56 -0600
> From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> To: pbhagavatula@caviumnetworks.com
> CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, nipun.gupta@nxp.com,
> hemant.agrawal@nxp.com
> Subject: [RFC PATCH v5 3/5] eventtimer: add config variable for adapter
> X-Mailer: git-send-email 1.7.10
>
> This commit introduces a configuration variable that can
> be used to enable or disable compilation of the event timer
> adapter.
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> config/common_base | 1 +
> drivers/event/sw/sw_evdev.c | 4 ++++
> lib/librte_eventdev/Makefile | 6 +++---
> lib/librte_eventdev/rte_eventdev_pmd.h | 6 ++++++
> 4 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/config/common_base b/config/common_base
> index 91a2f0f..09d2a62 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -574,6 +574,7 @@ CONFIG_RTE_LIBRTE_EVENTDEV=y
> CONFIG_RTE_LIBRTE_EVENTDEV_DEBUG=n
> CONFIG_RTE_EVENT_MAX_DEVS=16
> CONFIG_RTE_EVENT_MAX_QUEUES_PER_DEV=64
> +CONFIG_RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER=y
IMO, We can remove this option to remove conditional compilation
code introduced in this patch.
> CONFIG_RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER_DEBUG=n
How about reusing CONFIG_RTE_LIBRTE_EVENTDEV_DEBUG to support
the above comment. Rx adapter does the same thing, IMO, It is worth to
follow that.
>
> #
> diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> index 94da675..69050cf 100644
> --- a/drivers/event/sw/sw_evdev.c
> +++ b/drivers/event/sw/sw_evdev.c
> @@ -435,6 +435,7 @@ sw_eth_rx_adapter_caps_get(const struct rte_eventdev *dev,
> return 0;
> }
>
> +#ifdef RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER
> static int
> sw_timer_adapter_caps_get(const struct rte_eventdev *dev,
> uint64_t flags,
> @@ -450,6 +451,7 @@ sw_timer_adapter_caps_get(const struct rte_eventdev *dev,
>
> return 0;
> }
> +#endif
>
> static void
> sw_info_get(struct rte_eventdev *dev, struct rte_event_dev_info *info)
> @@ -771,7 +773,9 @@ sw_probe(struct rte_vdev_device *vdev)
>
> .eth_rx_adapter_caps_get = sw_eth_rx_adapter_caps_get,
>
> +#ifdef RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER
> .timer_adapter_caps_get = sw_timer_adapter_caps_get,
> +#endif
>
> .xstats_get = sw_xstats_get,
> .xstats_get_names = sw_xstats_get_names,
> diff --git a/lib/librte_eventdev/Makefile b/lib/librte_eventdev/Makefile
> index f3f05c2..2e47fa5 100644
> --- a/lib/librte_eventdev/Makefile
> +++ b/lib/librte_eventdev/Makefile
> @@ -45,7 +45,7 @@ LDLIBS += -lrte_eal -lrte_ring -lrte_ethdev -lrte_hash
> SRCS-y += rte_eventdev.c
> SRCS-y += rte_event_ring.c
> SRCS-y += rte_event_eth_rx_adapter.c
> -SRCS-y += rte_event_timer_adapter.c
> +SRCS-$(CONFIG_RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER) += rte_event_timer_adapter.c
>
> # export include files
> SYMLINK-y-include += rte_eventdev.h
> @@ -54,8 +54,8 @@ SYMLINK-y-include += rte_eventdev_pmd_pci.h
> SYMLINK-y-include += rte_eventdev_pmd_vdev.h
> SYMLINK-y-include += rte_event_ring.h
> SYMLINK-y-include += rte_event_eth_rx_adapter.h
> -SYMLINK-y-include += rte_event_timer_adapter.h
> -SYMLINK-y-include += rte_event_timer_adapter_pmd.h
> +SYMLINK-$(CONFIG_RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER)-include += rte_event_timer_adapter.h
> +SYMLINK-$(CONFIG_RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER)-include += rte_event_timer_adapter_pmd.h
>
> # versioning export map
> EXPORT_MAP := rte_eventdev_version.map
> diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h b/lib/librte_eventdev/rte_eventdev_pmd.h
> index 321aef2..91e1f47 100644
> --- a/lib/librte_eventdev/rte_eventdev_pmd.h
> +++ b/lib/librte_eventdev/rte_eventdev_pmd.h
> @@ -52,7 +52,9 @@ extern "C" {
> #include <rte_malloc.h>
>
> #include "rte_eventdev.h"
> +#ifdef RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER
> #include "rte_event_timer_adapter_pmd.h"
> +#endif
>
> /* Logging Macros */
> #define RTE_EDEV_LOG_ERR(...) \
> @@ -467,6 +469,7 @@ typedef int (*eventdev_eth_rx_adapter_caps_get_t)
>
> struct rte_event_eth_rx_adapter_queue_conf *queue_conf;
>
> +#ifdef RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER
> /**
> * Retrieve the event device's timer adapter capabilities, as well as the ops
> * structure that an event timer adapter should call through to enter the
> @@ -497,6 +500,7 @@ typedef int (*eventdev_timer_adapter_caps_get_t)(
> uint64_t flags,
> uint32_t *caps,
> const struct rte_event_timer_adapter_ops **ops);
> +#endif
>
> /**
> * Add ethernet Rx queues to event device. This callback is invoked if
> @@ -683,8 +687,10 @@ struct rte_eventdev_ops {
> eventdev_eth_rx_adapter_stats_reset eth_rx_adapter_stats_reset;
> /**< Reset ethernet Rx stats */
>
> +#ifdef RTE_LIBRTE_EVENTDEV_TIMER_ADAPTER
> eventdev_timer_adapter_caps_get_t timer_adapter_caps_get;
> /**< Get timer adapter capabilities */
> +#endif
> };
>
> /**
> --
> 2.6.4
>