From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 76766293B for ; Thu, 7 Dec 2017 11:39:42 +0100 (CET) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 02:39:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,372,1508828400"; d="scan'208";a="799504" Received: from deepin-15.sh.intel.com (HELO debian-xvivbkq) ([10.67.104.165]) by orsmga007.jf.intel.com with ESMTP; 07 Dec 2017 02:39:40 -0800 Date: Thu, 7 Dec 2017 18:39:11 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: yliu@fridaylinux.org, dev@dpdk.org Message-ID: <20171207103910.teanypvlo6jdk2hx@debian-xvivbkq> References: <20171207053059.19487-1-tiwei.bie@intel.com> <20171207053059.19487-5-tiwei.bie@intel.com> <7de90139-bf6f-24e8-9ab5-c1c666f28ccb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7de90139-bf6f-24e8-9ab5-c1c666f28ccb@redhat.com> User-Agent: NeoMutt/20170609 (1.8.3) Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: remove redundant macro definitions for vector Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 10:39:42 -0000 On Thu, Dec 07, 2017 at 10:18:14AM +0100, Maxime Coquelin wrote: > On 12/07/2017 06:30 AM, Tiwei Bie wrote: > > RTE_VIRTIO_VPMD_RX_BURST and RTE_VIRTIO_VPMD_RX_REARM_THRESH > > have been defined and used in virtio_rxtx_simple.h, but are > > defined agained in virtio_rxtx_simple_*.c. It just happens to > s/agained/again/ > Thanks! Best regards, Tiwei Bie > > work. So remove the redundant definitions from the *.c files. > > > > Signed-off-by: Tiwei Bie > > --- > > drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 -- > > drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 -- > > 2 files changed, 4 deletions(-) > > Apart from above typo: > > Reviewed-by: Maxime Coquelin > > Thanks, > Maxime