From: Olivier MATZ <olivier.matz@6wind.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: ferruh.yigit@intel.com, thomas@monjalon.net, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex
Date: Thu, 7 Dec 2017 14:14:21 +0100 [thread overview]
Message-ID: <20171207131420.akn4ufczkno57yl3@glumotte.dev.6wind.com> (raw)
In-Reply-To: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com>
On Wed, Nov 22, 2017 at 02:58:04PM +0530, Pavan Nikhilesh wrote:
> Update legacy log types regex strings used for registering dynamic logs.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> Note:
> This patchset is based on patch set
> http://dpdk.org/dev/patchwork/patch/31443/
> followed by ml discussion
> http://dpdk.org/ml/archives/dev/2017-November/081953.html
>
> lib/librte_eal/common/eal_common_log.c | 39 +++++++++++++++++-----------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
> index e894b75ec..fa9ac7247 100644
> --- a/lib/librte_eal/common/eal_common_log.c
> +++ b/lib/librte_eal/common/eal_common_log.c
> @@ -219,26 +219,27 @@ struct logtype {
> };
>
> static const struct logtype logtype_strings[] = {
> - {RTE_LOGTYPE_EAL, "eal"},
> - {RTE_LOGTYPE_MALLOC, "malloc"},
> - {RTE_LOGTYPE_RING, "ring"},
> - {RTE_LOGTYPE_MEMPOOL, "mempool"},
> - {RTE_LOGTYPE_TIMER, "timer"},
> + {RTE_LOGTYPE_EAL, "lib.eal"},
> + {RTE_LOGTYPE_MALLOC, "lib.malloc"},
> + {RTE_LOGTYPE_RING, "lib.ring"},
> + {RTE_LOGTYPE_MEMPOOL, "lib.mempool"},
> + {RTE_LOGTYPE_TIMER, "lib.timer"},
[...]
I agree it's much better to have the library prefixed by "lib.".
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2017-12-07 13:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 9:28 Pavan Nikhilesh
2017-11-22 9:28 ` [dpdk-dev] [PATCH 2/3] eal: update default log levels Pavan Nikhilesh
2017-12-07 13:15 ` Olivier MATZ
2017-11-22 9:28 ` [dpdk-dev] [PATCH 3/3] logs: remove log level config option Pavan Nikhilesh
2017-12-07 13:21 ` Olivier MATZ
2017-12-07 14:07 ` Pavan Nikhilesh Bhagavatula
2017-12-08 15:37 ` Olivier MATZ
2017-11-22 22:57 ` [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Ferruh Yigit
2017-12-07 13:14 ` Olivier MATZ [this message]
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 2/3] eal: update default log levels Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option Pavan Nikhilesh
2017-12-12 16:36 ` Olivier MATZ
2018-01-12 15:46 ` Thomas Monjalon
2018-01-12 15:52 ` Pavan Nikhilesh
2018-01-12 16:08 ` Thomas Monjalon
2018-01-17 13:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207131420.akn4ufczkno57yl3@glumotte.dev.6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).