From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 67882293B for ; Thu, 7 Dec 2017 14:14:33 +0100 (CET) Received: from core.dev.6wind.com (unknown [10.0.0.1]) by proxy.6wind.com (Postfix) with ESMTPS id 8962010F9D7; Thu, 7 Dec 2017 14:06:28 +0100 (CET) Received: from [10.16.0.195] (helo=6wind.com) by core.dev.6wind.com with smtp (Exim 4.84_2) (envelope-from ) id 1eMw0L-0002xM-Si; Thu, 07 Dec 2017 14:14:22 +0100 Received: by 6wind.com (sSMTP sendmail emulation); Thu, 07 Dec 2017 14:14:21 +0100 Date: Thu, 7 Dec 2017 14:14:21 +0100 From: Olivier MATZ To: Pavan Nikhilesh Cc: ferruh.yigit@intel.com, thomas@monjalon.net, dev@dpdk.org Message-ID: <20171207131420.akn4ufczkno57yl3@glumotte.dev.6wind.com> References: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 13:14:33 -0000 On Wed, Nov 22, 2017 at 02:58:04PM +0530, Pavan Nikhilesh wrote: > Update legacy log types regex strings used for registering dynamic logs. > > Signed-off-by: Pavan Nikhilesh > --- > Note: > This patchset is based on patch set > http://dpdk.org/dev/patchwork/patch/31443/ > followed by ml discussion > http://dpdk.org/ml/archives/dev/2017-November/081953.html > > lib/librte_eal/common/eal_common_log.c | 39 +++++++++++++++++----------------- > 1 file changed, 20 insertions(+), 19 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c > index e894b75ec..fa9ac7247 100644 > --- a/lib/librte_eal/common/eal_common_log.c > +++ b/lib/librte_eal/common/eal_common_log.c > @@ -219,26 +219,27 @@ struct logtype { > }; > > static const struct logtype logtype_strings[] = { > - {RTE_LOGTYPE_EAL, "eal"}, > - {RTE_LOGTYPE_MALLOC, "malloc"}, > - {RTE_LOGTYPE_RING, "ring"}, > - {RTE_LOGTYPE_MEMPOOL, "mempool"}, > - {RTE_LOGTYPE_TIMER, "timer"}, > + {RTE_LOGTYPE_EAL, "lib.eal"}, > + {RTE_LOGTYPE_MALLOC, "lib.malloc"}, > + {RTE_LOGTYPE_RING, "lib.ring"}, > + {RTE_LOGTYPE_MEMPOOL, "lib.mempool"}, > + {RTE_LOGTYPE_TIMER, "lib.timer"}, [...] I agree it's much better to have the library prefixed by "lib.". Reviewed-by: Olivier Matz