From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0075.outbound.protection.outlook.com [104.47.38.75]) by dpdk.org (Postfix) with ESMTP id BF16329CA for ; Thu, 7 Dec 2017 15:07:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QTnYwB4bY1N9AVbsVXLOwN7YyqQocut2j/mhFdTgVbk=; b=o1SKEj5ZadpAuvci42zSzPlyqC5/00k4wuUQaWrWC55nDHLVW4UZE219+1rgN0aFR5jyMSOmsv9ShTvtMew7yW+lo0HgxA9JHTnN3NecYQh/YPB21IAUpMo5fgUidmgaTMr+l/OE14wBJGKKuKQE2q3omJqCEC+52AW6lSuPm8w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by DM5PR07MB3467.namprd07.prod.outlook.com (10.164.153.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Thu, 7 Dec 2017 14:07:33 +0000 Date: Thu, 7 Dec 2017 19:37:14 +0530 From: Pavan Nikhilesh Bhagavatula To: Olivier MATZ , ferruh.yigit@intel.com, thomas@monjalon.net Cc: dev@dpdk.org Message-ID: <20171207140713.d6s5mh6ggncs3b3p@Pavan-LT> References: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com> <20171122092806.17194-3-pbhagavatula@caviumnetworks.com> <20171207132120.nwrshnurnn74qhsg@glumotte.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207132120.nwrshnurnn74qhsg@glumotte.dev.6wind.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SG2PR06CA0143.apcprd06.prod.outlook.com (10.175.208.149) To DM5PR07MB3467.namprd07.prod.outlook.com (10.164.153.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf63f3a2-52f0-4c36-1ad7-08d53d7bdd70 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286); SRVR:DM5PR07MB3467; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 3:560894CfJ5j6/UNBxT5N8LG0XnoUK2Bj4c27Zi3WpWnUSMAxu0xkMXA1z3OA8SMONLk0+pLnjsBurY8ynCRqtT/cmXwNwE8iytkvwM5YR3lPWcAkVYRbT3fXUc3wd6Tcb3bhIjdVj7gx/dIvO9H3cHu0T6xoaEiWg0uKYrdDyR9AYfdB6BKkhOppbQHZzPOyFa+5S8vTKGik83Z2J3aMSR9MEKOt3dX14xUVTe1S9HaEbvEE2b3gDqOQvEee758Y; 25:OVOqd5gNdSUBEKj4zX2+MUcJrLAJuYRImMm+L3DdWp/vi2HOlodoh+yKZ0wRLwBnyUY7g3yJ/HGPtvz+NyPkRjDeDTlYo6kaKFEL7bSbSx2jfMJDIdu9HR2pqM6DYLdL/dzGiLeFb6xDv4dFU9b4lojPUZzZemNoFGgTCCjWYKT84K3Zj06RixM6hujpiKS9hvxW4+cIWlvoZBjHinfdTTs7Y+1tFDtOj7mgsYBpwfrlU9Jp5gq8D3X1F3112tqvU+PxKsPc20wYvC+Twi8CPdGp0shIWFHq+kyYHOyEodyu5zkKJiSlLikWt9+7GwGz9o+LVCpDNdpJh3bJG5D5Yg==; 31:8zlas20PoTLXJL+HxJvoemyYjL3uF0FJs/L/fI512yz7fXl6icG70kj1gO/wOz3M0T+yb4qmUHgtvjbncNv6Hwg6PgDdasX5sNVrZsGJkC5+wzeeD47caibvzdq8Vksc/9JFzGh3Oh2aPLeYgqWs05D8eQjmKCJQe7jde9iGi2F77wmXO7CQxf4qA3sGM94ZFZtqKB5DPbKvfBBma+SmACLk1vWQzOCPb0k8QYt1SUs= X-MS-TrafficTypeDiagnostic: DM5PR07MB3467: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 20:4K/sMFMuFDyTzEtE4nFgEaQPqc+2dfJafTsSN6k8Q21MTKBkEip3ELFYGA+Scla+nO1o9gSBcIBHL8GPIidib8ofgfhfYcihxrvGwtWkpJajvuephP1oyna2lb0x7T6YqCBgtIyyn8NJlDlYTiQDj9gwn1nCU2lODA+65w4RedPbVTX3GYEWRVIkCUI0RBGJjc1AKxBmEZLoMZhiVV7I80wxAVWj8BqLy+hqTd6Y2NpRV0wL3AvLSSnyjzLsBHAq/MXfB7fGowHqF2CXzvlIvrSgVI6FEm2xohF6Q7W+4TZbzVVYUqZ8AyhxvQwzH3RiBMU4dNQvWIGMbiruhy9Za6WdCwvsr5zq6HTyjV/G921nSDsKg0LWeYSMqI4HxABIRCEzSlJMpOzMMeSm38ECRK7LTQbJoycTw8ZH6Ozunggaip7vTKNJ3O9tAnORuIqFBbqWk81sgUun64TjwhSEyMVYFpPVPOcNxOmDkXbWbcuhGSUdOnROAoypjMxGMS80NQx0T6TtrpjJFFzXQ2j5wbFRbv0BpX+Z29OQHNDREQddxdpS+mhqLqIrVmof6TswhZa0g/hO2y8kdYPSbyd69db4RwAjxqd7e6J3m2RKe4g=; 4:/rLhZEaoUYGbI4MwzsxdNF3dq9kmZq7oj5+nv825SJRFZdf2EMwTi6smbAXL80RWnD94UL3VLgS8lXROLJMYXIu919qrlBEEuMsizaAAflgoM0ZiztwA3zlq5dQFrckxcP+qx1rnQvI6cI2XSLtr1oreAXowaPxxZDaxKLDe9hfikbAyY9JLqOlUOW9W/MNYAqn3POTsx0bl6ntYa9WGnZBLdZ2wSb9L45ovKhmfZDstvW4yyLZzOU04WLjVVvSoyHwamzkqMqvikG47gG0de0p4ohFnjIeKmpmK2iOks06pUGwd3izYU0A+A6X1w36B X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231022)(93006095)(6041248)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011); SRVR:DM5PR07MB3467; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR07MB3467; X-Forefront-PRVS: 05143A8241 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(24454002)(51914003)(189003)(199004)(5660300001)(2906002)(106356001)(105586002)(16526018)(47776003)(33716001)(72206003)(16586007)(316002)(58126008)(5009440100003)(229853002)(66066001)(478600001)(68736007)(42882006)(2950100002)(8936002)(6496006)(25786009)(55016002)(6116002)(6246003)(3846002)(101416001)(52116002)(50466002)(53936002)(23726003)(1076002)(81156014)(97736004)(81166006)(7736002)(33646002)(33896004)(8676002)(76176011)(83506002)(9686003)(4326008)(305945005)(6666003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3467; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3467; 23:uLe6aMX0AyC6cU44qZDD8TUpf/5Tq7qxJ7oGZAaCn?= =?us-ascii?Q?eN9Fin496J6neXKLSVO1lJ7+bXvyqCKQhtJrPyeci835+0aoIhtIP+/bco4W?= =?us-ascii?Q?EM62oXHmDW05p8qlgx9SkEPjSbWnzoLTpFvA84lIVJUtvy2ElWv15CYWulWP?= =?us-ascii?Q?tVIi3xBY6nFPCgtY1EXAixdtAoacoVnKZcpkBMNzTENM48TBoE/SWXBzciij?= =?us-ascii?Q?knvrg9hQDkewxkykhSXkUFv60OEi70+fO+vsjLa+XgZNdPfZxQJQEOm3Kyfm?= =?us-ascii?Q?HvXWVRmOgEkaRTLPR1+Q2t4LZUA//5ueYid8bJ8p0+wLlnsRvCausVwcEwE4?= =?us-ascii?Q?VtLucL1wHsEqscbstMrCn7HHG8AsdOqXc/WWPvg7X1/9SlQ5MHq/XsTHoxnl?= =?us-ascii?Q?xS2RVG7cgAfkd7zbWXCfhSu5d1zl35CNWWKjhAgoSRzTihr/NzmXxaW7PMMJ?= =?us-ascii?Q?KnhQNAss2qr5GwoSCcPgmVqGgnUIo0UlmfYIExmLJxSLjE7X17QK85cXlzrN?= =?us-ascii?Q?C5AzulTuQ6wA3jRbJfxc36hhRQTKbqw9oKONnI/CDNtSO0HkWEG9B1rGatWc?= =?us-ascii?Q?Q03mWeJUEFCeXmOQahpc8PEdiiT3cDGHIhTbs3QvXsqewhG2RqlFiCdMg+/z?= =?us-ascii?Q?+t5KlFRMM9XlEwrfpF1mg7+rlI4Lq/+oi7smVy208gaChQnfXxXqeRomDH6c?= =?us-ascii?Q?FoLFeT0X92QoxrXpHZE6Ov0b8dvRTFs3soJUi7c/3h5hpYMaXKv11kWe0eYx?= =?us-ascii?Q?LoLdJZytC0RrWARLNyWPg6rklAB61IG17B9YeM9SR+kSXfjvCV5CBzwUgi4D?= =?us-ascii?Q?8s7EZ9W0Cv8Si3z0h7m4eKk50ROO3VUw4fFuX894xcPNDpN7iOJ7e7SwAFsF?= =?us-ascii?Q?dfY0Np/IC1IOMcDTJ80ir5QldCq0L24a24V51u4D4gK7euC12691g4hWD5az?= =?us-ascii?Q?CdWgMfM48RgqBXhAF5NC8QgZ2UuNSl0QQfsNPyuibVcTvI/sW0+o+7l0Z2g2?= =?us-ascii?Q?ronb4pe9r32ko/DqmTKq2Ie59yOldWmorxPxd4GoZQ2ul1jAaykXW3dSzme/?= =?us-ascii?Q?waY3PB2BnnbV6/cpIWHMX9Vykf63FcHLsW4Xe8BY607Py8XARtdFRa8JTNqM?= =?us-ascii?Q?22Pdg7Rup9f5BugR0o0GKtt1pPsFMDXPupT2iUyDscNYdrDAZV8TscdU262J?= =?us-ascii?Q?IciqFRGaGpk44oreVPfp/PVZmbugTl1j68u?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 6:qZ7lEUD1xLdAgYhlzdx0hztmF28ilxss3GG4+NV3olUt5EGtNWBDuHAviOPR7uWDZmb3MEEf4WoO5p2SYSLBTvezDawHe0S1QEaSqyLD5ru3W1CzWWiE+6CqX3i8ZIkKmQmyyXrUYRNR4C5zucpzmBDLYca7nSkroLghuzeYc+jJjTxzepKlAFeNM/wncuofqdrmzUyBPYxH7WpYBOVk/C/8b67xiVAsEkDbIg/3erObWqueAQoStYtF4wv87q4qlmhqjvkC4uvatp0fRRNROD79jUf7F+h15pm2eg45oQ6KoJ91Uq9nvi/LPhXRJLhBG1/FL1mPZ1scVgd/R3ctB/42TudTwqkgtOTuso/7Ts0=; 5:+oWiDqpnUwJFDz9eWDNpjJAtO3MtzpXYQ5EUvt9ZToZ81jcEwNLui5qCfM0ibt2FT6ivbz1tYVO36gcLoTKvMUOobIFxZrGlJd1QhKJmujpyBxNFIjV975e8rGI+XtILV6n6smMqpeCJMAzC/fBXT6WxxZbuOLt7oxVCFNOXq20=; 24:p0Sw6uJFIue0Bps6vNPptORV1YoDCECE0StVtQxUj6PzzL0LOMBDbhGssm573roCqNLZXKoA43E+AiryJdtUG6QtN4o5BzhdNJsT6dPHFrA=; 7:2i8Fv2BWnFT07Yl54wD5YTHmYza8AXwPayAQOJcYMyIBrxFFsYJytKTUt+nY8yrPBoEbGkSKpAWU7RBEqUQbIvoFrr/6gnqHO8GHgbXJXwsPsKXXjV8i20KwQ42G9ABmjZ/GIGHi6pXUjZj6N06zVvboxnh+trSdf0jHKxAjhcSRUz09PfCB8d3lW9DgshSOcSbErL0iN9lT4NXdw8pBZTaQYNNJG0y6bKnsZwjY5Db/N+h3XiqV1bdSli0x20Df SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2017 14:07:33.1301 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf63f3a2-52f0-4c36-1ad7-08d53d7bdd70 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3467 Subject: Re: [dpdk-dev] [PATCH 3/3] logs: remove log level config option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 14:07:36 -0000 Hi Oliver, Thanks for the review. On Thu, Dec 07, 2017 at 02:21:21PM +0100, Olivier MATZ wrote: > On Wed, Nov 22, 2017 at 02:58:06PM +0530, Pavan Nikhilesh wrote: > > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config > > option for controlling datapath log level. > > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to > > control global and module specific log levels. > > > > Signed-off-by: Pavan Nikhilesh > > Tome, removing the RTE_LOG_LEVEL goes in the good direction (less > compile-time options). > > [...] > > > --- a/drivers/net/ena/base/ena_plat_dpdk.h > > +++ b/drivers/net/ena/base/ena_plat_dpdk.h > > @@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t; > > #define ENA_GET_SYSTEM_USECS() \ > > (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz()) > > > > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG > > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG > > #define ENA_ASSERT(cond, format, arg...) \ > > do { \ > > if (unlikely(!(cond))) { \ > > diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h > > index 92eba9c38..3f9ccf1e6 100644 > > --- a/drivers/net/sfc/sfc_debug.h > > +++ b/drivers/net/sfc/sfc_debug.h > > @@ -35,7 +35,7 @@ > > #include > > > > #ifdef RTE_LIBRTE_SFC_EFX_DEBUG > > -/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check > > +/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check > > * in the driver only. > > */ > > #define SFC_ASSERT(exp) RTE_VERIFY(exp) > > diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c > > index e50b1a1a8..eb78decdd 100644 > > --- a/examples/l3fwd-acl/main.c > > +++ b/examples/l3fwd-acl/main.c > > @@ -68,7 +68,7 @@ > > #include > > #include > > > > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG > > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG > > #define L3FWDACL_DEBUG > > #endif > > #define DO_RFC_1812_CHECKS > > diff --git a/test/test/test.h b/test/test/test.h > > index 08ffe949c..8fdb3045e 100644 > > --- a/test/test/test.h > > +++ b/test/test/test.h > > @@ -204,7 +204,7 @@ struct unit_test_case { > > > > #define TEST_CASES_END() { NULL, NULL, NULL, NULL, 0 } > > > > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG > > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG > > #define TEST_HEXDUMP(file, title, buf, len) rte_hexdump(file, title, buf, len) > > #else > > #define TEST_HEXDUMP(file, title, buf, len) do {} while (0) > > For drivers, it looks correct to replace RTE_LOG_LEVEL by > RTE_LOG_DP_LEVEL, from what I see it's about dataplane logs. > > For l3fwd, I'm less sure, but it could make sense too. > > For test, I think we should replace TEST_HEXDUMP() by a function > that checks the runtime log level instead of relying on RTE_LOG_DP_LEVEL. > I can submit a patch for this. Agreed. Pavan > > Olivier