From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id E7823199B3 for ; Fri, 8 Dec 2017 11:27:23 +0100 (CET) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id C2C68110165 for ; Fri, 8 Dec 2017 11:19:16 +0100 (CET) From: Olivier Matz To: dev@dpdk.org Date: Fri, 8 Dec 2017 11:26:57 +0100 Message-Id: <20171208102657.2699-5-olivier.matz@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171208102657.2699-1-olivier.matz@6wind.com> References: <20171208102657.2699-1-olivier.matz@6wind.com> Subject: [dpdk-dev] [RFC 4/4] eal: set affinity for control threads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 10:27:25 -0000 The management threads must not bother the dataplane or service cores. Set the affinity of these threads accordingly. Signed-off-by: Olivier Matz --- lib/librte_eal/common/eal_common_thread.c | 20 +++++++++++++++++++- lib/librte_eal/common/include/rte_lcore.h | 4 +++- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c index b4335e04e..f1798cebc 100644 --- a/lib/librte_eal/common/eal_common_thread.c +++ b/lib/librte_eal/common/eal_common_thread.c @@ -45,6 +45,7 @@ #include #include +#include "eal_private.h" #include "eal_thread.h" RTE_DECLARE_PER_LCORE(unsigned , _socket_id); @@ -199,7 +200,9 @@ int rte_ctrl_thread_create(pthread_t *thread, const char *name, .start_routine = start_routine, .arg = arg, }; - int ret; + unsigned int lcore_id; + rte_cpuset_t cpuset; + int set_affinity, ret; pthread_barrier_init(¶ms.launched, NULL, 2); pthread_barrier_init(¶ms.configured, NULL, 2); @@ -216,6 +219,21 @@ int rte_ctrl_thread_create(pthread_t *thread, const char *name, goto fail; } + set_affinity = 0; + CPU_ZERO(&cpuset); + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + if (eal_cpu_detected(lcore_id) && + rte_lcore_has_role(lcore_id, ROLE_OFF)) { + CPU_SET(lcore_id, &cpuset); + set_affinity = 1; + } + } + if (set_affinity) { + ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset); + if (ret < 0) + goto fail; + } + pthread_barrier_wait(¶ms.configured); return 0; diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h index f7f67868c..0d85a91a8 100644 --- a/lib/librte_eal/common/include/rte_lcore.h +++ b/lib/librte_eal/common/include/rte_lcore.h @@ -265,7 +265,9 @@ int rte_thread_setname(pthread_t id, const char *name); /** * Create a control thread. * - * Wrapper to pthread_create() and pthread_setname_np(). + * Wrapper to pthread_create(), pthread_setname_np() and + * pthread_setaffinity_np(). The dataplane and service lcores are + * excluded from the affinity of the new thread. * * @param thread * Filled with the thread id of the new created thread. -- 2.11.0