Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item

[Adrien Mazarguil <adrien.mazarguil@6wind.com>]

On Thu, Dec 07, 2017 at 03:52:44PM -0800, Ferruh Yigit wrote:
> On 12/4/2017 6:03 AM, Adrien Mazarguil wrote:
> > On Fri, Dec 01, 2017 at 10:43:15AM +0000, Andrew Rybchenko wrote:
> >> From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> >>
> >> Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API.
> >> Add default mask for the item.
> >>
> >> Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > 
> > Just one remaining nit, please see below. While you could address it through
> > a subsequent patch, you might as well send v3 directly to make things easier
> > for Ferruh.
> > 
> > Otherwise it's all good, thanks.
> 
> May I take this as (for series):
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Sure, thanks.

> >> ---
> >>  doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++
> >>  lib/librte_ether/rte_flow.c        |  1 +
> >>  lib/librte_ether/rte_flow.h        | 30 ++++++++++++++++++++++++++++++
> >>  3 files changed, 43 insertions(+)
> >>
> >> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
> >> index d158be5..5b8f9c5 100644
> >> --- a/doc/guides/prog_guide/rte_flow.rst
> >> +++ b/doc/guides/prog_guide/rte_flow.rst
> >> @@ -980,6 +980,18 @@ Matches an ESP header.
> >>  - ``hdr``: ESP header definition (``rte_esp.h``).
> >>  - Default ``mask`` matches SPI only.
> >>  
> >> +Item: ``GENEVE``
> >> +^^^^^^^^^^^^^^^
> > 
> > Missing "^" under title, this may trigger a warning during documentation
> > generation.
> 
> I can add that one missing '^' while applying, no patch required.

-- 
Adrien Mazarguil
6WIND