From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 68FA0200 for ; Fri, 8 Dec 2017 11:52:52 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id g130so4104936wme.0 for ; Fri, 08 Dec 2017 02:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YagGWdFcO6IfDkKDS5L51I3aQTSeUTWEoA98sQR2Aqk=; b=TEHRUnazgNvf69YZ7Ex86pvonn87xZpsnlpCb/wiiAku9ISfq5Udzy2rSYf5yNPpWc /u2LH7TZB5ofGgvVZ5fjHsRR6xJJOJyFcmT2r2YTB0r3HW7FEHmtDuj8OSi7wqpsZXVL QPN/sCq+YPC3zQ6/bW9qTkf47mU0F4kciP2LyCVUy95wimVE9VsiJnr9LZSgPETE0rPR 5lb4RhZp4J3COFFIsRZ8wwkCzSC7h+1YjjD1HNcBAQHOzcMFffrhvM+Or0hr07cPgM7S u+yv0oBui0QTHMbz5tOj7ok0JZIB036AgPOjfphw+jkgWK8EF6ibYomnkDVvalIJr7cT dBVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YagGWdFcO6IfDkKDS5L51I3aQTSeUTWEoA98sQR2Aqk=; b=ovnd7/Tg9xE4h7WXgtFk5bpyVSZr0drDH5CAdhgEjVsnwg9+fmv9E7eJEoXJKvFASx fAHM5R24iUH+7N4UKYAF5clJdRJpCTJwhcbdrGyvyVndnTTMqDYAc59QgymuMZ+Ahztt q4K5tve2dA33RpYJna+kCAjSR29d4k/K1Ojqrx++Nu+DF3+hu1vCsOdLwyllySPtDTE3 7GWQ3imqQ25kXM3h49B3H6mglPUkkzAAulYGgLWvnAuQuza7i7SoGG3hLPvlr1SR2jwc kwI5bERFp9Wcp417XQscyJcKQgwW14NLj+7GoohIIoC0ZBJR6VOuSiT+Q/CzACKgVqaJ /9Jg== X-Gm-Message-State: AKGB3mImOsGoAo049s2CZdyZlo+gZpbQ0mkxJFz8DuqmoiQWf0RW+czw PFm3jW9zC8tEpQnyoTYalwYgcw== X-Google-Smtp-Source: AGs4zMZnaIughjsot3aUMpmT49RbDzi0TogdJK3fi3OlFzfROL34VFGZYB3sxZFhZusLtPPxAJhc2g== X-Received: by 10.28.234.80 with SMTP id i77mr3540437wmh.76.1512730372034; Fri, 08 Dec 2017 02:52:52 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g99sm8954594wrd.72.2017.12.08.02.52.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Dec 2017 02:52:50 -0800 (PST) Date: Fri, 8 Dec 2017 11:52:39 +0100 From: Adrien Mazarguil To: Ferruh Yigit Cc: Andrew Rybchenko , dev@dpdk.org, Jingjing Wu , Roman Zhukov Message-ID: <20171208105239.GS4062@6wind.com> References: <1511166121-743-1-git-send-email-arybchenko@solarflare.com> <1512124996-13388-1-git-send-email-arybchenko@solarflare.com> <1512124996-13388-2-git-send-email-arybchenko@solarflare.com> <20171204140320.GE4062@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 10:52:52 -0000 On Thu, Dec 07, 2017 at 03:52:44PM -0800, Ferruh Yigit wrote: > On 12/4/2017 6:03 AM, Adrien Mazarguil wrote: > > On Fri, Dec 01, 2017 at 10:43:15AM +0000, Andrew Rybchenko wrote: > >> From: Roman Zhukov > >> > >> Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API. > >> Add default mask for the item. > >> > >> Signed-off-by: Roman Zhukov > >> Signed-off-by: Andrew Rybchenko > > > > Just one remaining nit, please see below. While you could address it through > > a subsequent patch, you might as well send v3 directly to make things easier > > for Ferruh. > > > > Otherwise it's all good, thanks. > > May I take this as (for series): > Acked-by: Adrien Mazarguil Sure, thanks. > >> --- > >> doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++ > >> lib/librte_ether/rte_flow.c | 1 + > >> lib/librte_ether/rte_flow.h | 30 ++++++++++++++++++++++++++++++ > >> 3 files changed, 43 insertions(+) > >> > >> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > >> index d158be5..5b8f9c5 100644 > >> --- a/doc/guides/prog_guide/rte_flow.rst > >> +++ b/doc/guides/prog_guide/rte_flow.rst > >> @@ -980,6 +980,18 @@ Matches an ESP header. > >> - ``hdr``: ESP header definition (``rte_esp.h``). > >> - Default ``mask`` matches SPI only. > >> > >> +Item: ``GENEVE`` > >> +^^^^^^^^^^^^^^^ > > > > Missing "^" under title, this may trigger a warning during documentation > > generation. > > I can add that one missing '^' while applying, no patch required. -- Adrien Mazarguil 6WIND