From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0076.outbound.protection.outlook.com [104.47.40.76]) by dpdk.org (Postfix) with ESMTP id 35E2B7D05 for ; Fri, 8 Dec 2017 12:09:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KX2qpPtVe4fpb3z32MtuHvGl+dhi+/CfYPWmOBfdEAw=; b=WhR0NQUdgMrbjdRy43BytW0Fmv0kzO0kSaxFnopkxhJF52QtiRHMyEKk5JIgGnNsBlWmilKRh+fjiJcMhLe6jqVPNoMvYtsx017dLF+aJhIBnnTl7Npq0eF6GPLotCqIbIfgQTYDxgkiga/t1A/EZPqFz6UKPuES/Y5Ykcuw+yI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by CY4PR07MB3464.namprd07.prod.outlook.com (10.171.252.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Fri, 8 Dec 2017 11:09:39 +0000 Date: Fri, 8 Dec 2017 16:38:08 +0530 From: Pavan Nikhilesh Bhagavatula To: Ferruh Yigit , santosh.shukla@cavium.com Cc: dev@dpdk.org Message-ID: <20171208110807.wafb4z6q74t7hzht@Pavan-LT> References: <20171128145855.27106-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: DM5PR13CA0050.namprd13.prod.outlook.com (10.175.103.140) To CY4PR07MB3464.namprd07.prod.outlook.com (10.171.252.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe25d54b-404b-4d7c-608d-08d53e2c2d9e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:CY4PR07MB3464; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 3:5X1rlYPl8k7ie/G1ftY0590Xa+JKgZFOo4KXD1ntliltCnhpij+lzPVC5ggOe1tt87nnithpaSoGUlgTE2Rv2JLdHXavLljE21weEPbNE0trWMLczG/PRFl/XGICLpD4X7vVae6Qg1BP4kKwoqKkxHYYeBn5h3jATSYUo8O4bTe5H5ECY0VFeI7dN4K5oI92IUdTkm9xRmnnxmALJkB+1Aw4OrW2z95yTSm2tJP6MnP4BE1im/ZtLTj32IzGCxaW; 25:cWwesIDG/uO2YZS/UJdzcyGokk+ASXRYD2ymKbzH9qg5fx0AbKGpX7Ea8YJHhMagIE7VLkycr937aR6VzsRJlFIU/HapH2pgzPh4LbTuvIXhPeKc2Zl2shjPFfEwN95XpupjinDKhxUErsQV5oWvA8Snj7p3/etHMOblFfTFy7RSRv60U2CUvE6UTsthRND2pkgowgJsaPiBKQ/hurn4e9nOMwhup9gUOOa8YlDlw64vfsrnxo1zZJWcqxyfkZgvTRBjkNhdvTw2IfsUHZgHxSKfYg+PkJXl+q4T3Ptn0Qx2ZrAToy89O/wpV8b/j40N2XSHbAWEyBU0jRZtDmm6/w==; 31:SBD/kWL7W+3F+QTbN76XinxPngi16djLKSmeNJk41Wd/mUH0OJAF0deaoL/BbppqfP3gVUvYOY73Om0AJmUuhQ8DYlge5gGZ4ZQ7DvjJnlly6xKET/PmbQAuVZvItqsh8OgnHBAbwjqCXvmBf1OEb0uvl9N8EkgZvP5PMrcZmoclq5fmMtD2hKzL3ztc8WEU0hmAc4GdcQ9NS8usm2nJMRtbiM3xg9jE9kMzOSSWd54= X-MS-TrafficTypeDiagnostic: CY4PR07MB3464: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 20:+u5YoQCiiuyVKdFKGgdJF5XpWq9VAUSAJhUiY6dY5/RJS2cFog29jZi/DRRjU4kfwMkHvcDohC+fp9AdAW9GZFeBKoRt4dyptPYMPDTT7j7pR9qb10wbN//PAB4jG4gOvrejHeRV9t39CJUaf7pJVQzIPNHIpknIxiET9wy90+zXY+BE2nFTnpjcXFfNOuPue9caiimIFTZV5PGj9yp+S5uiR4UNvQPO0YlBNSXIlXzdzjexKmigDrx0NXksm3tlaFkjdRWSX++iM3Br2MXDOyXoDKiHm3nXe20zLeCIdlbUGqDWX4WVI5TGp/sAWlgUCw52RmMvIiIKNhBBkXJY3A3nZgAW+EGFy360pGXlIvnyAZ9y4MPtZ2zsgAoO04NMGOoWZDagKFn3jwCznK+MBR73Kl0DL2cC9x3YSyUOubf3itbSuxWcDO+8Kieh1h2K4YCIHHYeybRht19LxxRRa/ybzx0FLhUUreAI0Hlp46POByAaVpRehA52qtvrSg8nbtTNmY+ImNiHcxUjkFSO7WVQYUpiZMwtH4ACj6aKskjtBaw5FTDnkU2R4hd7xP3FBm68IU4r4sBKLceyITNUTJ0+HYwCiwwTNifJkrdLo3A=; 4:upoYa7iPkROfU4YQMOYnG32QggBQEXwS22E5ogPn+DWB+WJT2KaAMshZ+7Q7G3Z0Q28/vuTIXPMkT3FWMYczdxDtsoNGBb0tQC4URcNvrpD0AxwVvi83rVY0g/Qxe/tqy/i58MuxObaFmgrvbfxOlEmvkISUIwpCaGtxUif0n/JRjfUWfju/WHX7mz7th+bY2YJN/L2Va+xeo5weJaLPWjp2UyvM9nDF0xglgiov+OWARBMFP7uxBs5RM701bWhP0/CXhuC+1g36OU7WL6LyLg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(3231022)(93006095)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(6072148)(201708071742011); SRVR:CY4PR07MB3464; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR07MB3464; X-Forefront-PRVS: 0515208626 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(199004)(24454002)(189003)(305945005)(5009440100003)(55016002)(33716001)(7736002)(52116002)(66066001)(6496006)(83506002)(478600001)(5660300001)(8936002)(229853002)(97736004)(50466002)(4326008)(68736007)(33646002)(23726003)(58126008)(16586007)(33896004)(16526018)(76176011)(3846002)(25786009)(6116002)(2906002)(6666003)(53936002)(316002)(42882006)(8676002)(1076002)(2950100002)(81156014)(53546010)(6246003)(105586002)(72206003)(106356001)(81166006)(47776003)(9686003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3464; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3464; 23:B/ydbWvtVOafclWKo6uZX/rBbzB/U+RagVEf7BiVC?= =?us-ascii?Q?lznRbBEDU2f1Z0TE3ezy96jCD8A5zZ3yZ26IfpOyna+EbzBjPOm6FrRZ+MF7?= =?us-ascii?Q?JHn2qXV1CT9MCVjMUYFqMZbzr6ozF2GP5b3e18lwF6ubd/o1jXZfmVdW6VLl?= =?us-ascii?Q?mvXraf1kzH5QNc1p2nPQZ+ZsL86yKq/57GrrYalmX0rePAHVStPXGq87txBs?= =?us-ascii?Q?mqRGhPHsASp7pv3M+cK3P+BgRm/dtwCbch15LeuV2MwqUVDvl2JtxS1SkXNz?= =?us-ascii?Q?dlpEJMdzzacL4aeABegWuw6E+7GR4ZI2ZYqRskEfOmskGjYR2xyHtcCMkqrY?= =?us-ascii?Q?xXJt7gPfc8DORymSuwE5fLHN9GrHyiBXi74PgXHyWrbgl+9YzAhLbAi54+jN?= =?us-ascii?Q?KTuB2gbOYMa66SQ1zILwTwQ9yiXT2PrLPxmdzpmMxP+aEOFHwfV6bFT4w2oT?= =?us-ascii?Q?kj6Axjhpj2xuP//1dxrHXWQAhAaJjmlRbu2wi+XpSjs+V4IJDhfPIJM+rRYY?= =?us-ascii?Q?zWMxosOdgJj8AHwBLhIiDSaDC+BB2mPXU2HTRa2fCjbwJ802EzDMnbM1k3hU?= =?us-ascii?Q?JrD6ZRkogOHlrfQfyjK05cZuEiDLEWMvAJ5amD1zQybXpx1AKdBCYropBUhg?= =?us-ascii?Q?eE9L3saQXM+3SFT2gnOSN25xCkfTlhxYOzUmc5wB7Jnp1ntsc6n9hkCzdfh8?= =?us-ascii?Q?kO26VOvlPASuiV1VlwqH2HBvf5fGCboISGxX13s1+DoGExjUR3Eabfrel4Gj?= =?us-ascii?Q?FTX6Aqi5oQ065+sFFNkCv1UMn6zvDw62mpdoLo8ysRoPe2VtH4eW9QCb+vST?= =?us-ascii?Q?mg6Ouxrk+loGrayyo49xugYXcpA6cnTu9UuQX8fqlCuI08+xxaEi4GR9nWLm?= =?us-ascii?Q?EtwjqVyDE8QnseGOAvSJJ2WMyFfec+MYETfnrZQJw83GBj7AH9gSFa4oZ0XF?= =?us-ascii?Q?OFxK2BkuG1nXM5fTpA8eTCb/0++TwZ/lEFykAls7qn3YSjuEnslKQjKUoOeY?= =?us-ascii?Q?Lvz0QB9egM5IeAuywnKSPaMUIGxqXxYrswUzMizab2TeLpluHHU/7Rw120zc?= =?us-ascii?Q?cfSlQK6zTZRS6/sZ3ALzQNXs5VxOBPbeiuQDgdABj/tK1YOZUvoiyweTSUAF?= =?us-ascii?Q?JuPGUILTamfB7rHW0n42dOujpxnYZ8/bFWKgIEt4J2uFPJT/TUZoAaXEdi7Y?= =?us-ascii?Q?x9MDewIE78t/Kk=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 6:3lRh7dzTkqfu0Of4MQG40GxPPUeXT29HALgZPRYlEHslxv/Y9p9f5vtMgvKXQhxsQZhD5qLvZyDiNZwrL8qOArRvkisdmPq12rRe93F0Gl+P9r02cDYX4E0QPH2BtVhxzaBiVpKmDJC0BpvZPUUWNuPOpKU/enNQ7cY/7DWIF0gYO/DqRBJuEt4kq+uttE0staERQxbyBleq6HmG582r7prtsli8IDkB4cVxTw8cZHHz9bIPD7xB8lLCe4+Ot3JDYgz2CI3saqUWZyHv90ASGOW80Z2Z8o1UM2LUcCaF3AOID0Ah6H7fFVITpUDkFh4FYjNK4ZDWnZD07jsGEXRYKB7KZXp2jr9EISjlksh5ZRs=; 5:0KBT3EDHB/69TZPKyRzEScihwlSth2dwy/tneJ6tVkcLKw8pezxyM9W6SjVrLrzBpjMpWyirU4dfAWkkqV+aR58qAwC1c7MxYCl4Ru4OZ6et4HEkqHmJN3M/wFXJ7wQYQvQ+n/7RFaYYRknHBQ6YIP2Q1uopTtWP1l2LqQzAd4U=; 24:wi6oVLJ3axDRNTJKHRsALojVs2gp5pSKgA0eGNZEXR/oVsoJ01wMCzCsyMSQZ3KiRYz+ze51DE/nt1k5srCL5BNb+K+u5iOKiWD98XjBMlY=; 7:P95rmUYXeXOgs06kUJxbq+DsvWcfCqVJvzNNZR175WFeAPtLbZCDcVES7DvVo0Jr+jO1OyN7xBfS35BipK1VubUlCamYrBLUcMuAg56KmRk9tCyDWaBYZNtUqktALzuK66bnfHzFSZ5dhQ/teL24tVKI/nxzfwvw/i1FfoDUFxWQxz9z2cr6rPRdpOOIGNm9UFrniU+Kz5RSbgdypFV8rjJglouXnSWmsXYBjz6CYzrovIyL3taT9RKSwOyoebjY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2017 11:09:39.0828 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe25d54b-404b-4d7c-608d-08d53e2c2d9e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3464 Subject: Re: [dpdk-dev] [PATCH 1/2] net/octeontx: add channel to port id mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 11:09:42 -0000 On Thu, Dec 07, 2017 at 04:41:04PM -0800, Ferruh Yigit wrote: > On 11/28/2017 6:58 AM, Pavan Nikhilesh wrote: > > The channel to port id map is used by event octeontx to map the received > > wqe to the respective ethdev port. > > > > Signed-off-by: Pavan Nikhilesh > > <...> > > > @@ -52,12 +52,18 @@ > > #define OCTEONTX_VDEV_NR_PORT_ARG ("nr_port") > > #define OCTEONTX_MAX_NAME_LEN 32 > > > > +#define OCTEONTX_MAX_BGX_PORTS 4 > > +#define OCTEONTX_MAX_LMAC_PER_BGX 4 > > + > > static inline struct octeontx_nic * > > octeontx_pmd_priv(struct rte_eth_dev *dev) > > { > > return dev->data->dev_private; > > } > > > > +uint16_t __rte_cache_aligned > > +octeontx_pchan_map[OCTEONTX_MAX_BGX_PORTS][OCTEONTX_MAX_LMAC_PER_BGX]; > > defining global variable in header is generally not good a idea, is there a > reason why not variable defined in octeontx_ethdev.c and exported here, so that > both octeontx ethdev and eventdev can use it? The reason extern definition in .h and declaration in .c is not done is that it would break shared compilation. The other approach is to do it in octeontx_mempool area but it wouldnt make sense. I could use the mempool approach if it sounds good to you (or) let me know if any alternate approach comes to your mind. > > btw, is build time dependency between octeontx ethdev and eventdev documented > somewhere? Currently, there is no build time dependency between event_octeontx and eth_octeontx i.e everything builds fine with CONFIG_RTE_LIBRTE_OCTEONTX_PMD=n. Thanks, Pavan