From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0085.outbound.protection.outlook.com [104.47.32.85]) by dpdk.org (Postfix) with ESMTP id 66DFC7CBD for ; Sat, 9 Dec 2017 10:27:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RUn3MywTH+5qyb7pWG4D5Iw0lBE7poMwELakgs8+DuM=; b=Zw//9ML6339beOF2iCh9e+CDWsFMdtD2z6PGZ38HfFPoN/zXBH3tyJYmyDRj0DtC/Va9D4Skt1tw3XMcWoR9pUNYCC6z1GQvUkcxZlctGuThORDLX15NBmGbbiBFlHorpvVi91Jr3LvNbtWOGegUjX1eVoUI1MI5D0sUsc6kdEM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.76.104.209) by SN2PR07MB2526.namprd07.prod.outlook.com (10.167.14.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Sat, 9 Dec 2017 09:27:05 +0000 Date: Sat, 9 Dec 2017 14:56:44 +0530 From: Jerin Jacob To: "Van Haaren, Harry" Cc: "Eads, Gage" , "dev@dpdk.org" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "santosh.shukla@caviumnetworks.com" , "pbhagavatula@caviumnetworks.com" Message-ID: <20171209092643.GB13525@jerin> References: <1512011314-19682-1-git-send-email-gage.eads@intel.com> <1512011314-19682-2-git-send-email-gage.eads@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [171.76.104.209] X-ClientProxiedBy: BMXPR01CA0014.INDPRD01.PROD.OUTLOOK.COM (10.174.214.152) To SN2PR07MB2526.namprd07.prod.outlook.com (10.167.14.154) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f8f6bb6-f4cf-47a8-72eb-08d53ee70504 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:SN2PR07MB2526; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 3:vg+/txSevd72mT4dXPrn8NUF3fCPEngvPk8F7jMBTvBojIkx9tkLrzT/POMKdLi+3THCGBJxcQT41wzwtpltJ6RdlVFLrNShM6bt/7HE2j16FhB/yXbLbUS5xbf6a5euriU2bP8kxT1wtopeiwpwuBaby/0ZrRZHyYCRg3NjlZns/MoTwjHZ2OmXqs4yrLdklnIsVAMCo8ooT7Yx2pmGHeAcBUUeVka13ULB66xwnUhwx6t8Q5M+b1s5hci0+jvG; 25:alQlj23kkimo0eOz/+1UX/MABd4LMwg9DkYripRzmuqImr3Mudd+5hPYSLl3BiM2q+SC49hztygiv9v0rSs+/75qqScnN+Rwl2z8dIhPsC5AGUGE310og1KnMieV3sZ0XLb4KqTv1w6wv3guC84ugz59PLRvsE9x0nDQea7M+kdXhWBRyxGl3XrbEp7/nu+5djmsxI7binQtpAkufNQZYC8mfWXwh1JFyinuh5wi/SCJp3wOKQCXwhQ+m1e1jDRkdScPKSGzJ6h37e+d6BS27S1weGCi5GHOPT988yAtYNEY+mavo2joP8XQKuVzTyeXXZRaq9Vb1QhMqbdVXVFSGw==; 31:s5WJVX+cT6p3gLyDxxAGtu1c3pCpM6AIouBT/Izj9s3hzc8aWSverhetghpA/gLJrQozMxlK8wOEzAywsLxkwsZjKusWmvDAE+V0lUaucnZ65q7wMpiBY+lAcDuZ6EQDDmsGYsXJdE8+qtljC6Hxog4zVkbE2w+av2gSPxPgOim3mrC2xE0cePQA6A31g/ggNQ//fzlTs0Z1lFekNeni6ka7GbIiiKoRsu8My4lSL6o= X-MS-TrafficTypeDiagnostic: SN2PR07MB2526: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 20:2wF5LOHHSiH9y7EtQuIH3HmikNZuuO1F7gYrKURDACmV3I0ThGBooXuBvvaUvcYYh8+OuK+ByFq9si+1Evi2GRIg613S5jNkUUnD/Bx7t4Sqn0jMdF15RXLEi1mRmxuWAwnVARZzyEC8/YbPA0oDkk6JfrDx8jFur/s8ZCen+GDwZRKu7wTwC3bwAHe3KQao/+iSMCYta2N07XPyAWpAfwsWaDkUpBHnhZaOQAvLO0e9aFmVqTv1LLq+ssR0aKKoci3s0gG67t/uAO4U7pBf0BYJzI3muJTOnXkUqA3r4yyXNVJJDcYQYSSkmIrTc9OH5iT0VGPJwLXWIZaA3izr64k6Y+CkSz0tW2daL0hm9kxreWPkrRJZDW03kNcGUKXJcgLDfh5JnPi+YX0Hxlsbn4zgcuYL45M0r6HiXnxyTlLNV5myeuOIWTzKY6G5bZ+p5Z8n6ELXqDVJaX1TGioVdPRdeLCSHmj5T9kq+meAxzQQJa9SzQdPyaE7Ct4SkXj+Zgxb5Ba4X9i6gI2tDfDDO8bz4GsXdPrfL8gBy2cFVFQEm/Mv9R9M/jUm6wZjaGLxe6bri0MJ5DqYYPt7cJLg/MFXSMjS62lDY67a/4Reb2w= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231022)(93006095)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(6072148)(201708071742011); SRVR:SN2PR07MB2526; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN2PR07MB2526; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 4:IHYPBNRw44YK3Xb5oesUNpJQOYEXW5pWDGEFV3MUiRDK/66oH7X8LAoqO4g771HvAXXFnvX/vAk3icZXXQC94pL9AIoAgQjjnSmAJVWRqCnGuQ00PZ/Tbs+VGyqn5yqwcQNdBJYsKt9xLJ857xOS+iQdxYC6bdCUyKr9ueaR9hZKzdM9LC+W6qFBiwf+mA5rIXib87V/nB8nrPMMlEzuWL+qH2flC+aklyyTGIMqLS9zLZQGtsH9dcToXHTCTDaeyqQGtwXAZ1Fiu+nE0Z7fWR7KYv/wz+KQ3HopbYfuZ2K5kJg7T8t8l02P9ye9OLOtkFeqmBNK8xqo7Y0AOnSEPUV4AHTtUAUA7ANomzv8k5o= X-Forefront-PRVS: 05168A3970 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(199004)(189003)(13464003)(107886003)(6116002)(55016002)(66066001)(81166006)(4326008)(305945005)(6666003)(8936002)(7736002)(8676002)(6916009)(6246003)(2950100002)(50466002)(42882006)(8656006)(83506002)(97736004)(54906003)(25786009)(68736007)(5660300001)(2906002)(6496006)(316002)(47776003)(76176011)(9686003)(478600001)(3846002)(106356001)(23726003)(1076002)(53546010)(81156014)(105586002)(52116002)(229853002)(72206003)(53936002)(16526018)(33656002)(16586007)(58126008)(33716001)(33896004)(59450400001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2526; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2526; 23:9JNW1M65VBGDo/clYDeYtlEqWmlMLsSzrevSHeGK9?= =?us-ascii?Q?ZRbjcB41ObomEMaqIANy11ywLYjS/SHs3qAsrCX5ml+x68JIIisPNp05abKr?= =?us-ascii?Q?JhYbE8Cm0A0ZZmPA8Am2+84PPgQXhLFATeCTijj7VXq1iRaPMWLSuUKn0+f3?= =?us-ascii?Q?s+4D5WpHUsxbWZTGbmVPtL+JoOglvlkzIzhkwCFCTlVYqtRblf1aSty4Q+iM?= =?us-ascii?Q?gU7xwMX6dAd87cnRt0ghBzdYYfUWYFfFH4bUzxadtsQotTvJd5+0lueikvap?= =?us-ascii?Q?k+JifOHxRgMpiBoKO9Th+DsGTG+bTXXRRW57iD7IyDKH3gGwiOuEdujDjaSw?= =?us-ascii?Q?1E+A5yKbYRx9PE+uCKo486p5dmRQPwGY3Ur0o7aAk9RZOj8F1nBlkci37iot?= =?us-ascii?Q?ZUYbmEqLNu2imgpmghUVXQjMYervf6NimD1FK6DGI6mPhxfu+y8OhJSqvZom?= =?us-ascii?Q?tCwEv3qZ1OVQXHGz//wFFmnYlOupXCbaTIOlejU/EGvprqkBCpbNykG0CzEb?= =?us-ascii?Q?oBabJ6eP0pX74utkC2JQOLcU8/I2zrfo8ADvWOncc8yg21/DysD+WAsp1opk?= =?us-ascii?Q?OVLzjx5sW+ZSurQvwk5pPq4Cv0F2/bYvRBykKdEYoHeZMVa8VDRFANkbqeD9?= =?us-ascii?Q?whkl3Mo/nHNxQFhUipFU5ymwxjrfWaZrl+APrTn/U3qBAw2jEGwl03wE8dKJ?= =?us-ascii?Q?+/bQJadau8xrbhQ5zLRtEy6HkjdCBnq7ZiO5DGcQfmPpzTknkEh6ABUG2d+M?= =?us-ascii?Q?/vpZVOOaaVD9sbV3V4Ad386MG+AfS805AL8PKZ0JHrNqxqTW5jqu6D7ClGMy?= =?us-ascii?Q?/8Z5qAQi7AsYK7G2R7nnGX/3Xk/eQpydeWhuM8FcWGp/KO9r4EasZyLZFUD6?= =?us-ascii?Q?OWwCp8XlKe71L7K6rfWzSc3QBbMnlCuQ+RJ4Uc6TjP3/yFbklBFFkuLHB91g?= =?us-ascii?Q?bR6YeQSUbzOw9JpPY8a9LXoaKGxt7q3zra4Ccw4sFNC8sxTHfrzhcu/ytIhP?= =?us-ascii?Q?6iIVbPW9HlcLRieHHxOybU6n4d618iPLt141LH86jlEsObHrTCv4kNiYhs3k?= =?us-ascii?Q?ev1v+HGPCXKHV3r9Be6VZUJKLK2+M12zvN5mQdDzGMg7YPISGeDoPaIxdF2J?= =?us-ascii?Q?Nf37dygjVPc0qYzU9mk+B2A2iJLhCUIJ0EfXDeoQLsq/dGPqfSbySWkMGVhG?= =?us-ascii?Q?OzxEwnbTPUmB5SdCKa7E0xIb6SVjkmEBi8Y2xmHzUA8M3pDeSH5TaIadotEb?= =?us-ascii?Q?mB68KWWvWpAVJuT83+Dqm2tWkQAhRhqxL33HXTu?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 6:WM1bswaSnoHRPQJJE/6EvLaQcBNoNHgwPYx2ofzQ2Y44FKTZf2quIYQcRUtoUkwj6VR7AaE1FWd5/jG/t5V8F4b5Lmk+N5vVvFSpLiu0Dj5Dv5qibxPBQjGrF/cWBqtOicrKmlmP/KS6t/Rwm2JhCpWqovH6tLor7Gr8Sdllg53qAFDtQNr/ku6szbYDoTw659j5/e6nAmCEEnfYjaJg5WcKYPDMeLZOOB22IsXFDKRUe/ViQWtag+4mSXPRQdyq79irFYEEVsJ3y66jNdFYuqcte6FmMFPF8QCq7SwYcbCEXv7Zo7xHNMh+TVMOHrQ2hIrZZb/dI064mv93GRX186X5uznnRgH9C6SN6FCzoUc=; 5:brcz2PReK3yOI7PPtXVIHGS18brPUP84peC718g4vnCpYZ9beeey4g1lueUJtalncUcn/WkXdG7sOr2FNwW3n1SySps+jWpCSuVtayjwlFt4zU5vTc1c64xG5j8HZJFbYDm8ir8pnOPxJSdIzCD37/7Ho+2wdReFTFtC60ymnIg=; 24:PmT31R4ul1CrGxKbrL0Z0MgvgKiEEsXDOkuKT56a81aki29hUs5cH7MELU/2r18VXLlWDrgjX3XEAvHApniN0rQ2svvGJyw6qaorm0lR8aM=; 7:C8Gm96Qe5TBKTLbSKtvwPaSSx2JXvxo1l5/vqyDDdDGwEPMBMkfziuQoBcXYfIXppjlP6M0sng3fSi+K+IlPSQwvZM9AlasB+Qfg6/ZyQsLVh5Vzg4+OiPYCidsAcviXy+d3bMFOpUA7ZHN6QrtRHNo25oT4P8dpqcc0isOPJC3bVXuHvbQkvE81iF5eSli5swR5zXlY6n+W1z0hEhsduR6/CSw/rVUIneq+J4oCie3ilDI0uCb2gJnJNg0oguwM SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2017 09:27:05.3150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f8f6bb6-f4cf-47a8-72eb-08d53ee70504 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2526 Subject: Re: [dpdk-dev] [PATCH 2/2] event/sw: use dynamically-sized IQs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Dec 2017 09:27:10 -0000 -----Original Message----- > Date: Thu, 7 Dec 2017 17:15:35 +0000 > From: "Van Haaren, Harry" > To: "Eads, Gage" , "dev@dpdk.org" > CC: "jerin.jacob@caviumnetworks.com" , > "Richardson, Bruce" , "hemant.agrawal@nxp.com" > , "nipun.gupta@nxp.com" , > "santosh.shukla@caviumnetworks.com" , > "pbhagavatula@caviumnetworks.com" > Subject: RE: [PATCH 2/2] event/sw: use dynamically-sized IQs > > > From: Eads, Gage > > Sent: Thursday, November 30, 2017 3:09 AM > > To: dev@dpdk.org > > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > > ; Richardson, Bruce > > ; hemant.agrawal@nxp.com; nipun.gupta@nxp.com; > > santosh.shukla@caviumnetworks.com; pbhagavatula@caviumnetworks.com > > Subject: [PATCH 2/2] event/sw: use dynamically-sized IQs > > > > This commit introduces dynamically-sized IQs, by switching the underlying > > data structure from a fixed-size ring to a linked list of queue 'chunks.' > > This has a number of benefits: > > - Certain corner cases were observed in which all of a pipeline's flows > > could be pinned to one port for extended periods, effectively turning a > > multi-core pipeline into single-core one. This was caused by an event > > producer having a larger new_event_threshold than the IQ depth, and > > injecting large numbers of packets that are ultimately backpressured in a > > worker's rx_ring, causing those packets' flows to be scheduled to that > > port. > > The dynamically sized IQ does not have this problem because each IQ can > > grow large enough to store all the system's events, such that > > backpressure will not reach the worker_ring. > > - Slight performance improvement (~1-2%) in high throughput scenarios, > > tested with eventdev_pipeline_sw_pmd. > > > > This implementation has a small increase in the queue storage memory > > footprint (~70KB). This commit also removes the iq_size xstat, which no > > longer applies to this implementation. > > > > Signed-off-by: Gage Eads > > Some review notes below - but nothing that needs changing. > > Acked-by: Harry van Haaren > Applied to dpdk-next-eventdev/master. Thanks. >