Re: [dpdk-dev] [PATCH 0/8] app/eventdev: add event eth Rx adapter support

[Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>]

Hi Jerin,

Thanks for the review, will make the chages required and will send out a v2.

Pavan.
On Sun, Dec 10, 2017 at 01:58:08PM +0530, Jerin Jacob wrote:
> -----Original Message-----
> > Date: Wed, 18 Oct 2017 18:09:00 +0530
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > To: bruce.richardson@intel.com, harry.van.haaren@intel.com,
> >  gage.eads@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
> >  nikhil.rao@intel.com, santosh.shukla@caviumnetworks.com,
> >  jerin.jacob@caviumnetworks.com
> > Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [PATCH 0/8] app/eventdev: add event eth Rx adapter support
> > X-Mailer: git-send-email 2.7.4
> >
> > The eventdev application uses producer lcores to inject packets as events
> > into the event device. This approach is suitable for doing synthetic
> > performance benchmarks. In most real-world scenarios the packets are
> > received by an Ethernet device.
> >
> > The Event Ethernet Rx Adapter library enables packet transfer between
> > ethernet dev and event dev transparently. This patch series adds an option
> > '--prod_type_ethdev' to configure the attached Ethernet devices as Rx adapters
> > and use them as producers instead of using synthetic producer cores. Also, this
> > is an RX only case.
> >
> > The application has been verified on both sw and hw event devices using the
> > command:
> >
> > ./build/app/dpdk-test-eventdev -c 0xfffff1 -s 0xf0000 --vdev="event_*"
> > -- --wlcores 12 --test perf_queue --verbose 20 --stlist=a
> > --prod_type_ethdev
>
> Please rebase to latest next-eventdev tree and fix following check patch
> warning.
>
> ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same
> indent
> #154: FILE: app/test-eventdev/evt_options.h:284:
> +	switch (opt->prod_type) {
> +		default:
> +		case EVT_PROD_TYPE_SYNT:
> [...]
> +		case EVT_PROD_TYPE_ETH_RX_ADPTR:
>
> >
> > Pavan Nikhilesh (8):
> >   app/eventdev: add ethernet device producer option
> >   app/eventdev: modify app setup to support ethdev
> >   app/eventdev: add pktmbuf pool for ethdev
> >   app/eventdev: add ethernet device setup helpers
> >   app/eventdev: add ethernet device tear down
> >   app/eventdev: add event Rx adapter setup
> >   app/eventdev: add service core configuration
> >   doc: update app eventdev options
> >
> >  app/test-eventdev/evt_common.h       |  41 +++---
> >  app/test-eventdev/evt_options.c      |  11 ++
> >  app/test-eventdev/evt_options.h      |  29 ++++
> >  app/test-eventdev/test_perf_atq.c    |  32 +++--
> >  app/test-eventdev/test_perf_common.c | 269 ++++++++++++++++++++++++++++++-----
> >  app/test-eventdev/test_perf_common.h |   4 +
> >  app/test-eventdev/test_perf_queue.c  |  35 +++--
> >  doc/guides/tools/testeventdev.rst    |  15 ++
> >  8 files changed, 361 insertions(+), 75 deletions(-)
> >
> > --
> > 2.7.4
> >