From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 429BCE5D; Mon, 11 Dec 2017 13:40:37 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 04:40:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="17273914" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.106]) by orsmga002.jf.intel.com with SMTP; 11 Dec 2017 04:40:32 -0800 Received: by (sSMTP sendmail emulation); Mon, 11 Dec 2017 12:40:33 +0000 Date: Mon, 11 Dec 2017 12:40:32 +0000 From: Bruce Richardson To: Hemant Agrawal Cc: dev@dpdk.org, ferruh.yigit@intel.com, Neil Horman , stable@dpdk.org, Jun Yang Message-ID: <20171211124032.GA11536@bricha3-MOBL3.ger.corp.intel.com> References: <1509617335-6354-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509617335-6354-1-git-send-email-hemant.agrawal@nxp.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for ARM BE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 12:40:38 -0000 On Thu, Nov 02, 2017 at 03:38:51PM +0530, Hemant Agrawal wrote: > cross compiling DPDK for BE mode on ARM results into errors > > "PMDINFO portal/dpaa2_hw_dpio.o.pmd.c No drivers registered" > > Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility") > Cc: Neil Horman > Cc: stable@dpdk.org > > Signed-off-by: Jun Yang > Signed-off-by: Hemant Agrawal > --- > buildtools/pmdinfogen/pmdinfogen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Comment could be a bit more specific about what the problem is and how changing the hard-coded "32" fixes it. Haven't tested the cross compilation part myself, but this causes no errors for 32-bit or 64-bit builds on my system. So, with some more detail on the specifics of the fix in the commit message: Acked-by: Bruce Richardson > diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c > index e73fc76..9119e52 100644 > --- a/buildtools/pmdinfogen/pmdinfogen.c > +++ b/buildtools/pmdinfogen/pmdinfogen.c > @@ -181,7 +181,7 @@ static int parse_elf(struct elf_info *info, const char *filename) > sechdrs[i].sh_offset = > TO_NATIVE(endian, ADDR_SIZE, sechdrs[i].sh_offset); > sechdrs[i].sh_size = > - TO_NATIVE(endian, 32, sechdrs[i].sh_size); > + TO_NATIVE(endian, ADDR_SIZE, sechdrs[i].sh_size); > sechdrs[i].sh_link = > TO_NATIVE(endian, 32, sechdrs[i].sh_link); > sechdrs[i].sh_info = > -- > 2.7.4 >